jaxon-php / jaxon-core

src/Traits/Upload.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
    /**
      * Check uploaded files validity and move them to the user dir
      *
-     * @return boolean
+     * @return null|boolean
      */
     public function saveUploadedFiles()
     {

Unused Use Statements -5 removed lines

@@ -19,11 +19,6 @@
 
 namespace Jaxon\Traits;
 
-use Jaxon\Plugin\Manager as PluginManager;
-use Jaxon\Request\Manager as RequestManager;
-use Jaxon\Response\Manager as ResponseManager;
-
-use Jaxon\Utils\URI;
 use Exception;
 use Closure;
 

Indentation +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
 
 trait Upload
 {
-   /**
+    /**
      * Check if uploaded files are available
      *
      * @return boolean
@@ -43,7 +43,7 @@ 
         return $xUploadPlugin->canProcessRequest();
     }
 
-   /**
+    /**
      * Check uploaded files validity and move them to the user dir
      *
      * @return boolean

Spacing +7 added lines, -7 removed lines

@@ -36,7 +36,7 @@ 
      */
     public function hasUploadedFiles()
     {
-        if(($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
+        if (($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
         {
             return false;
         }
@@ -52,11 +52,11 @@ 
     {
         try
         {
-            if(($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
+            if (($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
             {
                 throw new Exception($this->trans('errors.upload.plugin'));
             }
-            elseif(!$xUploadPlugin->canProcessRequest())
+            elseif (!$xUploadPlugin->canProcessRequest())
             {
                 throw new Exception($this->trans('errors.upload.request'));
             }
@@ -65,14 +65,14 @@ 
             $sResponse = '{"code": "success", "upl": "' . $sKey . '"}';
             $return = true;
         }
-        catch(Exception $e)
+        catch (Exception $e)
         {
             $sResponse = '{"code": "error", "msg": "' . addslashes($e->getMessage()) . '"}';
             $return = false;
         }
         // Send the response back to the browser
         echo '<script>var res = ', $sResponse, '; </script>';
-        if(($this->getOption('core.process.exit')))
+        if (($this->getOption('core.process.exit')))
         {
             exit();
         }
@@ -86,7 +86,7 @@ 
      */
     public function getUploadedFiles()
     {
-        if(($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
+        if (($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
         {
             return [];
         }
@@ -102,7 +102,7 @@ 
      */
     public function setUploadFileFilter(Closure $fFileFilter)
     {
-        if(($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
+        if (($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
         {
             return;
         }

Braces +2 added lines, -4 removed lines

@@ -55,8 +55,7 @@ 
             if(($xUploadPlugin = $this->getPluginManager()->getRequestPlugin(self::FILE_UPLOAD)) == null)
             {
                 throw new Exception($this->trans('errors.upload.plugin'));
-            }
-            elseif(!$xUploadPlugin->canProcessRequest())
+            } elseif(!$xUploadPlugin->canProcessRequest())
             {
                 throw new Exception($this->trans('errors.upload.request'));
             }
@@ -64,8 +63,7 @@ 
             $sKey = $xUploadPlugin->saveUploadedFiles();
             $sResponse = '{"code": "success", "upl": "' . $sKey . '"}';
             $return = true;
-        }
-        catch(Exception $e)
+        } catch(Exception $e)
         {
             $sResponse = '{"code": "error", "msg": "' . addslashes($e->getMessage()) . '"}';
             $return = false;

src/DI/Container.php

Doc Comments +1 added lines, -1 removed lines

@@ -241,7 +241,7 @@
     /**
      * Create a new the config manager
      *
-     * @return Jaxon\Utils\Config\Config            The config manager
+     * @return \Jaxon\Utils\Config\Config            The config manager
      */
     public function newConfig()
     {

Spacing +21 added lines, -21 removed lines

@@ -30,7 +30,7 @@ 
 
     public static function getInstance()
     {
-        if(!self::$xInstance)
+        if (!self::$xInstance)
         {
             self::$xInstance = new Container();
         }
@@ -90,19 +90,19 @@ 
          * Managers
          */
         // Plugin Manager
-        $this->coreContainer['jaxon.core.plugin_manager'] = function ($c) {
+        $this->coreContainer['jaxon.core.plugin_manager'] = function($c) {
             return new \Jaxon\Plugin\Manager();
         };
         // Request Manager
-        $this->coreContainer['jaxon.core.request_manager'] = function ($c) {
+        $this->coreContainer['jaxon.core.request_manager'] = function($c) {
             return new \Jaxon\Request\Manager();
         };
         // Request Factory
-        $this->coreContainer['jaxon.core.request_factory'] = function ($c) {
+        $this->coreContainer['jaxon.core.request_factory'] = function($c) {
             return new \Jaxon\Request\Factory();
         };
         // Response Manager
-        $this->coreContainer['jaxon.core.response_manager'] = function ($c) {
+        $this->coreContainer['jaxon.core.response_manager'] = function($c) {
             return new \Jaxon\Response\Manager();
         };
 
@@ -110,35 +110,35 @@ 
          * Services
          */
         // Config manager
-        $this->coreContainer['jaxon.core.config'] = function ($c) {
+        $this->coreContainer['jaxon.core.config'] = function($c) {
             return new \Jaxon\Utils\Config\Config();
         };
         // Minifier
-        $this->coreContainer['jaxon.core.minifier'] = function ($c) {
+        $this->coreContainer['jaxon.core.minifier'] = function($c) {
             return new \Jaxon\Utils\Template\Minifier();
         };
         // Translator
-        $this->coreContainer['jaxon.core.translator'] = function ($c) {
+        $this->coreContainer['jaxon.core.translator'] = function($c) {
             return new \Jaxon\Utils\Translation\Translator($c['jaxon.core.translation_dir'], $c['jaxon.core.config']);
         };
         // Template engine
-        $this->coreContainer['jaxon.core.template'] = function ($c) {
+        $this->coreContainer['jaxon.core.template'] = function($c) {
             return new \Jaxon\Utils\Template\Template($c['jaxon.core.template_dir']);
         };
         // Validator
-        $this->coreContainer['jaxon.core.validator'] = function ($c) {
+        $this->coreContainer['jaxon.core.validator'] = function($c) {
             return new \Jaxon\Utils\Validation\Validator($c['jaxon.core.translator'], $c['jaxon.core.config']);
         };
         // Pagination Renderer
-        $this->coreContainer['jaxon.pagination.renderer'] = function ($c) {
+        $this->coreContainer['jaxon.pagination.renderer'] = function($c) {
             return new \Jaxon\Utils\Pagination\Renderer();
         };
         // Pagination Paginator
-        $this->coreContainer['jaxon.pagination.paginator'] = function ($c) {
+        $this->coreContainer['jaxon.pagination.paginator'] = function($c) {
             return new \Jaxon\Utils\Pagination\Paginator($c['jaxon.pagination.renderer']);
         };
         // Event Dispatcher
-        $this->coreContainer['jaxon.core.events'] = function ($c) {
+        $this->coreContainer['jaxon.core.events'] = function($c) {
             return new EventDispatcher();
         };
 
@@ -146,15 +146,15 @@ 
          * Core library objects
          */
         // Global Response
-        $this->coreContainer['jaxon.core.response'] = function ($c) {
+        $this->coreContainer['jaxon.core.response'] = function($c) {
             return new \Jaxon\Response\Response();
         };
         // Jaxon Core
-        $this->coreContainer['jaxon.core.jaxon'] = function ($c) {
+        $this->coreContainer['jaxon.core.jaxon'] = function($c) {
             return new \Jaxon\Jaxon();
         };
         // View Renderer Facade
-        $this->coreContainer['jaxon.sentry.view.renderer'] = function ($c) {
+        $this->coreContainer['jaxon.sentry.view.renderer'] = function($c) {
             $aRenderers = $c['jaxon.view.data.renderers'];
             $sDefaultNamespace = $c['jaxon.view.data.namespace.default'];
             return new \Jaxon\Sentry\View\Facade($aRenderers, $sDefaultNamespace);
@@ -168,7 +168,7 @@ 
      */
     public function get($sClass)
     {
-        if($this->sentryContainer != null && $this->sentryContainer->has($sClass))
+        if ($this->sentryContainer != null && $this->sentryContainer->has($sClass))
         {
             return $this->sentryContainer->get($sClass);
         }
@@ -443,14 +443,14 @@ 
         $this->coreContainer['jaxon.sentry.view.base.' . $sId] = $xClosure;
 
         // Return the initialized view renderer
-        $this->coreContainer['jaxon.sentry.view.' . $sId] = function ($c) use ($sId) {
+        $this->coreContainer['jaxon.sentry.view.' . $sId] = function($c) use ($sId) {
             // Get the defined renderer
             $renderer = $c['jaxon.sentry.view.base.' . $sId];
             // Init the renderer with the template namespaces
             $aNamespaces = $this->coreContainer['jaxon.view.data.namespaces'];
-            if(key_exists($sId, $aNamespaces))
+            if (key_exists($sId, $aNamespaces))
             {
-                foreach($aNamespaces[$sId] as $ns)
+                foreach ($aNamespaces[$sId] as $ns)
                 {
                     $renderer->addNamespace($ns['namespace'], $ns['directory'], $ns['extension']);
                 }
@@ -468,7 +468,7 @@ 
      */
     public function getViewRenderer($sId = '')
     {
-        if(!$sId)
+        if (!$sId)
         {
             // Return the view renderer facade
             return $this->coreContainer['jaxon.sentry.view.renderer'];

src/Traits/Autoload.php

Unused Use Statements -2 removed lines

@@ -19,8 +19,6 @@
 
 namespace Jaxon\Traits;
 
-use Jaxon\DI\Container;
-
 trait Autoload
 {
     /**

src/JQuery/Dom/Element.php

Spacing +3 added lines, -3 removed lines

@@ -54,11 +54,11 @@ 
         $this->aCalls = array();
 
         $jQueryNs = jaxon()->getOption('core.jquery.no_conflict', false) ? 'jQuery' : '$';
-        if(!$sSelector)
+        if (!$sSelector)
         {
             $this->sSelector = "$jQueryNs(this)"; // If an empty selector is given, use javascript "this" instead
         }
-        elseif(($sContext))
+        elseif (($sContext))
         {
             $this->sSelector = "$jQueryNs('" . $sSelector . "', $jQueryNs('" . $sContext . "'))";
         }
@@ -114,7 +114,7 @@ 
      */
     public function getScript()
     {
-        if(count($this->aCalls) == 0)
+        if (count($this->aCalls) == 0)
         {
             return $this->sSelector;
         }

Braces +2 added lines, -4 removed lines

@@ -57,12 +57,10 @@
         if(!$sSelector)
         {
             $this->sSelector = "$jQueryNs(this)"; // If an empty selector is given, use javascript "this" instead
-        }
-        elseif(($sContext))
+        } elseif(($sContext))
         {
             $this->sSelector = "$jQueryNs('" . $sSelector . "', $jQueryNs('" . $sContext . "'))";
-        }
-        else
+        } else
         {
             $this->sSelector = "$jQueryNs('" . $sSelector . "')";
         }

src/Request/Support/CallableObject.php

Spacing +25 added lines, -25 removed lines

@@ -93,7 +93,7 @@ 
      */
     public function __construct($xCallable)
     {
-        if(is_string($xCallable)) // Received a class name
+        if (is_string($xCallable)) // Received a class name
         {
             $this->reflectionClass = new \ReflectionClass($xCallable);
             $this->callableObject = null;
@@ -119,14 +119,14 @@ 
      */
     private function setCallable($xCallable = null)
     {
-        if($xCallable == null)
+        if ($xCallable == null)
         {
             // Use the Reflection class to get the parameters of the constructor
-            if(($constructor = $this->reflectionClass->getConstructor()) != null)
+            if (($constructor = $this->reflectionClass->getConstructor()) != null)
             {
                 $parameters = $constructor->getParameters();
                 $parameterInstances = [];
-                foreach($parameters as $parameter)
+                foreach ($parameters as $parameter)
                 {
                     // Get the parameter instance from the DI
                     $parameterInstances[] = $this->diGet($parameter->getClass()->getName());
@@ -139,7 +139,7 @@ 
             }
         }
         // Save the Jaxon callable object into the user callable object
-        if($this->reflectionClass->hasMethod('setJaxonCallable'))
+        if ($this->reflectionClass->hasMethod('setJaxonCallable'))
         {
             $xCallable->setJaxonCallable($this);
         }
@@ -153,7 +153,7 @@ 
      */
     public function getRegisteredObject()
     {
-        if($this->callableObject == null)
+        if ($this->callableObject == null)
         {
             $this->setCallable();
         }
@@ -181,7 +181,7 @@ 
         // The class name without the namespace.
         $name = $this->reflectionClass->getShortName();
         // Append the classpath to the name
-        if(($this->classpath))
+        if (($this->classpath))
         {
             $name = $this->classpath . '\\' . $name;
         }
@@ -228,16 +228,16 @@ 
     public function getMethods()
     {
         $aReturn = [];
-        foreach($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
+        foreach ($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
         {
             $sMethodName = $xMethod->getShortName();
             // Don't take magic __call, __construct, __destruct methods
-            if(strlen($sMethodName) > 2 && substr($sMethodName, 0, 2) == '__')
+            if (strlen($sMethodName) > 2 && substr($sMethodName, 0, 2) == '__')
             {
                 continue;
             }
             // Don't take excluded methods
-            if(in_array($sMethodName, $this->aProtectedMethods))
+            if (in_array($sMethodName, $this->aProtectedMethods))
             {
                 continue;
             }
@@ -258,37 +258,37 @@ 
     public function configure($sMethod, $sName, $sValue)
     {
         // Set the namespace
-        if($sName == 'namespace')
+        if ($sName == 'namespace')
         {
-            if($sValue != '')
+            if ($sValue != '')
                 $this->namespace = $sValue;
             return;
         }
         // Set the classpath
-        if($sName == 'classpath')
+        if ($sName == 'classpath')
         {
-            if($sValue != '')
+            if ($sValue != '')
                 $this->classpath = trim($sValue, '\\');
             return;
         }
         // Set the separator
-        if($sName == 'separator')
+        if ($sName == 'separator')
         {
-            if($sValue == '_' || $sValue == '.')
+            if ($sValue == '_' || $sValue == '.')
                 $this->separator = $sValue;
             return;
         }
         // Set the excluded methods
-        if($sName == 'protected')
+        if ($sName == 'protected')
         {
-            if(is_array($sValue))
+            if (is_array($sValue))
                 $this->aProtectedMethods = array_merge($this->aProtectedMethods, $sValue);
-            elseif(is_string($sValue))
+            elseif (is_string($sValue))
                 $this->aProtectedMethods[] = $sValue;
             return;
         }
 
-        if(!isset($this->aConfiguration[$sMethod]))
+        if (!isset($this->aConfiguration[$sMethod]))
         {
             $this->aConfiguration[$sMethod] = [];
         }
@@ -309,16 +309,16 @@ 
 
         // Common options to be set on all methods
         $aCommonConfig = array_key_exists('*', $this->aConfiguration) ? $this->aConfiguration['*'] : [];
-        foreach($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
+        foreach ($this->reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $xMethod)
         {
             $sMethodName = $xMethod->getShortName();
             // Don't export magic __call, __construct, __destruct methods
-            if(strlen($sMethodName) > 0 && substr($sMethodName, 0, 2) == '__')
+            if (strlen($sMethodName) > 0 && substr($sMethodName, 0, 2) == '__')
             {
                 continue;
             }
             // Don't export "protected" methods
-            if(in_array($sMethodName, $this->aProtectedMethods))
+            if (in_array($sMethodName, $this->aProtectedMethods))
             {
                 continue;
             }
@@ -368,14 +368,14 @@ 
      */
     public function call($sMethod, $aArgs)
     {
-        if(!$this->hasMethod($sMethod))
+        if (!$this->hasMethod($sMethod))
         {
             return;
         }
         $reflectionMethod = $this->reflectionClass->getMethod($sMethod);
         $callableObject = $this->getRegisteredObject();
         $response = $reflectionMethod->invokeArgs($callableObject, $aArgs);
-        if(($response))
+        if (($response))
         {
             $this->getResponseManager()->append($response);
         }

Braces +19 added lines, -15 removed lines

@@ -93,12 +93,13 @@ 
      */
     public function __construct($xCallable)
     {
-        if(is_string($xCallable)) // Received a class name
+        if(is_string($xCallable)) {
+            // Received a class name
         {
             $this->reflectionClass = new \ReflectionClass($xCallable);
-            $this->callableObject = null;
         }
-        else // if(is_object($xCallable)) // Received a class instance
+            $this->callableObject = null;
+        } else // if(is_object($xCallable)) // Received a class instance
         {
             $this->reflectionClass = new \ReflectionClass(get_class($xCallable));
             $this->setCallable($xCallable);
@@ -132,8 +133,7 @@ 
                     $parameterInstances[] = $this->diGet($parameter->getClass()->getName());
                 }
                 $xCallable = $this->reflectionClass->newInstanceArgs($parameterInstances);
-            }
-            else
+            } else
             {
                 $xCallable = $this->reflectionClass->newInstance();
             }
@@ -260,31 +260,35 @@ 
         // Set the namespace
         if($sName == 'namespace')
         {
-            if($sValue != '')
-                $this->namespace = $sValue;
+            if($sValue != '') {
+                            $this->namespace = $sValue;
+            }
             return;
         }
         // Set the classpath
         if($sName == 'classpath')
         {
-            if($sValue != '')
-                $this->classpath = trim($sValue, '\\');
+            if($sValue != '') {
+                            $this->classpath = trim($sValue, '\\');
+            }
             return;
         }
         // Set the separator
         if($sName == 'separator')
         {
-            if($sValue == '_' || $sValue == '.')
-                $this->separator = $sValue;
+            if($sValue == '_' || $sValue == '.') {
+                            $this->separator = $sValue;
+            }
             return;
         }
         // Set the excluded methods
         if($sName == 'protected')
         {
-            if(is_array($sValue))
-                $this->aProtectedMethods = array_merge($this->aProtectedMethods, $sValue);
-            elseif(is_string($sValue))
-                $this->aProtectedMethods[] = $sValue;
+            if(is_array($sValue)) {
+                            $this->aProtectedMethods = array_merge($this->aProtectedMethods, $sValue);
+            } elseif(is_string($sValue)) {
+                            $this->aProtectedMethods[] = $sValue;
+            }
             return;
         }