Jaxon\Di\Traits\ViewTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getDialog()	0	3	1
A	getViewManager()	0	3	1
A	getPaginator()	0	3	1
A	getViewRenderer()	0	3	1
A	registerViews()	0	31	1

<?php

Missing file doc comment

namespace Jaxon\Di\Traits;

use Jaxon\Di\Container;
use Jaxon\Ui\Dialogs\DialogFacade;
use Jaxon\Ui\Pagination\Paginator;
use Jaxon\Ui\Pagination\PaginationRenderer;
use Jaxon\Ui\Template\TemplateView;
use Jaxon\Ui\View\ViewManager;
use Jaxon\Ui\View\ViewRenderer;
use Jaxon\Utils\Template\TemplateEngine;

The type Jaxon\Utils\Template\TemplateEngine was not found. Maybe you did not declare it correctly or list all dependencies?

trait ViewTrait

Missing doc comment for trait ViewTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerViews()

Expected 2 blank lines before function; 0 found

    {
        // Dialog Facade
        $this->set(DialogFacade::class, function($c) {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new DialogFacade($c->g(Container::class));
        });
        // View Manager
        $this->set(ViewManager::class, function($c) {
            $xViewManager = new ViewManager($this);
            // Add the default view renderer
            $xViewManager->addRenderer('jaxon', function($di) {
                return new TemplateView($di->g(TemplateEngine::class));
            });
            $sTemplateDir = rtrim(trim($c->g('jaxon.core.dir.template')), '/\\');

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

            $sPaginationDir = $sTemplateDir . DIRECTORY_SEPARATOR . 'pagination';
            // By default, render pagination templates with Jaxon.
            $xViewManager->addNamespace('jaxon', $sTemplateDir, '.php', 'jaxon');
            $xViewManager->addNamespace('pagination', $sPaginationDir, '.php', 'jaxon');
            return $xViewManager;
        });
        // View Renderer
        $this->set(ViewRenderer::class, function($c) {
            return new ViewRenderer($c->g(ViewManager::class));
        });
        // Pagination Paginator
        $this->set(Paginator::class, function($c) {
            return new Paginator($c->g(PaginationRenderer::class));
        });
        // Pagination Renderer
        $this->set(PaginationRenderer::class, function($c) {
            return new PaginationRenderer($c->g(ViewRenderer::class));
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the dialog wrapper
     *
     * @return DialogFacade
     */
    public function getDialog(): DialogFacade
    {
        return $this->g(DialogFacade::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the view manager
     *
     * @return ViewManager
     */
    public function getViewManager(): ViewManager
    {
        return $this->g(ViewManager::class);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the view facade
     *
     * @return ViewRenderer
     */
    public function getViewRenderer(): ViewRenderer
    {
        return $this->g(ViewRenderer::class);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the paginator
     *
     * @return Paginator
     */
    public function getPaginator(): Paginator
    {
        return $this->g(Paginator::class);
    }

Expected 2 blank lines after function; 0 found

}