Jaxon\Di\Traits\SessionTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	registerSessions()	0	5	1
A	getSessionManager()	0	3	1
A	setSessionManager()	0	3	1

<?php

Missing file doc comment

namespace Jaxon\Di\Traits;

use Closure;
use Jaxon\Session\SessionInterface;
use Jaxon\Session\SessionManager;

trait SessionTrait

Missing doc comment for trait SessionTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerSessions()

Expected 2 blank lines before function; 0 found

    {
        // Set the default session manager
        $this->set(SessionInterface::class, function() {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new SessionManager();
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the session manager
     *
     * @return SessionInterface
     */
    public function getSessionManager(): SessionInterface
    {
        return $this->g(SessionInterface::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 1 found

    /**
     * Set the session manager
     *
     * @param Closure $xClosure    A closure to create the session manager instance

Expected 1 spaces after parameter name; 4 found

     *
     * @return void
     */
    public function setSessionManager(Closure $xClosure)
    {
        $this->set(SessionInterface::class, $xClosure);
    }

Expected 2 blank lines after function; 0 found

}