Jaxon\Di\Traits\RequestTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	registerRequests()	0	30	1
A	getRequestHandler()	0	3	1

<?php

Missing file doc comment

namespace Jaxon\Di\Traits;

use Jaxon\Config\ConfigManager;
use Jaxon\Di\Container;
use Jaxon\Plugin\Manager\PluginManager;
use Jaxon\Request\Factory\Factory;
use Jaxon\Request\Factory\ParameterFactory;
use Jaxon\Request\Factory\RequestFactory;
use Jaxon\Request\Handler\ArgumentManager;
use Jaxon\Request\Handler\CallbackManager;
use Jaxon\Request\Handler\RequestHandler;
use Jaxon\Request\Handler\UploadHandler;
use Jaxon\Request\Plugin\CallableClass\CallableRegistry;
use Jaxon\Response\Plugin\DataBag\DataBagPlugin;
use Jaxon\Response\ResponseManager;
use Jaxon\Ui\Dialogs\DialogFacade;
use Jaxon\Ui\Pagination\Paginator;
use Jaxon\Utils\Translation\Translator;

trait RequestTrait

Missing doc comment for trait RequestTrait

{
    /**
     * Register the values into the container
     *
     * @return void
     */
    private function registerRequests()

Expected 2 blank lines before function; 0 found

    {
        // Argument Manager
        $this->set(ArgumentManager::class, function($c) {

It seems like set() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return new ArgumentManager($c->g(ConfigManager::class), $c->g(Translator::class));
        });
        // Callback Manager
        $this->set(CallbackManager::class, function() {
            return new CallbackManager();
        });
        // Request Handler
        $this->set(RequestHandler::class, function($c) {
            return new RequestHandler($c->g(Container::class), $c->g(ConfigManager::class),
                $c->g(ArgumentManager::class), $c->g(PluginManager::class), $c->g(ResponseManager::class),
                $c->g(CallbackManager::class), $c->g(UploadHandler::class), $c->g(DataBagPlugin::class),
                $c->g(Translator::class));
        });
        // Request Factory
        $this->set(Factory::class, function($c) {
            return new Factory($c->g(CallableRegistry::class), $c->g(RequestFactory::class),
                $c->g(ParameterFactory::class));
        });
        // Factory for requests to functions
        $this->set(RequestFactory::class, function($c) {
            $sPrefix = $c->g(ConfigManager::class)->getOption('core.prefix.function');
            return new RequestFactory($sPrefix, $c->g(DialogFacade::class), $c->g(Paginator::class));
        });
        // Parameter Factory
        $this->set(ParameterFactory::class, function() {
            return new ParameterFactory();
        });
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the request handler
     *
     * @return RequestHandler
     */
    public function getRequestHandler(): RequestHandler
    {
        return $this->g(RequestHandler::class);

It seems like g() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

Expected 2 blank lines after function; 0 found

}