Jaxon\Response\Response::getCommandData()

Complexity

Conditions	11
Paths	7

Size

Total Lines	29
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Response::addCommand()	0	10	2

<?php

/**
 * Response.php - The Jaxon Response
 *
 * This class collects commands to be sent back to the browser in response to a jaxon request.
 * Commands are encoded and packaged in json format.
 *
 * Common commands include:
 * - <Response->assign>: Assign a value to an element's attribute.
 * - <Response->append>: Append a value on to an element's attribute.
 * - <Response->script>: Execute a portion of javascript code.
 * - <Response->call>: Execute an existing javascript function.
 * - <Response->alert>: Display an alert dialog to the user.
 *
 * Elements are identified by the value of the HTML id attribute.
 *
 * @package jaxon-core

Package name "jaxon-core" is not valid; consider "Jaxoncore" instead

 * @author Jared White

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author J. Max Wilson

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author Joseph Woolley

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author Steffen Konerow

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @copyright Copyright (c) 2005-2007 by Jared White & J. Max Wilson

@copyright tag must contain a year and the name of the copyright holder

 * @copyright Copyright (c) 2008-2010 by Joseph Woolley, Steffen Konerow, Jared White  & J. Max Wilson

@copyright tag must contain a year and the name of the copyright holder

 * @copyright 2016 Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @license https://opensource.org/licenses/BSD-3-Clause BSD 3-Clause License
 * @link https://github.com/jaxon-php/jaxon-core
 */

PHP version not specified

Missing @category tag in file comment

namespace Jaxon\Response;

use Jaxon\Plugin\PluginManager;
use Jaxon\Plugin\ResponsePlugin;
use Jaxon\Response\Plugin\DataBag\DataBagContext;
use Jaxon\Response\Plugin\JQuery\DomSelector;
use Jaxon\Utils\Translation\Translator;
use Jaxon\Exception\RequestException;

use function array_keys;
use function array_map;
use function array_merge;
use function count;
use function is_array;
use function is_integer;
use function json_encode;
use function trim;

class Response extends AbstractResponse

Missing doc comment for class Response

{
    use Traits\DomTrait;
    use Traits\JsTrait;
    use Traits\DomTreeTrait;

    /**
     * @var Translator
     */
    protected $xTranslator;

    /**
     * @var PluginManager
     */
    protected $xPluginManager;

    /**
     * The commands that will be sent to the browser in the response
     *
     * @var array
     */
    protected $aCommands = [];

    /**
     * A string, array or integer value to be returned to the caller when using 'synchronous' mode requests.
     * See <jaxon->setMode> for details.
     *
     * @var mixed
     */
    protected $xReturnValue;

    /**
     * The constructor
     *
     * @param Translator $xTranslator

Expected 4 spaces after parameter type; 1 found

Missing parameter comment

     * @param PluginManager $xPluginManager

Missing parameter comment

     */
    public function __construct(Translator $xTranslator, PluginManager $xPluginManager)

Expected 2 blank lines before function; 1 found

    {
        $this->xTranslator = $xTranslator;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $this->xPluginManager = $xPluginManager;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Create a new Jaxon response object
     *
     * @return Response
     */
    public function newResponse(): Response
    {
        return new Response($this->xTranslator, $this->xPluginManager);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the content type, which is always set to 'application/json'
     *
     * @return string
     */
    public function getContentType(): string
    {
        return 'application/json';
    }

Expected 2 blank lines after function; 1 found

    /**
     * Provides access to registered response plugins
     *
     * Pass the plugin name as the first argument and the plugin object will be returned.
     *
     * @param string $sName    The name of the plugin

Expected 1 spaces after parameter name; 4 found

     *
     * @return null|ResponsePlugin
     */
    public function plugin(string $sName): ?ResponsePlugin
    {
        return $this->xPluginManager->getResponsePlugin($sName, $this);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Magic PHP function
     *
     * Used to permit plugins to be called as if they were native members of the Response instance.
     *
     * @param string $sPluginName    The name of the plugin

Expected 1 spaces after parameter name; 4 found

     *
     * @return null|ResponsePlugin
     */
    public function __get(string $sPluginName)
    {
        return $this->plugin($sPluginName);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Create a JQuery DomSelector, and link it to the current response.
     *
     * This is a shortcut to the JQuery plugin.
     *
     * @param string $sPath    The jQuery selector path
     * @param string $sContext    A context associated to the selector

Expected 1 spaces after parameter name; 4 found

     *
     * @return DomSelector
     */
    public function jq(string $sPath = '', string $sContext = ''): DomSelector
    {
        return $this->plugin('jquery')->selector($sPath, $sContext);

The method selector() does not exist on Jaxon\Plugin\ResponsePlugin. It seems like you code against a sub-type of Jaxon\Plugin\ResponsePlugin such as Jaxon\Response\Plugin\JQuery\JQueryPlugin.

    }

Expected 2 blank lines after function; 1 found

    /**
     * @param string $sName

Missing parameter comment

     *
     * @return DataBagContext
     */
    public function bag(string $sName): DataBagContext
    {
        return $this->plugin('bags')->bag($sName);;

The method bag() does not exist on Jaxon\Plugin\ResponsePlugin. It seems like you code against a sub-type of Jaxon\Plugin\ResponsePlugin such as Jaxon\Response\Plugin\DataBag\DataBagPlugin.

    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a response command to the array of commands that will be sent to the browser
     *
     * @param array $aAttributes    Associative array of attributes that will describe the command

Expected 1 spaces after parameter name; 4 found

     * @param mixed $mData    The data to be associated with this command

Expected 7 spaces after parameter name; 4 found

     *
     * @return Response
     */
    public function addCommand(array $aAttributes, $mData): Response
    {
        $aAttributes = array_map(function($xAttribute) {
            return is_integer($xAttribute) ? $xAttribute : trim((string)$xAttribute, " \t");
        }, $aAttributes);

        $aAttributes['data'] = $mData;
        $this->aCommands[] = $aAttributes;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a response command to the array of commands that will be sent to the browser
     *
     * @param string $sName    The command name

Expected 8 spaces after parameter name; 4 found

     * @param array $aAttributes    Associative array of attributes that will describe the command

Expected 2 spaces after parameter name; 4 found

Expected 2 spaces after parameter type; 1 found

     * @param mixed $mData    The data to be associated with this command

Expected 2 spaces after parameter type; 1 found

Expected 8 spaces after parameter name; 4 found

     * @param bool $bRemoveEmpty    If true, remove empty attributes

Expected 1 spaces after parameter name; 4 found

Expected 3 spaces after parameter type; 1 found

     *
     * @return Response
     */
    protected function _addCommand(string $sName, array $aAttributes, $mData, bool $bRemoveEmpty = false): Response
    {
        $mData = is_array($mData) ? array_map(function($sData) {
            return trim((string)$sData, " \t\n");
        }, $mData) : trim((string)$mData, " \t\n");

        if($bRemoveEmpty)
        {
            foreach(array_keys($aAttributes) as $sAttr)
            {
                if($aAttributes[$sAttr] === '')
                {
                    unset($aAttributes[$sAttr]);
                }
            }
        }

        $aAttributes['cmd'] = $sName;
        return $this->addCommand($aAttributes, $mData);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Clear all the commands already added to the response
     *
     * @return Response
     */
    public function clearCommands(): Response
    {
        $this->aCommands = [];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a response command that is generated by a plugin
     *
     * @param ResponsePlugin $xPlugin    The plugin object

Expected 5 spaces after parameter name; 4 found

     * @param array $aAttributes    The attributes for this response command

Expected 10 spaces after parameter type; 1 found

Expected 1 spaces after parameter name; 4 found

     * @param mixed $mData    The data to be sent with this command

Expected 7 spaces after parameter name; 4 found

Expected 10 spaces after parameter type; 1 found

     *
     * @return Response
     */
    public function addPluginCommand(ResponsePlugin $xPlugin, array $aAttributes, $mData): Response
    {
        $aAttributes['plg'] = $xPlugin->getName();
        return $this->addCommand($aAttributes, $mData);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Merge the response commands from the specified <Response> object with
     * the response commands in this <Response> object
     *
     * @param Response|array $mCommands    The <Response> object

Expected 1 spaces after parameter name; 4 found

     * @param bool $bBefore    Add the new commands to the beginning of the list

Expected 11 spaces after parameter type; 1 found

Expected 3 spaces after parameter name; 4 found

     *
     * @return void
     * @throws RequestException
     */
    public function appendResponse($mCommands, bool $bBefore = false)
    {
        if($mCommands instanceof Response)
        {
            $this->xReturnValue = $mCommands->xReturnValue;
            $aCommands = $mCommands->aCommands;

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

        }
        elseif(is_array($mCommands))

The condition is_array($mCommands) is always true.

        {
            $aCommands = $mCommands;
        }
        else
        {
            throw new RequestException($this->xTranslator->trans('errors.response.data.invalid'));
        }

        $this->aCommands = ($bBefore) ?

Expected 1 space after "?"; newline found

            array_merge($aCommands, $this->aCommands) :

Expected 1 space after ":"; newline found

            array_merge($this->aCommands, $aCommands);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the commands in the response
     *
     * @return array
     */
    public function getCommands(): array
    {
        return $this->aCommands;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Get the number of commands in the response
     *
     * @return int
     */
    public function getCommandCount(): int
    {
        return count($this->aCommands);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Stores a value that will be passed back as part of the response
     *
     * When making synchronous requests, the calling javascript can obtain this value
     * immediately as the return value of the <jaxon.call> javascript function
     *
     * @param mixed $value    Any value

Expected 1 spaces after parameter name; 4 found

     *
     * @return Response
     */
    public function setReturnValue($value): Response
    {
        $this->xReturnValue = $value;
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Return the output, generated from the commands added to the response, that will be sent to the browser
     *
     * @return string
     */
    public function getOutput(): string
    {
        $aResponse = ['jxnobj' => []];
        if(($this->xReturnValue))
        {
            $aResponse['jxnrv'] = $this->xReturnValue;
        }
        foreach($this->aCommands as $xCommand)
        {
            $aResponse['jxnobj'][] = $xCommand;
        }

        return json_encode($aResponse);
    }

Expected 2 blank lines after function; 0 found

}