View GitHub Repository jaxon-core

Schedule Inspection
Subscribe
Passed
Push — feature/code_improvement ( 7e1ceb...8fdd7e )
by Thierry
11:18
created
Status
Category
Toggle Patches
src/Features/Validator.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -28,7 +28,7 @@  discard block
 
 block discarded – undo
28 28 
      *
29 29 
      * @param string        $sName            The function name
30 30 
      *
31 
-     * @return bool            True if the function name is valid, and false if not
31 
+     * @return integer            True if the function name is valid, and false if not
32 32 
      */
33 33 
     public function validateFunction($sName)
34 34 
     {
 
@@ -40,7 +40,7 @@  discard block
 
 block discarded – undo
40 40 
      *
41 41 
      * @param string        $sName            The event name
42 42 
      *
43 
-     * @return bool            True if the event name is valid, and false if not
43 
+     * @return integer            True if the event name is valid, and false if not
44 44 
      */
45 45 
     public function validateEvent($sName)
46 46 
     {
 
@@ -52,7 +52,7 @@  discard block
 
 block discarded – undo
52 52 
      *
53 53 
      * @param string        $sName            The class name
54 54 
      *
55 
-     * @return bool            True if the class name is valid, and false if not
55 
+     * @return integer            True if the class name is valid, and false if not
56 56 
      */
57 57 
     public function validateClass($sName)
58 58 
     {
 
@@ -64,7 +64,7 @@  discard block
 
 block discarded – undo
64 64 
      *
65 65 
      * @param string        $sName            The function name
66 66 
      *
67 
-     * @return bool            True if the method name is valid, and false if not
67 
+     * @return integer            True if the method name is valid, and false if not
68 68 
      */
69 69 
     public function validateMethod($sName)
70 70 
     {
Please login to merge, or discard this patch.
src/Plugin/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@
 
 block discarded – undo
41 41 
      * @param string        $sCallable      The callable entity being registered
42 42 
      * @param array|string  $aOptions       The associated options
43 43 
      *
44 
-     * @return mixed
44 
+     * @return boolean
45 45 
      */
46 46 
     public function register($sType, $sCallable, $aOptions)
47 47 
     {
Please login to merge, or discard this patch.
src/Request/Factory/Features/Condition.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -30,7 +30,7 @@  discard block
 
 block discarded – undo
30 30 
      *
31 31 
      * @param string        $sCondition               The condition to check
32 32 
      *
33 
-     * @return Request
33 
+     * @return Condition
34 34 
      */
35 35 
     public function when($sCondition)
36 36 
     {
 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
      *
46 46 
      * @param string        $sCondition               The condition to check
47 47 
      *
48 
-     * @return Request
48 
+     * @return Condition
49 49 
      */
50 50 
     public function unless($sCondition)
51 51 
     {
 
@@ -59,7 +59,7 @@  discard block
 
 block discarded – undo
59 59 
      * @param string        $sValue1                  The first value to compare
60 60 
      * @param string        $sValue2                  The second value to compare
61 61 
      *
62 
-     * @return Request
62 
+     * @return Condition
63 63 
      */
64 64 
     public function ifeq($sValue1, $sValue2)
65 65 
     {
 
@@ -73,7 +73,7 @@  discard block
 
 block discarded – undo
73 73 
      * @param string        $sValue1                  The first value to compare
74 74 
      * @param string        $sValue2                  The second value to compare
75 75 
      *
76 
-     * @return Request
76 
+     * @return Condition
77 77 
      */
78 78 
     public function ifne($sValue1, $sValue2)
79 79 
     {
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
      * @param string        $sValue1                  The first value to compare
88 88 
      * @param string        $sValue2                  The second value to compare
89 89 
      *
90 
-     * @return Request
90 
+     * @return Condition
91 91 
      */
92 92 
     public function ifgt($sValue1, $sValue2)
93 93 
     {
 
@@ -101,7 +101,7 @@  discard block
 
 block discarded – undo
101 101 
      * @param string        $sValue1                  The first value to compare
102 102 
      * @param string        $sValue2                  The second value to compare
103 103 
      *
104 
-     * @return Request
104 
+     * @return Condition
105 105 
      */
106 106 
     public function ifge($sValue1, $sValue2)
107 107 
     {
 
@@ -115,7 +115,7 @@  discard block
 
 block discarded – undo
115 115 
      * @param string        $sValue1                  The first value to compare
116 116 
      * @param string        $sValue2                  The second value to compare
117 117 
      *
118 
-     * @return Request
118 
+     * @return Condition
119 119 
      */
120 120 
     public function iflt($sValue1, $sValue2)
121 121 
     {
 
@@ -129,7 +129,7 @@  discard block
 
 block discarded – undo
129 129 
      * @param string        $sValue1                  The first value to compare
130 130 
      * @param string        $sValue2                  The second value to compare
131 131 
      *
132 
-     * @return Request
132 
+     * @return Condition
133 133 
      */
134 134 
     public function ifle($sValue1, $sValue2)
135 135 
     {
Please login to merge, or discard this patch.
src/Request/Factory/JsCall.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62 
     /**
63 63 
      * Instruct the request to use single quotes when generating the javascript
64 64 
      *
65 
-     * @return void
65 
+     * @return JsCall
66 66 
      */
67 67 
     public function useSingleQuote()
68 68 
     {
 
@@ -73,7 +73,7 @@  discard block
 
 block discarded – undo
73 73 
     /**
74 74 
      * Instruct the request to use single quotes when generating the javascript
75 75 
      *
76 
-     * @return void
76 
+     * @return JsCall
77 77 
      */
78 78 
     public function useSingleQuotes()
79 79 
     {
Please login to merge, or discard this patch.
src/Response/Features/JsCommands.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,7 @@  discard block
 
 block discarded – undo
27 27 
      *
28 28 
      * @param string        $sName              The command name
29 29 
      * @param array         $aAttributes        Associative array of attributes that will describe the command
30 
-     * @param mixed         $mData              The data to be associated with this command
30 
+     * @param string         $mData              The data to be associated with this command
31 31 
      * @param boolean       $bRemoveEmpty       If true, remove empty attributes
32 32 
      *
33 33 
      * @return Response
 
@@ -81,7 +81,7 @@  discard block
 
 block discarded – undo
81 81 
      * @param string        $sURL                The relative or fully qualified URL
82 82 
      * @param integer        $iDelay                Number of seconds to delay before the redirect occurs
83 83 
      *
84 
-     * @return Response
84 
+     * @return JsCommands
85 85 
      */
86 86 
     public function redirect($sURL, $iDelay = 0)
87 87 
     {
Please login to merge, or discard this patch.
src/Response/Plugin/JQuery.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -35,7 +35,7 @@
 
 block discarded – undo
35 35 
      * The init code registers the "jquery" handler with the Jaxon javascript library,
36 36 
      * together with a function wich runs the javascript code generated by the plugin.
37 37 
      *
38 
-     * @return void
38 
+     * @return string
39 39 
      */
40 40 
     public function getScript()
41 41 
     {
Please login to merge, or discard this patch.
src/start.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -19,7 +19,7 @@  discard block
 
 block discarded – undo
19 19 
 /**
20 20 
  * Return the singleton instance of the Jaxon/Jaxon class
21 21 
  *
22 
- * @return Jaxon\Jaxon
22 
+ * @return Jaxon
23 23 
  */
24 24 
 function jaxon()
25 25 
 {
 
@@ -43,7 +43,7 @@  discard block
 
 block discarded – undo
43 43 
 /**
44 44 
  * Register a plugin
45 45 
  *
46 
- * @param Plugin         $xPlugin               An instance of a plugin
46 
+ * @param Jaxon\Plugin\Plugin         $xPlugin               An instance of a plugin
47 47 
  * @param integer        $nPriority             The plugin priority, used to order the plugins
48 48 
  *
49 49 
  * @return void
 
@@ -56,6 +56,7 @@  discard block
 
 block discarded – undo
56 56 
 /**
57 57 
  * Get the single instance of the request factory, and set the class to call.
58 58 
  *
59 
+ * @param string $sClassName
59 60 
  * @return Jaxon\Request\Factory\RequestFactory
60 61 
  */
61 62 
 function rq($sClassName = null)
Please login to merge, or discard this patch.
src/Utils/View/Store.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -17,7 +17,7 @@
 
 block discarded – undo
17 17 
      * @param string        $name            The data name
18 18 
      * @param string        $value           The data value
19 19 
      *
20 
-     * @return void
20 
+     * @return Store
21 21 
      */
22 22 
     public function with($name, $value)
23 23 
     {
Please login to merge, or discard this patch.
src/Request/Handler/Callback.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
      *
55 55 
      * @param callable|null  $xCallable               The callback function
56 56 
      *
57 
-     * @return void
57 
+     * @return callable|null
58 58 
      */
59 59 
     public function before($xCallable = null)
60 60 
     {
 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70 
      *
71 71 
      * @param callable|null  $xCallable               The callback function
72 72 
      *
73 
-     * @return void
73 
+     * @return callable|null
74 74 
      */
75 75 
     public function after($xCallable = null)
76 76 
     {
 
@@ -86,7 +86,7 @@  discard block
 
 block discarded – undo
86 86 
      *
87 87 
      * @param callable|null  $xCallable               The callback function
88 88 
      *
89 
-     * @return void
89 
+     * @return callable|null
90 90 
      */
91 91 
     public function invalid($xCallable = null)
92 92 
     {
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
      *
103 103 
      * @param callable|null  $xCallable               The callback function
104 104 
      *
105 
-     * @return void
105 
+     * @return callable|null
106 106 
      */
107 107 
     public function error($xCallable = null)
108 108 
     {
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118 
      *
119 119 
      * @param callable|null  $xCallable               The callback function
120 120 
      *
121 
-     * @return void
121 
+     * @return callable|null
122 122 
      */
123 123 
     public function init($xCallable = null)
124 124 
     {
Please login to merge, or discard this patch.