Jaxon\Request\Js\Call

Complexity

Total Complexity

39

Size/Duplication

Total Lines	477
Duplicated Lines	0 %

Importance

Changes

0

30 Methods

Rating	Name	Duplication	Size	Complexity
A	clearParameters()	0	4	1
A	setDialogManager()	0	3	1
A	ifgt()	0	4	1
A	pushParameter()	0	4	1
A	toInt()	0	4	1
A	elseWarning()	0	4	1
A	ifnte()	0	4	1
A	iflt()	0	4	1
A	elseError()	0	4	1
A	elseInfo()	0	4	1
A	__construct()	0	3	1
A	elseShow()	0	4	1
A	ifle()	0	4	1
A	unless()	0	3	1
A	ifge()	0	4	1
A	elseSuccess()	0	4	1
A	ifteq()	0	4	1
A	when()	0	3	1
A	addParameter()	0	4	1
A	hasPageNumber()	0	3	1
A	ifne()	0	4	1
A	toArray()	0	33	5
A	ifeq()	0	4	1
A	__toString()	0	7	2
A	findPageNumber()	0	10	3
A	confirm()	0	4	1
A	addParameters()	0	7	2
A	setPageNumber()	0	9	2
A	getArgs()	0	4	1
A	jsonSerialize()	0	3	1

<?php

/**
 * Call.php - The Jaxon Call
 *
 * This class is used to create js ajax requests to callable classes and functions.
 *
 * @package jaxon-core

Package name "jaxon-core" is not valid; consider "Jaxoncore" instead

 * @author Jared White

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author J. Max Wilson

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author Joseph Woolley

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author Steffen Konerow

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @author Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @copyright Copyright (c) 2005-2007 by Jared White & J. Max Wilson

@copyright tag must contain a year and the name of the copyright holder

 * @copyright Copyright (c) 2008-2010 by Joseph Woolley, Steffen Konerow, Jared White  & J. Max Wilson

@copyright tag must contain a year and the name of the copyright holder

 * @copyright 2016 Thierry Feuzeu <thierry.feuzeu@gmail.com>
 * @license https://opensource.org/licenses/BSD-3-Clause BSD 3-Clause License
 * @link https://github.com/jaxon-php/jaxon-core
 */

PHP version not specified

Missing @category tag in file comment

namespace Jaxon\Request\Js;

use Jaxon\App\Dialog\DialogManager;
use JsonSerializable;
use Stringable;

use function array_map;
use function array_shift;
use function func_get_args;

class Call

Missing doc comment for class Call

{
    /**
     * @var DialogManager
     */
    protected $xDialogManager;

Expected 1 blank line(s) before first member var; 0 found

    /**
     * The name of the javascript function
     *
     * @var string
     */
    private $sFunction;

    /**
     * @var array<ParameterInterface>
     */
    protected $aParameters = [];

    /**
     * Convert the parameter value to integer
     *
     * @var bool

Expected "boolean" but found "bool" for @var tag in member variable comment

     */
    protected $bToInt = false;

    /**
     * The arguments of the else() calls
     *
     * @var array
     */
    protected $aMessage = [];

    /**
     * A condition to check before making the call
     *
     * @var array
     */
    protected $aCondition = [];

    /**
     * The arguments of the confirm() call
     *
     * @var array
     */
    protected $aConfirm = [];

    /**
     * The constructor.
     *
     * @param string $sFunction    The javascript function

Expected 1 spaces after parameter name; 4 found

     */
    public function __construct(string $sFunction)

Expected 2 blank lines before function; 1 found

    {
        $this->sFunction = $sFunction;
    }

Expected 2 blank lines after function; 1 found

    /**
     * @return Call
     */
    public function toInt(): Call
    {
        $this->bToInt = true;
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Clear the parameter list associated with this request
     *
     * @return Call
     */
    public function clearParameters(): Call
    {
        $this->aParameters = [];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Set the value of the parameter at the given position
     *
     * @param ParameterInterface $xParameter    The value to be used

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function pushParameter(ParameterInterface $xParameter): Call
    {
        $this->aParameters[] = $xParameter;
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a parameter value to the parameter list for this request
     *
     * @param string $sType    The type of the value to be used

Expected 2 spaces after parameter name; 4 found

     * @param string $sValue    The value to be used

Expected 1 spaces after parameter name; 4 found

     *
     * Types should be one of the following <Parameter::FORM_VALUES>, <Parameter::QUOTED_VALUE>, <Parameter::NUMERIC_VALUE>,

Parameter comment not aligned correctly; expected 26 spaces but found 1

     * <Parameter::JS_VALUE>, <Parameter::INPUT_VALUE>, <Parameter::CHECKED_VALUE>, <Parameter::PAGE_NUMBER>.

Parameter comment not aligned correctly; expected 26 spaces but found 1

     * The value should be as follows:

Parameter comment not aligned correctly; expected 26 spaces but found 1

     * - <Parameter::FORM_VALUES> - Use the ID of the form you want to process.

Parameter comment not aligned correctly; expected 26 spaces but found 1

     * - <Parameter::QUOTED_VALUE> - The string data to be passed.

Parameter comment not aligned correctly; expected 26 spaces but found 1

     * - <Parameter::JS_VALUE> - A string containing valid javascript

Parameter comment not aligned correctly; expected 26 spaces but found 1

     *   (either a javascript variable name that will be in scope at the time of the call or

Parameter comment not aligned correctly; expected 26 spaces but found 3

     *   a javascript function call whose return value will become the parameter).

Parameter comment not aligned correctly; expected 26 spaces but found 3

     *
     * @return Call
     */
    public function addParameter(string $sType, string $sValue): Call
    {
        $this->pushParameter(new Parameter($sType, $sValue));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a set of parameters to this request
     *
     * @param array $aParameters    The parameters

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function addParameters(array $aParameters): Call
    {
        foreach($aParameters as $xParameter)
        {
            $this->pushParameter(Parameter::make($xParameter));
        }
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * @param array $aArgs

Missing parameter comment

     *
     * @return array
     */
    private function getArgs(array $aArgs): array
    {
        array_shift($aArgs);
        return $aArgs;
    }

Expected 2 blank lines after function; 1 found

    /**
     * @param DialogManager $xDialogManager

Missing parameter comment

     *
     * @return void
     */
    public function setDialogManager(DialogManager $xDialogManager)
    {
        $this->xDialogManager = $xDialogManager;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Show a message if the condition to the call is not met
     *
     * @param string $sMessage  The message to show

Expected 1 spaces after parameter name; 2 found

     *
     * @return Call
     */
    public function elseShow(string $sMessage): Call
    {
        $this->aMessage = $this->xDialogManager->warning($sMessage, $this->getArgs(func_get_args()));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Show an information message if the condition to the call is not met
     *
     * @param string $sMessage  The message to show

Expected 1 spaces after parameter name; 2 found

     *
     * @return Call
     */
    public function elseInfo(string $sMessage): Call
    {
        $this->aMessage = $this->xDialogManager->info($sMessage, $this->getArgs(func_get_args()));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Show a success message if the condition to the call is not met
     *
     * @param string $sMessage  The message to show

Expected 1 spaces after parameter name; 2 found

     *
     * @return Call
     */
    public function elseSuccess(string $sMessage): Call
    {
        $this->aMessage = $this->xDialogManager->success($sMessage, $this->getArgs(func_get_args()));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Show a warning message if the condition to the call is not met
     *
     * @param string $sMessage  The message to show

Expected 1 spaces after parameter name; 2 found

     *
     * @return Call
     */
    public function elseWarning(string $sMessage): Call
    {
        $this->aMessage = $this->xDialogManager->warning($sMessage, $this->getArgs(func_get_args()));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Show an error message if the condition to the call is not met
     *
     * @param string $sMessage  The message to show

Expected 1 spaces after parameter name; 2 found

     *
     * @return Call
     */
    public function elseError(string $sMessage): Call
    {
        $this->aMessage = $this->xDialogManager->error($sMessage, $this->getArgs(func_get_args()));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a confirmation question to the request
     *
     * @param string $sQuestion    The question to ask

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function confirm(string $sQuestion): Call
    {
        $this->aConfirm = $this->xDialogManager->confirm($sQuestion, $this->getArgs(func_get_args()));
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is equal to another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifeq($xValue1, $xValue2): Call
    {
        $this->aCondition = ['eq', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is equal to another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifteq($xValue1, $xValue2): Call
    {
        $this->aCondition = ['teq', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is not equal to another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifne($xValue1, $xValue2): Call
    {
        $this->aCondition = ['ne', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is not equal to another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifnte($xValue1, $xValue2): Call
    {
        $this->aCondition = ['nte', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is greater than another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifgt($xValue1, $xValue2): Call
    {
        $this->aCondition = ['gt', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is greater or equal to another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifge($xValue1, $xValue2): Call
    {
        $this->aCondition = ['ge', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is lower than another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function iflt($xValue1, $xValue2): Call
    {
        $this->aCondition = ['lt', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if a value is lower or equal to another before sending the request
     *
     * @param mixed $xValue1    The first value to compare

Expected 1 spaces after parameter name; 4 found

     * @param mixed $xValue2    The second value to compare

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function ifle($xValue1, $xValue2): Call
    {
        $this->aCondition = ['le', Parameter::make($xValue1), Parameter::make($xValue2)];
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a condition to the request
     *
     * The request is sent only if the condition is true.
     *
     * @param mixed $xCondition    The condition to check

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function when($xCondition): Call
    {
        return $this->ifeq(true, $xCondition);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Add a condition to the request
     *
     * The request is sent only if the condition is false.
     *
     * @param mixed $xCondition    The condition to check

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function unless($xCondition): Call
    {
        return $this->ifeq(false, $xCondition);
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if the request has a parameter of type Parameter::PAGE_NUMBER
     *
     * @return ParameterInterface|null
     */
    private function findPageNumber(): ?ParameterInterface
    {
        foreach($this->aParameters as $xParameter)
        {
            if($xParameter->getType() === Parameter::PAGE_NUMBER)
            {
                return $xParameter;
            }
        }
        return null;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Check if the request has a parameter of type Parameter::PAGE_NUMBER
     *
     * @return bool
     */
    public function hasPageNumber(): bool
    {
        return $this->findPageNumber() !== null;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Set a value to the Parameter::PAGE_NUMBER parameter
     *
     * @param integer $nPageNumber    The current page number

Expected 1 spaces after parameter name; 4 found

     *
     * @return Call
     */
    public function setPageNumber(int $nPageNumber): Call
    {
        /** @var Parameter */

Block comments must be started with /*

        $xParameter = $this->findPageNumber();
        if($xParameter !== null)
        {
            $xParameter->setValue($nPageNumber);

The method setValue() does not exist on Jaxon\Request\Js\ParameterInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Jaxon\Request\Js\ParameterInterface.

        }
        return $this;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Convert this call to array
     *
     * @return array
     */
    public function toArray(): array
    {
        $aCalls = [[
            '_type' => 'func',
            '_name' => $this->sFunction,
            'args' => array_map(function(JsonSerializable $xParam) {
                return $xParam->jsonSerialize();
            }, $this->aParameters),
        ]];

Closing brace of array declaration must be on a new line

        if($this->bToInt)
        {
            $aCalls[] = [
                '_type' => 'func',
                '_name' => 'toInt',
                'args' => [[ '_type' => '_', '_name' => 'this' ]],
            ];
        }

        $aCall = ['_type' => 'expr', 'calls' => $aCalls];
        if(($this->aConfirm))

The expression $this->aConfirm of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
            $aCall['question'] = $this->aConfirm;
        }
        if(($this->aCondition))

The expression $this->aCondition of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
            $aCall['condition'] = $this->aCondition;
        }
        if(($this->aMessage))

The expression $this->aMessage of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
            $aCall['message'] = $this->aMessage;
        }

        return $aCall;
    }

Expected 2 blank lines after function; 1 found

    /**
     * Convert this call to array, when converting the response into json.
     *
     * This is a method of the JsonSerializable interface.
     *
     * @return array
     */
    public function jsonSerialize(): array
    {
        return $this->toArray();
    }

Expected 2 blank lines after function; 1 found

    /**
     * Returns a string representation of the script output (javascript) from this request object
     *
     * @return string
     */
    public function __toString()
    {
        $aParameters = array_map(function(Stringable $xParam) {
            return $xParam->__toString();
        }, $this->aParameters);
        $sScript = $this->sFunction . '(' . implode(', ', $aParameters) . ')';

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        return $this->bToInt ? "parseInt($sScript)" : $sScript;
    }

Expected 2 blank lines after function; 0 found

}