Passed
Push — main ( 01ee0f...5fbd1e )
by Thierry
02:22
created
src/Plugin/Code/CodeGenerator.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public function addCodeGenerator(string $sClassName, int $nPriority)
117 117
     {
118
-        while(isset($this->aCodeGenerators[$nPriority]))
118
+        while (isset($this->aCodeGenerators[$nPriority]))
119 119
         {
120 120
             $nPriority++;
121 121
         }
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
     private function generatePluginCodes(string $sClassName)
159 159
     {
160 160
         $xGenerator = $this->di->g($sClassName);
161
-        if(!is_subclass_of($xGenerator, Plugin::class) || $this->xAssetManager->shallIncludeAssets($xGenerator))
161
+        if (!is_subclass_of($xGenerator, Plugin::class) || $this->xAssetManager->shallIncludeAssets($xGenerator))
162 162
         {
163 163
             // HTML tags for CSS
164 164
             $this->sCss = trim($this->sCss) . "\n" . trim($xGenerator->getCss(), " \n");
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         }
168 168
         // Javascript code
169 169
         $this->sJsScript = trim($this->sJsScript) . "\n\n" . trim($xGenerator->getScript(), " \n");
170
-        if($xGenerator->readyEnabled())
170
+        if ($xGenerator->readyEnabled())
171 171
         {
172 172
             $sScriptAttr = $xGenerator->readyInlined() ? 'sJsInlineScript' : 'sJsReadyScript';
173 173
             $this->$sScriptAttr = trim($this->$sScriptAttr) . "\n\n" . trim($xGenerator->getReadyScript(), " \n");
@@ -186,11 +186,11 @@  discard block
 block discarded – undo
186 186
         $this->sJsScript = trim($this->sJsScript, " \n");
187 187
         $this->sJsReadyScript = trim($this->sJsReadyScript, " \n");
188 188
         $this->sJsInlineScript = trim($this->sJsInlineScript, " \n");
189
-        if(($this->sJsReadyScript))
189
+        if (($this->sJsReadyScript))
190 190
         {
191 191
             $this->sJsReadyScript = $this->render('ready.js', ['sScript' => $this->sJsReadyScript . "\n"]);
192 192
         }
193
-        if(($this->sJsInlineScript))
193
+        if (($this->sJsInlineScript))
194 194
         {
195 195
             $this->sJsInlineScript = $this->render('ready.js', ['sScript' => $this->sJsInlineScript . "\n"]);
196 196
         }
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
      */
208 208
     private function generateCodes()
209 209
     {
210
-        if($this->bGenerated)
210
+        if ($this->bGenerated)
211 211
         {
212 212
             return;
213 213
         }
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 
218 218
         $this->xAssetManager = $this->di->getAssetManager();
219 219
         $this->sJsOptions = $this->xAssetManager->getJsOptions();
220
-        foreach($this->aCodeGenerators as $sClassName)
220
+        foreach ($this->aCodeGenerators as $sClassName)
221 221
         {
222 222
             $this->generatePluginCodes($sClassName);
223 223
         }
@@ -279,16 +279,16 @@  discard block
 block discarded – undo
279 279
     {
280 280
         $this->generateCodes();
281 281
         $sScript = '';
282
-        if(($bIncludeCss))
282
+        if (($bIncludeCss))
283 283
         {
284 284
             $sScript .= $this->getCss() . "\n";
285 285
         }
286
-        if(($bIncludeJs))
286
+        if (($bIncludeJs))
287 287
         {
288 288
             $sScript .= $this->getJs() . "\n";
289 289
         }
290 290
 
291
-        if(!($sUrl = $this->xAssetManager->createJsFiles($this)))
291
+        if (!($sUrl = $this->xAssetManager->createJsFiles($this)))
292 292
         {
293 293
             return trim($sScript) . "\n\n" . $this->render('wrapper.js',
294 294
                 ['sScript' => trim($this->sJsScript) . "\n\n" . trim($this->sJsInlineScript)]);
Please login to merge, or discard this patch.
src/Plugin/Manager/PluginManager.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -123,28 +123,28 @@  discard block
 block discarded – undo
123 123
     {
124 124
         $bIsUsed = false;
125 125
         $aInterfaces = class_implements($sClassName);
126
-        if(in_array(CodeGeneratorInterface::class, $aInterfaces))
126
+        if (in_array(CodeGeneratorInterface::class, $aInterfaces))
127 127
         {
128 128
             $this->xCodeGenerator->addCodeGenerator($sClassName, $nPriority);
129 129
             $bIsUsed = true;
130 130
         }
131
-        if(in_array(CallableRegistryInterface::class, $aInterfaces))
131
+        if (in_array(CallableRegistryInterface::class, $aInterfaces))
132 132
         {
133 133
             $this->aRegistryPlugins[$sPluginName] = $sClassName;
134 134
             $bIsUsed = true;
135 135
         }
136
-        if(in_array(RequestHandlerInterface::class, $aInterfaces))
136
+        if (in_array(RequestHandlerInterface::class, $aInterfaces))
137 137
         {
138 138
             $this->aRequestHandlers[$sPluginName] = $sClassName;
139 139
             $bIsUsed = true;
140 140
         }
141
-        if(in_array(ResponsePluginInterface::class, $aInterfaces))
141
+        if (in_array(ResponsePluginInterface::class, $aInterfaces))
142 142
         {
143 143
             $this->aResponsePlugins[$sPluginName] = $sClassName;
144 144
             $bIsUsed = true;
145 145
         }
146 146
 
147
-        if(!$bIsUsed)
147
+        if (!$bIsUsed)
148 148
         {
149 149
             // The class is invalid.
150 150
             $sMessage = $this->xTranslator->trans('errors.register.invalid', ['name' => $sClassName]);
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         }
153 153
 
154 154
         // Register the plugin in the DI container, if necessary
155
-        if(!$this->di->has($sClassName))
155
+        if (!$this->di->has($sClassName))
156 156
         {
157 157
             $this->di->auto($sClassName);
158 158
         }
@@ -168,12 +168,12 @@  discard block
 block discarded – undo
168 168
      */
169 169
     public function getResponsePlugin(string $sName, ?Response $xResponse = null): ?ResponsePlugin
170 170
     {
171
-        if(!isset($this->aResponsePlugins[$sName]))
171
+        if (!isset($this->aResponsePlugins[$sName]))
172 172
         {
173 173
             return null;
174 174
         }
175 175
         $xPlugin = $this->di->g($this->aResponsePlugins[$sName]);
176
-        if(($xResponse))
176
+        if (($xResponse))
177 177
         {
178 178
             $xPlugin->setResponse($xResponse);
179 179
         }
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
      */
195 195
     public function registerCallable(string $sType, string $sCallable, $xOptions = [])
196 196
     {
197
-        if(isset($this->aRegistryPlugins[$sType]) &&
197
+        if (isset($this->aRegistryPlugins[$sType]) &&
198 198
             ($xPlugin = $this->di->g($this->aRegistryPlugins[$sType])))
199 199
         {
200 200
             $xPlugin->register($sType, $sCallable, $xPlugin->checkOptions($sCallable, $xOptions));
Please login to merge, or discard this patch.
src/Response/Response.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function getOutput(): string
88 88
     {
89
-        if($this->getCommandCount() === 0)
89
+        if ($this->getCommandCount() === 0)
90 90
         {
91 91
             return '';
92 92
         }
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function bag(string $sName): DataBagContext
147 147
     {
148
-        return $this->plugin('bags')->bag($sName);;
148
+        return $this->plugin('bags')->bag($sName); ;
149 149
     }
150 150
 
151 151
     /**
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     public function addCommand(array $aAttributes, $mData): Response
160 160
     {
161 161
         $aAttributes = array_map(function($xAttribute) {
162
-            return is_integer($xAttribute) ? $xAttribute : trim((string)$xAttribute, " \t");
162
+            return is_integer($xAttribute) ? $xAttribute : trim((string) $xAttribute, " \t");
163 163
         }, $aAttributes);
164 164
         $aAttributes['data'] = $mData;
165 165
         $this->aCommands[] = $aAttributes;
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
     protected function _addCommand(string $sName, array $aAttributes, $mData, bool $bRemoveEmpty = false): Response
180 180
     {
181 181
         $mData = is_array($mData) ? array_map(function($sData) {
182
-            return trim((string)$sData, " \t\n");
183
-        }, $mData) : trim((string)$mData, " \t\n");
184
-        if($bRemoveEmpty)
182
+            return trim((string) $sData, " \t\n");
183
+        }, $mData) : trim((string) $mData, " \t\n");
184
+        if ($bRemoveEmpty)
185 185
         {
186 186
             $aAttributes = array_filter($aAttributes, function($xValue) {
187 187
                 return $xValue === '';
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
     public function toPsr(): PsrResponseInterface
215 215
     {
216 216
         $xPsrResponse = $this->xPsr17Factory->createResponse(200);
217
-        if($this->xRequest->getMethod() === 'GET')
217
+        if ($this->xRequest->getMethod() === 'GET')
218 218
         {
219 219
             $xPsrResponse = $xPsrResponse
220 220
                 ->withHeader('Expires', 'Mon, 26 Jul 1997 05:00:00 GMT')
Please login to merge, or discard this patch.
src/Response/Manager/ResponseManager.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      */
80 80
     public function clear()
81 81
     {
82
-        if($this->xResponse !== null)
82
+        if ($this->xResponse !== null)
83 83
         {
84 84
             $this->xResponse->clearCommands();
85 85
         }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
      */
94 94
     public function getResponse(): ResponseInterface
95 95
     {
96
-        if(!$this->xResponse)
96
+        if (!$this->xResponse)
97 97
         {
98 98
             $this->xResponse = $this->di->getResponse();
99 99
         }
@@ -114,21 +114,21 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function append(ResponseInterface $xResponse)
116 116
     {
117
-        if(!$this->xResponse)
117
+        if (!$this->xResponse)
118 118
         {
119 119
             $this->xResponse = $this->di->getResponse();
120 120
         }
121
-        if($this->xResponse->getCommandCount() === 0)
121
+        if ($this->xResponse->getCommandCount() === 0)
122 122
         {
123 123
             $this->xResponse = $xResponse;
124 124
             return;
125 125
         }
126
-        if(get_class($this->xResponse) !== get_class($xResponse))
126
+        if (get_class($this->xResponse) !== get_class($xResponse))
127 127
         {
128 128
             throw new RequestException($this->xTranslator->trans('errors.mismatch.types',
129 129
                 ['class' => get_class($xResponse)]));
130 130
         }
131
-        if($this->xResponse !== $xResponse)
131
+        if ($this->xResponse !== $xResponse)
132 132
         {
133 133
             $this->xResponse->appendResponse($xResponse);
134 134
         }
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
      */
170 170
     public function printDebug()
171 171
     {
172
-        foreach($this->aDebugMessages as $sMessage)
172
+        foreach ($this->aDebugMessages as $sMessage)
173 173
         {
174 174
             $this->getResponse()->debug($sMessage);
175 175
         }
@@ -183,8 +183,7 @@  discard block
 block discarded – undo
183 183
      */
184 184
     public function getContentType(): string
185 185
     {
186
-        return empty($this->sCharacterEncoding) ? $this->getResponse()->getContentType() :
187
-            $this->getResponse()->getContentType() . '; charset="' . $this->sCharacterEncoding . '"';
186
+        return empty($this->sCharacterEncoding) ? $this->getResponse()->getContentType() : $this->getResponse()->getContentType() . '; charset="' . $this->sCharacterEncoding . '"';
188 187
     }
189 188
 
190 189
     /**
Please login to merge, or discard this patch.
src/Response/Traits/JsTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
     public function redirect(string $sURL, int $nDelay = 0): Response
95 95
     {
96 96
         $sURL = $this->xPluginManager->getParameterReader()->parseUrl($sURL);
97
-        if($nDelay <= 0)
97
+        if ($nDelay <= 0)
98 98
         {
99 99
             return $this->script("window.location = '$sURL';");
100 100
         }
Please login to merge, or discard this patch.
src/Plugin/Code/AssetManager.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     public function shallIncludeAssets(Plugin $xPlugin): bool
72 72
     {
73 73
         $sPluginOptionName = 'assets.include.' . $xPlugin->getName();
74
-        if($this->xConfigManager->hasOption($sPluginOptionName))
74
+        if ($this->xConfigManager->hasOption($sPluginOptionName))
75 75
         {
76 76
             return $this->xConfigManager->getOption($sPluginOptionName);
77 77
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $sJsLibUri = rtrim($this->xConfigManager->getOption('js.lib.uri', self::JS_LIB_URL), '/') . '/';
91 91
         // Add component files to the javascript file array;
92 92
         $aJsFiles = [$sJsLibUri . 'jaxon.core' . $sJsExtension];
93
-        if($this->xConfigManager->getOption('core.debug.on'))
93
+        if ($this->xConfigManager->getOption('core.debug.on'))
94 94
         {
95 95
             $sLanguage = $this->xConfigManager->getOption('core.language');
96 96
             $aJsFiles[] = $sJsLibUri . 'jaxon.debug' . $sJsExtension;
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
      */
108 108
     public function getOptionVars(): array
109 109
     {
110
-        if(!$this->xConfigManager->hasOption('core.request.uri'))
110
+        if (!$this->xConfigManager->hasOption('core.request.uri'))
111 111
         {
112 112
             $this->xConfigManager->setOption('core.request.uri', $this->xParameterReader->uri());
113 113
         }
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
         // Check config options
141 141
         // - The js.app.export option must be set to true
142 142
         // - The js.app.uri and js.app.dir options must be set to non null values
143
-        if(!$this->xConfigManager->getOption('js.app.export', false) ||
143
+        if (!$this->xConfigManager->getOption('js.app.export', false) ||
144 144
             !$this->xConfigManager->getOption('js.app.uri') ||
145 145
             !$this->xConfigManager->getOption('js.app.dir'))
146 146
         {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
      */
159 159
     public function createJsFiles(CodeGenerator $xCodeGenerator): string
160 160
     {
161
-        if(!$this->shallCreateJsFiles())
161
+        if (!$this->shallCreateJsFiles())
162 162
         {
163 163
             return '';
164 164
         }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         $sJsFileName = $this->xConfigManager->getOption('js.app.file') ?: $xCodeGenerator->getHash();
168 168
         $sJsDirectory = rtrim($this->xConfigManager->getOption('js.app.dir'), '\/') . DIRECTORY_SEPARATOR;
169 169
         // - The js.app.dir must be writable
170
-        if(!$sJsFileName || !is_dir($sJsDirectory) || !is_writable($sJsDirectory))
170
+        if (!$sJsFileName || !is_dir($sJsDirectory) || !is_writable($sJsDirectory))
171 171
         {
172 172
             return '';
173 173
         }
@@ -175,15 +175,15 @@  discard block
 block discarded – undo
175 175
         $sJsFilePath = $sJsDirectory . $sJsFileName . '.js';
176 176
         $sJsMinFilePath = $sJsDirectory . $sJsFileName . '.min.js';
177 177
         $sJsFileUri = rtrim($this->xConfigManager->getOption('js.app.uri'), '/') . "/$sJsFileName";
178
-        if(!is_file($sJsFilePath) && !@file_put_contents($sJsFilePath, $xCodeGenerator->getJsScript()))
178
+        if (!is_file($sJsFilePath) && !@file_put_contents($sJsFilePath, $xCodeGenerator->getJsScript()))
179 179
         {
180 180
             return '';
181 181
         }
182
-        if(!$this->xConfigManager->getOption('js.app.minify', false))
182
+        if (!$this->xConfigManager->getOption('js.app.minify', false))
183 183
         {
184 184
             return $sJsFileUri . '.js';
185 185
         }
186
-        if(!is_file($sJsMinFilePath) && !$this->xMinifier->minify($sJsFilePath, $sJsMinFilePath))
186
+        if (!is_file($sJsMinFilePath) && !$this->xMinifier->minify($sJsFilePath, $sJsMinFilePath))
187 187
         {
188 188
             // If the file cannot be minified, return the plain js file.
189 189
             return $sJsFileUri . '.js';
Please login to merge, or discard this patch.
src/Plugin/Response/JQuery/JQueryPlugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     public function selector(string $sPath = '', $xContext = null): DomSelector
88 88
     {
89 89
         $xSelector = new DomSelector($this->jQueryNs, $sPath, $xContext);
90
-        if($this->bCommand && $this->response() !== null)
90
+        if ($this->bCommand && $this->response() !== null)
91 91
         {
92 92
             $this->addCommand(['cmd' => 'jquery'], $xSelector);
93 93
         }
Please login to merge, or discard this patch.
src/Plugin/Response/JQuery/DomSelector.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,12 +77,12 @@  discard block
 block discarded – undo
77 77
      */
78 78
     private function getPath(string $jQueryNs, string $sPath, $xContext)
79 79
     {
80
-        if(!$sPath)
80
+        if (!$sPath)
81 81
         {
82 82
             // If an empty selector is given, use javascript "this" instead
83 83
             return "$jQueryNs(this)";
84 84
         }
85
-        if(!$xContext)
85
+        if (!$xContext)
86 86
         {
87 87
             return "$jQueryNs('" . $sPath . "')";
88 88
         }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     public function getScript(): string
156 156
     {
157 157
         $sScript = $this->sPath;
158
-        if(count($this->aCalls) > 0)
158
+        if (count($this->aCalls) > 0)
159 159
         {
160 160
             $sScript .= '.' . implode('.', $this->aCalls);
161 161
         }
Please login to merge, or discard this patch.
src/App/Dialog/Library/DialogLibraryHelper.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -136,18 +136,18 @@  discard block
 block discarded – undo
136 136
         $aOptions = $this->getOptionNames($sKeyPrefix);
137 137
         $sSpaces = str_repeat(' ', $nSpaces);
138 138
         $sScript = '';
139
-        foreach($aOptions as $sShortName => $sFullName)
139
+        foreach ($aOptions as $sShortName => $sFullName)
140 140
         {
141 141
             $value = $this->xConfigManager->getOption($sFullName);
142
-            if(is_string($value))
142
+            if (is_string($value))
143 143
             {
144 144
                 $value = "'$value'";
145 145
             }
146
-            elseif(is_bool($value))
146
+            elseif (is_bool($value))
147 147
             {
148 148
                 $value = ($value ? 'true' : 'false');
149 149
             }
150
-            elseif(!is_numeric($value))
150
+            elseif (!is_numeric($value))
151 151
             {
152 152
                 $value = json_encode($value);
153 153
             }
@@ -175,10 +175,10 @@  discard block
 block discarded – undo
175 175
      */
176 176
     public function getJsCode(string $sFile): string
177 177
     {
178
-        if($this->hasOption('assets.js'))
178
+        if ($this->hasOption('assets.js'))
179 179
         {
180 180
             // If this expression evaluates to false, then the asset is not displayed.
181
-            if(!($sUri = $this->getOption('assets.js')))
181
+            if (!($sUri = $this->getOption('assets.js')))
182 182
             {
183 183
                 return '';
184 184
             }
@@ -200,10 +200,10 @@  discard block
 block discarded – undo
200 200
      */
201 201
     public function getCssCode(string $sFile): string
202 202
     {
203
-        if($this->hasOption('assets.css'))
203
+        if ($this->hasOption('assets.css'))
204 204
         {
205 205
             // If this expression evaluates to false, then the asset is not displayed.
206
-            if(!($sUri = $this->getOption('assets.css')))
206
+            if (!($sUri = $this->getOption('assets.css')))
207 207
             {
208 208
                 return '';
209 209
             }
Please login to merge, or discard this patch.
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -142,12 +142,10 @@  discard block
 block discarded – undo
142 142
             if(is_string($value))
143 143
             {
144 144
                 $value = "'$value'";
145
-            }
146
-            elseif(is_bool($value))
145
+            } elseif(is_bool($value))
147 146
             {
148 147
                 $value = ($value ? 'true' : 'false');
149
-            }
150
-            elseif(!is_numeric($value))
148
+            } elseif(!is_numeric($value))
151 149
             {
152 150
                 $value = json_encode($value);
153 151
             }
@@ -182,8 +180,7 @@  discard block
 block discarded – undo
182 180
             {
183 181
                 return '';
184 182
             }
185
-        }
186
-        else
183
+        } else
187 184
         {
188 185
             $sUri = $this->sUri . '/' . ($this->sSubDir ? $this->sSubDir . '/' : '') .
189 186
                 ($this->sVersion ? $this->sVersion . '/' : '') . $sFile;
@@ -207,8 +204,7 @@  discard block
 block discarded – undo
207 204
             {
208 205
                 return '';
209 206
             }
210
-        }
211
-        else
207
+        } else
212 208
         {
213 209
             $sUri = $this->sUri . '/' . ($this->sSubDir ? $this->sSubDir . '/' : '') .
214 210
                 ($this->sVersion ? $this->sVersion . '/' : '') . $sFile;
Please login to merge, or discard this patch.