Conditions | 2 |
Total Lines | 133 |
Code Lines | 126 |
Lines | 0 |
Ratio | 0 % |
Changes | 4 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package com.osomapps.pt.programs; |
||
28 | List<ProgramResponseDTO> getPredefinedPrograms(String token) { |
||
29 | if (token.isEmpty()) { |
||
30 | return Collections.emptyList(); |
||
31 | } |
||
32 | userService.checkUserToken(token); |
||
33 | InProgram inProgram1 = new InProgram(); |
||
34 | inProgram1.setId(1L); |
||
35 | inProgram1.setName("Test program 1"); |
||
36 | inProgram1.setD_program_type("test"); |
||
37 | InWorkout inWorkout11 = new InWorkout(); |
||
38 | inWorkout11.setId(1L); |
||
39 | inWorkout11.setD_workout_name("Test workout 1"); |
||
40 | InWorkout inWorkout12 = new InWorkout(); |
||
41 | inWorkout12.setId(2L); |
||
42 | inWorkout12.setD_workout_name("Test workout 2"); |
||
43 | inProgram1.setInWorkouts(Arrays.asList(inWorkout11, inWorkout12)); |
||
44 | InWarmupWorkoutItem inWarmupWorkoutItem111 = new InWarmupWorkoutItem(); |
||
45 | inWarmupWorkoutItem111.setId(0L); |
||
46 | inWarmupWorkoutItem111.setExercise_id(800); |
||
47 | inWarmupWorkoutItem111.setD_exercise_name("Treadmill"); |
||
48 | inWarmupWorkoutItem111.setSpeed(10); |
||
49 | inWarmupWorkoutItem111.setIncline(2); |
||
50 | inWarmupWorkoutItem111.setTime_in_sec(600); |
||
51 | inWorkout11.setInWarmupWorkoutItems(Arrays.asList(inWarmupWorkoutItem111)); |
||
52 | InWorkoutItem inWorkoutItem111 = new InWorkoutItem(); |
||
53 | inWorkoutItem111.setId(1L); |
||
54 | inWorkoutItem111.setExercise_id(210); |
||
55 | inWorkoutItem111.setD_exercise_name("Deadlift"); |
||
56 | InWorkoutItemSet inWorkoutItemSet111 = new InWorkoutItemSet(); |
||
57 | inWorkoutItemSet111.setRepetitions(10); |
||
58 | inWorkoutItemSet111.setWeight(75F); |
||
59 | inWorkoutItem111.setInWorkoutItemSets(Arrays.asList(inWorkoutItemSet111)); |
||
60 | InWorkoutItem inWorkoutItem112 = |
||
61 | new InWorkoutItem() |
||
62 | .setId(2L) |
||
63 | .setExercise_id(260) |
||
64 | .setD_exercise_name("Bench Press") |
||
65 | .setInWorkoutItemSets( |
||
66 | Arrays.asList( |
||
67 | new InWorkoutItemSet().setRepetitions(10).setWeight(65F), |
||
68 | new InWorkoutItemSet().setRepetitions(10).setWeight(65F), |
||
69 | new InWorkoutItemSet().setRepetitions(10).setWeight(65F))); |
||
70 | |||
71 | InWorkoutItem inWorkoutItem113 = |
||
72 | new InWorkoutItem() |
||
73 | .setId(3L) |
||
74 | .setExercise_id(150) |
||
75 | .setD_exercise_name("Pull Up") |
||
76 | .setInWorkoutItemSets( |
||
77 | Arrays.asList( |
||
78 | new InWorkoutItemSet() |
||
79 | .setRepetitions(10) |
||
80 | .setBodyweight(true) |
||
81 | .setWeight(65F), |
||
82 | new InWorkoutItemSet() |
||
83 | .setRepetitions(10) |
||
84 | .setBodyweight(true) |
||
85 | .setWeight(65F), |
||
86 | new InWorkoutItemSet() |
||
87 | .setRepetitions(10) |
||
88 | .setBodyweight(true) |
||
89 | .setWeight(65F), |
||
90 | new InWorkoutItemSet() |
||
91 | .setRepetitions(10) |
||
92 | .setBodyweight(true) |
||
93 | .setWeight(65F))); |
||
94 | |||
95 | InWorkoutItem inWorkoutItem114 = |
||
96 | new InWorkoutItem() |
||
97 | .setId(4L) |
||
98 | .setExercise_id(530) |
||
99 | .setD_exercise_name("Dips") |
||
100 | .setInWorkoutItemSets( |
||
101 | Arrays.asList( |
||
102 | new InWorkoutItemSet() |
||
103 | .setRepetitions(10) |
||
104 | .setBodyweight(true) |
||
105 | .setWeight(65F), |
||
106 | new InWorkoutItemSet() |
||
107 | .setRepetitions(10) |
||
108 | .setBodyweight(true) |
||
109 | .setWeight(65F), |
||
110 | new InWorkoutItemSet() |
||
111 | .setRepetitions(10) |
||
112 | .setBodyweight(true) |
||
113 | .setWeight(65F))); |
||
114 | |||
115 | InWorkoutItem inWorkoutItem115 = |
||
116 | new InWorkoutItem() |
||
117 | .setId(5L) |
||
118 | .setExercise_id(440) |
||
119 | .setD_exercise_name("Plank") |
||
120 | .setD_exercise_type("OnTime") |
||
121 | .setInWorkoutItemSets( |
||
122 | Arrays.asList( |
||
123 | new InWorkoutItemSet() |
||
124 | .setTime_in_sec(120) |
||
125 | .setBodyweight(true) |
||
126 | .setWeight(65F))); |
||
127 | |||
128 | InWorkoutItemSet inWorkoutItemSet1 = |
||
129 | new InWorkoutItemSet().setIncline(2).setSpeed(8).setTime_in_sec(4); |
||
130 | InWorkoutItemSet inWorkoutItemSet2 = |
||
131 | new InWorkoutItemSet().setIncline(3).setSpeed(9).setTime_in_sec(4); |
||
132 | InWorkoutItemSet inWorkoutItemSet3 = |
||
133 | new InWorkoutItemSet().setIncline(4).setSpeed(10).setTime_in_sec(4); |
||
134 | InWorkoutItemSet inWorkoutItemSet4 = |
||
135 | new InWorkoutItemSet().setIncline(3).setSpeed(9).setTime_in_sec(4); |
||
136 | InWorkoutItem inWorkoutItem116 = |
||
137 | new InWorkoutItem() |
||
138 | .setId(6L) |
||
139 | .setExercise_id(820) |
||
140 | .setD_exercise_name("Treadmill 4x4") |
||
141 | .setD_exercise_type("OnIntervals") |
||
142 | .setInWorkoutItemSets( |
||
143 | Arrays.asList( |
||
144 | inWorkoutItemSet1, |
||
145 | inWorkoutItemSet2, |
||
146 | inWorkoutItemSet3, |
||
147 | inWorkoutItemSet4)); |
||
148 | |||
149 | inWorkout11.setInWorkoutItems( |
||
150 | Arrays.asList( |
||
151 | inWorkoutItem111, |
||
152 | inWorkoutItem112, |
||
153 | inWorkoutItem113, |
||
154 | inWorkoutItem114, |
||
155 | inWorkoutItem115, |
||
156 | inWorkoutItem116)); |
||
157 | inProgram1.setInWorkouts(Arrays.asList(inWorkout11)); |
||
158 | |||
159 | ProgramResponseDTO program1 = createProgramResponseDTO(inProgram1); |
||
160 | return Arrays.asList(program1); |
||
161 | } |
||
303 |