jasny / http-signature

src/ServerMiddleware.php

<?php declare(strict_types=1);

namespace Jasny\HttpSignature;

use Psr\Http\Message\ServerRequestInterface as ServerRequest;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ResponseFactoryInterface as ResponseFactory;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface as RequestHandler;

/**
 * Middleware to verify HTTP Signature authentication.
 * Can be used both as single pass (PSR-15) and double pass middleware.
 */
class ServerMiddleware implements MiddlewareInterface
{
    /**
     * @var HttpSignature
     */
    protected $service;

    /**
     * @var ResponseFactory|null
     */
    protected $responseFactory;

    /**
     * Class constructor.
     *
     * @param HttpSignature        $service
     * @param ResponseFactory|null $responseFactory
     */
    public function __construct(HttpSignature $service, ?ResponseFactory $responseFactory = null)
    {
        $this->service = $service;
        $this->responseFactory = $responseFactory;
    }


    /**
     * Process an incoming server request (PSR-15).
     *
     * @param ServerRequest  $request
     * @param RequestHandler $handler
     * @return Response
     * @throws \RuntimeException if unauthorized response can't be created
     */
    public function process(ServerRequest $request, RequestHandler $handler): Response
    {
        if (!$this->isRequestSigned($request)) {
            return $handler->handle($request);
        }

        $next = function (ServerRequest $request) use ($handler) {

Anonymous function should have native return typehint "Psr\Http\Message\ResponseInterface".

            return $handler->handle($request);
        };

        return $this->handleSignedRequest($request, null, $next);
    }

    /**
     * Get a callback that can be used as double pass middleware.
     *
     * @return callable
     */
    public function asDoublePass(): callable
    {
        return function (ServerRequest $request, Response $response, callable $next): Response {
            return $this->isRequestSigned($request)
                ? $this->handleSignedRequest($request, $response, $next)
                : $next($request, $response);
        };
    }

    /**
     * Handle signed request.
     *
     * @param ServerRequest  $request
     * @param Response|null  $response
     * @param callable       $next
     * @return Response
     * @throws \RuntimeException when the unauthorized response can't be created.
     */
    protected function handleSignedRequest(ServerRequest $request, ?Response $response, callable $next): Response
    {
        try {
            $keyId = $this->service->verify($request);
            $request = $request->withAttribute('signature_key_id', $keyId);

            $nextResponse = $next($request, $response);
        } catch (HttpSignatureException $exception) {
            $nextResponse = $this->createUnauthorizedResponse($request, $response, $exception->getMessage());
        }

        return $nextResponse;
    }

    /**
     * Check if the request contains a signature authorization header.
     *
     * @param ServerRequest $request
     * @return bool
     */
    protected function isRequestSigned(ServerRequest $request): bool
    {
        return
            $request->hasHeader('authorization') &&
            (substr(strtolower($request->getHeaderLine('authorization')), 0, 10) === 'signature ');
    }

    /**
     * Create a response using the response factory.
     *
     * @param int           $status            Response status
     * @param Response|null $originalResponse
     * @return Response
     */
    protected function createResponse(int $status, ?Response $originalResponse = null): Response
    {
        if ($this->responseFactory === null && $originalResponse === null) {
            throw new \BadMethodCallException('Response factory not set');
        }

        return $this->responseFactory !== null

The expression return $this->responseFactory !== null ? $this->responseFactory->createResponse($status) : $originalResponse->withStatus($status)->withBody(clone $originalResponse->getBody()) could return the type null which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

            ? $this->responseFactory->createResponse($status)
            : $originalResponse->withStatus($status)->withBody(clone $originalResponse->getBody());

The method withStatus() does not exist on null.

    }

    /**
     * Create a `401 Unauthorized` response.
     *
     * @param ServerRequest $request
     * @param Response|null $response
     * @param string        $message
     * @return Response
     * @throws \RuntimeException when can't write body.
     */
    protected function createUnauthorizedResponse(
        ServerRequest $request,
        ?Response $response,
        string $message
    ): Response {
        $newResponse = $this->createResponse(401, $response);

        $errorResponse = $this->service->setAuthenticateResponseHeader($request->getMethod(), $newResponse)
            ->withHeader('Content-Type', 'text/plain');

        $errorResponse->getBody()->write($message);

        return $errorResponse;
    }
}