Jasny\Controller\View

Complexity

Total Complexity

6

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
	getRequest()	0	1	?
	getResponse()	0	1	?
	setResponse()	0	1	?
A	getViewer()	0	8	2
A	setViewer()	0	4	1
A	getViewPath()	0	4	1
A	view()	0	12	2

<?php

namespace Jasny\Controller;

use Jasny\ViewInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * View using a template engine
 */
trait View
{
    /**
     * @var ViewInterface 
     */
    protected $viewer;
    
    /**
     * Get server request
     * 
     * @return ServerRequestInterface
     */
    abstract public function getRequest();
    
    /**
     * Get server request
     * 
     * @return ResponseInterface
     */
    abstract public function getResponse();

    /**
     * Get response. set for controller
     *
     * @param ResponseInterface $response
     */
    abstract public function setResponse(ResponseInterface $response);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    
    
    /**
     * Get the template engine abstraction
     * 
     * @return ViewInterface
     */
    public function getViewer()
    {
        if (!isset($this->viewer)) {
            throw new \LogicException("Viewer has not been set");
        }
        
        return $this->viewer;
    }
    
    /**
     * Get the template engine abstraction
     * 
     * @param ViewInterface $viewer
     */
    public function setViewer(ViewInterface $viewer)
    {
        $this->viewer = $viewer;
    }
    
    
    /**
     * Get path of the view files
     *
     * @return string
     */
    public function getViewPath()
    {
        return getcwd();
    }
    
    /**
     * View rendered template
     *
     * @param string $name    Template name
     * @param array  $context Template context
     */
    public function view($name, array $context = [])
    {
        $context += ['current_url' => $this->getRequest()->getUri()];
        
        if (method_exists($this, 'flash')) {
            $context += ['flash' => $this->flash()];

It seems like flash() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        
        $response = $this->getViewer()->render($this->getResponse(), $name, $context);
        
        $this->setResponse($response);
    }
}