Jasny\Controller\RouteAction

Complexity

Total Complexity

13

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	run()	0	21	6
A	getActionMethod()	0	4	1
B	getFunctionArgs()	0	27	6

<?php

namespace Jasny\Controller;

use Psr\Http\Message\ResponseInterface;

/**
 * Execute controller on given route
 */
trait RouteAction
{
    /**
     * Run the controller
     *
     * @return ResponseInterface
     */
    public function run() {
        $request = $this->getRequest();

It seems like getRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!$request) {
            throw new \RuntimeException("Request object is not set for controller");            
        }

        $route = $request->getAttribute('route');
        $method = $this->getActionMethod(isset($route->action) ? $route->action : null);
        
        if (!method_exists($this, $method)) {
            throw new \RuntimeException("No method $method in conrtoller to route to");
        }

        $args = isset($route->args) ? 
            $route->args :
            $this->getFunctionArgs($route, new \ReflectionMethod($this, $method));

        $response = call_user_func_array([$this, $method], $args);

        return $response ?: $this->getResponse();        

It seems like getResponse() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get the method name of the action
     * 
     * @param string $action
     * @return string
     */
    protected function getActionMethod($action)
    {
        return \Jasny\camelcase($action) . 'Action';
    }

    /**
     * Get the arguments for a function from a route using reflection
     * 
     * @param object $route
     * @param \ReflectionFunctionAbstract $refl
     * @return array
     */
    protected function getFunctionArgs($route, \ReflectionFunctionAbstract $refl)
    {
        $args = [];
        $params = $refl->getParameters();

        foreach ($params as $param) {
            $key = $param->name;

            if (property_exists($route, $key)) {
                $value = $route->{$key};
            } else {
                if (!$param->isOptional()) {
                    $fn = $refl instanceof \ReflectionMethod
                        ? $refl->getDeclaringClass()->getName() . ':' . $refl->getName()

Consider using $refl->class. There is an issue with getName() and APC-enabled PHP versions.

Consider using $refl->name. There is an issue with getName() and APC-enabled PHP versions.

                        : $refl->getName();

                    throw new \RuntimeException("Missing argument '$key' for $fn()");
                }
                
                $value = $param->isDefaultValueAvailable() ? $param->getDefaultValue() : null;
            }

            $args[$key] = $value;
        }
        
        return $args;
    }
}