Jasny\Controller\Guard

Complexity

Total Complexity

2

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	11	2

<?php

namespace Jasny\Controller;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;

#[\Attribute]
abstract class Guard
{
    use Traits\Base,
        Traits\Header,
        Traits\Output,
        Traits\CheckRequest,
        Traits\CheckResponse;

    /**
     * @return void|null|ResponseInterface|$this
     */
    abstract public function process();

    /**
     * Invoke guard.
     *
     * @param ServerRequestInterface $request
     * @param ResponseInterface $response
     * @return ResponseInterface|null
     */
    public function __invoke(ServerRequestInterface $request, ResponseInterface $response): ?ResponseInterface
    {
        $this->request = $request;
        $this->response = $response;

        $args = $this->getFunctionArgs(new \ReflectionMethod($this, 'process'));

        /** @noinspection PhpMethodParametersCountMismatchInspection */
        $result = $this->process(...$args);

The call to Jasny\Controller\Guard::process() has too many arguments starting with $args.

        return $result === $this ? $this->getResponse() : $result;

The expression return $result === $this ? $this->getResponse() : $result could return the type Jasny\Controller\Guard which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface|null. Consider adding an additional type-check to rule them out.

    }
}