Jarobe\TaskRunner\Hydrator\Discovery

Complexity

Total Complexity

6

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getTasks()	0	8	2
A	discoverTaskTypes()	0	19	3

<?php


namespace Jarobe\TaskRunner\Hydrator;

use Doctrine\Common\Annotations\Reader;
use Jarobe\TaskRunner\TaskType\TaskTypeInterface;
use Jarobe\TaskRUnner\Annotation\TaskType;
use Symfony\Component\Finder\Finder;
use Symfony\Component\Finder\SplFileInfo;


class Discovery implements DiscoveryInterface
{
    /**
     * @var string
     */
    private $namespace;

    /**
     * @var string
     */
    private $directory;

    /**
     * @var Reflector
     */
    private $reflector;

    /**
     * The Kernel root directory
     * @var string
     */
    private $rootDir;

    /**
     * @var array
     */
    private $tasks = [];


    /**
     * WorkerDiscovery constructor.
     *
     * @param $namespace
     *   The namespace of the workers
     * @param $directory
     *   The directory of the workers
     * @param $rootDir
     * @param Reflector $reflector
     */
    public function __construct($namespace, $directory, $rootDir, Reflector $reflector)
    {
        $this->namespace = $namespace;
        $this->reflector = $reflector;
        $this->directory = $directory;
        $this->rootDir = $rootDir;
    }

    /**
     * Returns all the tasks
     * @return array
     */
    public function getTasks()
    {
        if (!$this->tasks) {

The expression $this->tasks of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->discoverTaskTypes();
        }

        return $this->tasks;
    }

    /**
     * Discovers tasks
     */
    private function discoverTaskTypes()
    {
        $path = $this->rootDir . '/../src/' . $this->directory;
        $finder = new Finder();
        $finder->files()->in($path);

        /** @var SplFileInfo $file */
        foreach ($finder as $file) {
            /** @var TaskTypeInterface $class */
            $class = $this->namespace . '\\' . $file->getBasename('.php');

            $name = $this->reflector->getNameForClass($class);

Are you sure the assignment to $name is correct as $this->reflector->getNameForClass($class) (which targets Jarobe\TaskRunner\Hydrator\Reflector::getNameForClass()) seems to always return null.

            if (!$name) {
                continue;
            }
            /** @var TaskType $annotation */
            $this->tasks[$name] = $class;
        }
    }
}