ProcessorTest - Code Metrics - Inspection of "add Processor test" - jarobe42/task-runner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Jim

created 2017-11-08 05:19 UTC

ProcessorTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	5
c	0
b	0
f	0
lcom	1
cbo	4
dl	0
loc	74
rs	10

4 Methods

Rating	Name	Size	Complexity
A	setUp()	5	1
B	it_can_process_tasks()	28	2
A	processExamples()	9	1
A	it_handles_an_unsupported_task()	13	1

<?php


namespace Jarobe\TaskRunnerBundle\Tests\Processor;


use Jarobe\TaskRunnerBundle\Driver\Factory\DriverFactory;
use Jarobe\TaskRunnerBundle\Driver\TaskDriverInterface;
use Jarobe\TaskRunnerBundle\Exception\TaskException;
use Jarobe\TaskRunnerBundle\Model\TaskResult;
use Jarobe\TaskRunnerBundle\Processor\Processor;
use Jarobe\TaskRunnerBundle\Processor\ProcessorInterface;
use Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface;
use Prophecy\Prophecy\ObjectProphecy;

class ProcessorTest extends \PHPUnit_Framework_TestCase
{
    /** @var DriverFactory|ObjectProphecy */
    private $driverFactory;

    /** @var Processor */
    private $processor;

    public function setUp()
    {
        $this->driverFactory = $this->prophesize(DriverFactory::class);
        $this->processor = new Processor($this->driverFactory->reveal());
    }

    /**
     * @test
     * @dataProvider processExamples
     */
    public function it_can_process_tasks(
        $success,
        array $validationErrors,
        array $runErrors
    )
    {
        /** @var TaskDriverInterface|ObjectProphecy $driver */
        $driver = $this->prophesize(TaskDriverInterface::class);

        /** @var TaskTypeInterface|ObjectProphecy $task */
        $task = $this->prophesize(TaskTypeInterface::class);

        //Try for a driver
        $driver->canRun($task->reveal())->willReturn($validationErrors);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $driver->run($task->reveal())->willReturn($runErrors);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->driverFactory->getDriverForTask($task->reveal())->willReturn($driver->reveal());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $result = $this->processor->process($task->reveal());
        $this->assertInstanceOf(TaskResult::class, $result);
        $this->assertEquals($success, $result->isSuccess());

        if (count($validationErrors) > 0) {
            $this->assertEquals($validationErrors, $result->getErrors());
        } else {
            $this->assertEquals($runErrors, $result->getErrors());
        }
    }

    public function processExamples()
    {
        return [
            [true, [], []],
            [false, ['error'], []],
            [false, [], ['error']],
            [false, ['error'], ['error']]
        ];
    }

    /**
     * @test
     */
    public function it_handles_an_unsupported_task()
    {
        /** @var TaskTypeInterface|ObjectProphecy $task */
        $task = $this->prophesize(TaskTypeInterface::class);

        //Try for a driver that doesn't exist
        $this->driverFactory->getDriverForTask($task->reveal())->willThrow(TaskException::class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $result = $this->processor->process($task->reveal());
        $this->assertInstanceOf(TaskResult::class, $result);
        $this->assertEquals(false, $result->isSuccess());
        $this->assertCount(1, $result->getErrors());
    }
}


1			<?php
2
3
4			namespace Jarobe\TaskRunnerBundle\Tests\Processor;
5
6
7			use Jarobe\TaskRunnerBundle\Driver\Factory\DriverFactory;
8			use Jarobe\TaskRunnerBundle\Driver\TaskDriverInterface;
9			use Jarobe\TaskRunnerBundle\Exception\TaskException;
10			use Jarobe\TaskRunnerBundle\Model\TaskResult;
11			use Jarobe\TaskRunnerBundle\Processor\Processor;
12			use Jarobe\TaskRunnerBundle\Processor\ProcessorInterface;
13			use Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface;
14			use Prophecy\Prophecy\ObjectProphecy;
15
16			class ProcessorTest extends \PHPUnit_Framework_TestCase
17			{
18			/** @var DriverFactory\|ObjectProphecy */
19			private $driverFactory;
20
21			/** @var Processor */
22			private $processor;
23
24			public function setUp()
25			{
26			$this->driverFactory = $this->prophesize(DriverFactory::class);
27			$this->processor = new Processor($this->driverFactory->reveal());
28			}
29
30			/**
31			* @test
32			* @dataProvider processExamples
33			*/
34			public function it_can_process_tasks(
35			$success,
36			array $validationErrors,
37			array $runErrors
38			)
39			{
40			/** @var TaskDriverInterface\|ObjectProphecy $driver */
41			$driver = $this->prophesize(TaskDriverInterface::class);
42
43			/** @var TaskTypeInterface\|ObjectProphecy $task */
44			$task = $this->prophesize(TaskTypeInterface::class);
45
46			//Try for a driver
47			$driver->canRun($task->reveal())->willReturn($validationErrors);
			0 ignored issues – show Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... / } Loading history... Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `canRun` does only exist in `Jarobe\TaskRunnerBundle\Driver\TaskDriverInterface`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /* * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48			$driver->run($task->reveal())->willReturn($runErrors);
			0 ignored issues – show Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `run` does only exist in `Jarobe\TaskRunnerBundle\Driver\TaskDriverInterface`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
49
50			$this->driverFactory->getDriverForTask($task->reveal())->willReturn($driver->reveal());
			0 ignored issues – show Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `getDriverForTask` does only exist in `Jarobe\TaskRunnerBundle\...r\Factory\DriverFactory`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... / } Loading history... Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Jarobe\TaskRunnerBundle\Driver\TaskDriverInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /* * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
51
52			$result = $this->processor->process($task->reveal());
53			$this->assertInstanceOf(TaskResult::class, $result);
54			$this->assertEquals($success, $result->isSuccess());
55
56			if (count($validationErrors) > 0) {
57			$this->assertEquals($validationErrors, $result->getErrors());
58			} else {
59			$this->assertEquals($runErrors, $result->getErrors());
60			}
61			}
62
63			public function processExamples()
64			{
65			return [
66			[true, [], []],
67			[false, ['error'], []],
68			[false, [], ['error']],
69			[false, ['error'], ['error']]
70			];
71			}
72
73			/**
74			* @test
75			*/
76			public function it_handles_an_unsupported_task()
77			{
78			/** @var TaskTypeInterface\|ObjectProphecy $task */
79			$task = $this->prophesize(TaskTypeInterface::class);
80
81			//Try for a driver that doesn't exist
82			$this->driverFactory->getDriverForTask($task->reveal())->willThrow(TaskException::class);
			0 ignored issues – show Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... / } Loading history... Bug introduced 2017-11-08 05:21 UTC by Report Bug Copy Issue Report The method `getDriverForTask` does only exist in `Jarobe\TaskRunnerBundle\...r\Factory\DriverFactory`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /* * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
83
84			$result = $this->processor->process($task->reveal());
85			$this->assertInstanceOf(TaskResult::class, $result);
86			$this->assertEquals(false, $result->isSuccess());
87			$this->assertCount(1, $result->getErrors());
88			}
89			}
90

jarobe42 / task-runner

Pull Request — master (#9)

ProcessorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like