Jarobe\TaskRunnerBundle\Processor\Processor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	process()	0	36	4

<?php

namespace Jarobe\TaskRunnerBundle\Processor;

use Jarobe\TaskRunnerBundle\Exception\TaskException;
use Jarobe\TaskRunnerBundle\Model\TaskResult;
use Jarobe\TaskRunnerBundle\Driver\Factory\DriverFactory;
use Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface;

class Processor implements ProcessorInterface
{
    /**
     * @var DriverFactory
     */
    private $driverFactory;

    public function __construct(DriverFactory $driverFactory)
    {
        $this->driverFactory = $driverFactory;
    }

    /**
     * @param TaskTypeInterface $task
     * @return TaskResult
     */
    public function process(TaskTypeInterface $task)
    {
        $taskResult = new TaskResult();

        try {
            $driver = $this->driverFactory->getDriverForTask($task);
        } catch (TaskException $e) {
            $exceptionMessage = sprintf("TaskException: %s", $e->getMessage());
            $taskResult->setSuccess(false)
                ->setErrors([$exceptionMessage])
            ;
            return $taskResult;
        }


        //See if there's any issues with the tasks before running.
        $validationErrors = $driver->canRun($task);
        if (count($validationErrors) > 0) {
            $taskResult->setSuccess(false)
                ->setErrors($validationErrors)

It seems like $validationErrors defined by $driver->canRun($task) on line 42 can also be of type null; however, Jarobe\TaskRunnerBundle\Model\TaskResult::setErrors() does only seem to accept array, maybe add an additional type check?

            ;
            return $taskResult;
        }

        //Run the task, and then check for errors
        $errors = $driver->run($task);
        if (count($errors) > 0) {
            $taskResult->setSuccess(false)
                ->setErrors($errors)

It seems like $errors defined by $driver->run($task) on line 51 can also be of type null; however, Jarobe\TaskRunnerBundle\Model\TaskResult::setErrors() does only seem to accept array, maybe add an additional type check?

            ;
            return $taskResult;
        }

        $taskResult->setSuccess(true);
        return $taskResult;
    }
}