Issues in Builder.php (5.2) - Issues in 5.2 - jarektkaczyk/eloquence - Measure and Improve Code Quality continuously with Scrutinizer

Issues (107)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Query/Builder.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Sofa\Eloquence\Query;

use Sofa\Eloquence\Subquery;

class Builder extends \Illuminate\Database\Query\Builder
{
    /**
     * Execute an aggregate function on the database.
     *
     * @param  string  $function
     * @param  array   $columns
     * @return float|int
     */
    public function aggregate($function, $columns = ['*'])
    {
        $this->aggregate = compact('function', 'columns');

        $previousColumns = $this->columns;

        if (!$this->from instanceof Subquery) {
            // We will also back up the select bindings since the select clause will be
            // removed when performing the aggregate function. Once the query is run
            // we will add the bindings back onto this query so they can get used.
            $previousSelectBindings = $this->bindings['select'];

            $this->bindings['select'] = [];
        }

        $results = $this->get($columns);

        // Once we have executed the query, we will reset the aggregate property so
        // that more select queries can be executed against the database without
        // the aggregate value getting in the way when the grammar builds it.
        $this->aggregate = null;


        $this->columns = $previousColumns;

        if (!$this->from instanceof Subquery) {
            $this->bindings['select'] = $previousSelectBindings;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        if (isset($results[0])) {
            $result = array_change_key_case((array) $results[0]);

            return $result['aggregate'];
        }
    }

    /**
     * Backup some fields for the pagination count.
     *
     * @return void
     */
    protected function backupFieldsForCount()
    {
        foreach (['orders', 'limit', 'offset', 'columns'] as $field) {
            $this->backups[$field] = $this->{$field};

            $this->{$field} = null;
        }

        $bindings = ($this->from instanceof Subquery) ? ['order'] : ['order', 'select'];

        foreach ($bindings as $key) {
            $this->bindingBackups[$key] = $this->bindings[$key];

            $this->bindings[$key] = [];
        }
    }

    /**
     * Restore some fields after the pagination count.
     *
     * @return void
     */
    protected function restoreFieldsForCount()
    {
        foreach ($this->backups as $field => $value) {
            $this->{$field} = $value;
        }

        foreach ($this->bindingBackups as $key => $value) {
            $this->bindings[$key] = $value;
        }

        $this->backups = $this->bindingBackups = [];
    }
}


1			<?php
2
3			namespace Sofa\Eloquence\Query;
4
5			use Sofa\Eloquence\Subquery;
6
7			class Builder extends \Illuminate\Database\Query\Builder
8			{
9			/**
10			* Execute an aggregate function on the database.
11			*
12			* @param string $function
13			* @param array $columns
14			* @return float\|int
15			*/
16			public function aggregate($function, $columns = ['*'])
17			{
18			$this->aggregate = compact('function', 'columns');
19
20			$previousColumns = $this->columns;
21
22			if (!$this->from instanceof Subquery) {
23			// We will also back up the select bindings since the select clause will be
24			// removed when performing the aggregate function. Once the query is run
25			// we will add the bindings back onto this query so they can get used.
26			$previousSelectBindings = $this->bindings['select'];
27
28			$this->bindings['select'] = [];
29			}
30
31			$results = $this->get($columns);
32
33			// Once we have executed the query, we will reset the aggregate property so
34			// that more select queries can be executed against the database without
35			// the aggregate value getting in the way when the grammar builds it.
36			$this->aggregate = null;
			0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `null` of type `null` is incompatible with the declared type `array` of property `$aggregate`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
37
38			$this->columns = $previousColumns;
39
40			if (!$this->from instanceof Subquery) {
41			$this->bindings['select'] = $previousSelectBindings;
			0 ignored issues – show Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$previousSelectBindings` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
42			}
43
44			if (isset($results[0])) {
45			$result = array_change_key_case((array) $results[0]);
46
47			return $result['aggregate'];
48			}
49			}
50
51			/**
52			* Backup some fields for the pagination count.
53			*
54			* @return void
55			*/
56			protected function backupFieldsForCount()
57			{
58			foreach (['orders', 'limit', 'offset', 'columns'] as $field) {
59			$this->backups[$field] = $this->{$field};
60
61			$this->{$field} = null;
62			}
63
64			$bindings = ($this->from instanceof Subquery) ? ['order'] : ['order', 'select'];
65
66			foreach ($bindings as $key) {
67			$this->bindingBackups[$key] = $this->bindings[$key];
68
69			$this->bindings[$key] = [];
70			}
71			}
72
73			/**
74			* Restore some fields after the pagination count.
75			*
76			* @return void
77			*/
78			protected function restoreFieldsForCount()
79			{
80			foreach ($this->backups as $field => $value) {
81			$this->{$field} = $value;
82			}
83
84			foreach ($this->bindingBackups as $key => $value) {
85			$this->bindings[$key] = $value;
86			}
87
88			$this->backups = $this->bindingBackups = [];
89			}
90			}
91

jarektkaczyk / eloquence

Issues (107)

Security Analysis no request data

src/Query/Builder.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like