Hooks - Code Metrics - Inspection of "Support Model::isDirty() for mapped attributes" - jarektkaczyk/eloquence - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 5.1 (#39)

unknown

created 2016-01-18 18:39 UTC

Hooks A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	145
Duplicated Lines	24.14 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	19
c	2
b	0
f	0
lcom	0
cbo	0
dl	35
loc	145
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	queryHook()	3	18	3
A	isDirty()	0	11	3
A	save()	0	8	1
A	__issetHook()	12	12	3
A	__unsetHook()	0	12	2
A	getAttribute()	12	12	2
A	setAttribute()	0	12	2
A	__call()	8	8	3

How to fix Duplicated Code

<?php

namespace Sofa\Eloquence\Mappable;

use BadMethodCallException;

/**
 * This class provides instance scope for the closures
 * so they can be rebound later onto the acutal model.
 */
class Hooks
{
    /**
     * Register hook on customWhere method.
     *
     * @codeCoverageIgnore
     *
     * @return \Closure
     */
    public function queryHook()
    {
        return function ($next, $query, $bag) {
            $method = $bag->get('method');
            $args   = $bag->get('args');
            $column = $args->get('column');

            if ($this->hasMapping($column)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return call_user_func_array([$this, 'mappedQuery'], [$query, $method, $args]);
            }

            if (in_array($method, ['select', 'addSelect'])) {

                call_user_func_array([$this, 'mappedSelect'], [$query, $args]);
            }

            return $next($query, $bag);
        };
    }

    public function isDirty()
    {
        return function ($next, $attributes = null, $bag) {
            if (is_array($attributes)) {
                $attributes = array_map(function ($attribute) {
                    return $this->getMappingForAttribute($attribute) ?: $attribute;
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                }, $attributes);
            }
            return $next($attributes, $bag);
        };
    }

    /**
     * Register hook on save method.
     *
     * @codeCoverageIgnore
     *
     * @return \Closure
     */
    public function save()
    {
        return function ($next, $value, $args) {
            $this->saveMapped();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            return $next($value, $args);
        };
    }

    /**
     * Register hook on isset call.
     *
     * @codeCoverageIgnore
     *
     * @return \Closure
     */
    public function __issetHook()

    {
        return function ($next, $isset, $args) {
            $key = $args->get('key');

            if (!$isset && $this->hasMapping($key)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return (bool) $this->mapAttribute($key);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }

            return $next($isset, $args);
        };
    }

    /**
     * Register hook on unset call.
     *
     * @codeCoverageIgnore
     *
     * @return \Closure
     */
    public function __unsetHook()
    {
        return function ($next, $value, $args) {
            $key = $args->get('key');

            if ($this->hasMapping($key)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return $this->forget($key);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }

            return $next($value, $args);
        };
    }

    /**
     * Register hook on getAttribute method.
     *
     * @codeCoverageIgnore
     *
     * @return \Closure
     */
    public function getAttribute()

    {
        return function ($next, $value, $args) {
            $key = $args->get('key');

            if ($this->hasMapping($key)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $value = $this->mapAttribute($key);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }

            return $next($value, $args);
        };
    }

    /**
     * Register hook on setAttribute method.
     *
     * @codeCoverageIgnore
     *
     * @return \Closure
     */
    public function setAttribute()
    {
        return function ($next, $value, $args) {
            $key = $args->get('key');

            if ($this->hasMapping($key)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return $this->setMappedAttribute($key, $value);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }

            return $next($value, $args);
        };
    }

    public function __call($method, $params)

    {
        if (strpos($method, '__') === 0 && method_exists($this, $method.'Hook')) {
            return call_user_func_array([$this, $method.'Hook'], $params);
        }

        throw new BadMethodCallException("Method [{$method}] doesn't exist on this object.");
    }
}


1		<?php
2
3		namespace Sofa\Eloquence\Mappable;
4
5		use BadMethodCallException;
6
7		/**
8		* This class provides instance scope for the closures
9		* so they can be rebound later onto the acutal model.
10		*/
11		class Hooks
12		{
13		/**
14		* Register hook on customWhere method.
15		*
16		* @codeCoverageIgnore
17		*
18		* @return \Closure
19		*/
20		public function queryHook()
21		{
22		return function ($next, $query, $bag) {
23		$method = $bag->get('method');
24		$args = $bag->get('args');
25		$column = $args->get('column');
26
27		if ($this->hasMapping($column)) {
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `hasMapping` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
28		return call_user_func_array([$this, 'mappedQuery'], [$query, $method, $args]);
29		}
30
31	View Code Duplication	if (in_array($method, ['select', 'addSelect'])) {
		0 ignored issues – show Duplication introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		call_user_func_array([$this, 'mappedSelect'], [$query, $args]);
33		}
34
35		return $next($query, $bag);
36		};
37		}
38
39		public function isDirty()
40		{
41		return function ($next, $attributes = null, $bag) {
42		if (is_array($attributes)) {
43		$attributes = array_map(function ($attribute) {
44		return $this->getMappingForAttribute($attribute) ?: $attribute;
		0 ignored issues – show Documentation Bug introduced 2015-12-03 18:30 UTC by Report Bug Copy Issue Report The method `getMappingForAttribute` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
45		}, $attributes);
46		}
47		return $next($attributes, $bag);
48		};
49		}
50
51		/**
52		* Register hook on save method.
53		*
54		* @codeCoverageIgnore
55		*
56		* @return \Closure
57		*/
58		public function save()
59		{
60		return function ($next, $value, $args) {
61		$this->saveMapped();
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `saveMapped` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
62
63		return $next($value, $args);
64		};
65		}
66
67		/**
68		* Register hook on isset call.
69		*
70		* @codeCoverageIgnore
71		*
72		* @return \Closure
73		*/
74	View Code Duplication	public function __issetHook()
		0 ignored issues – show Duplication introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		return function ($next, $isset, $args) {
77		$key = $args->get('key');
78
79		if (!$isset && $this->hasMapping($key)) {
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `hasMapping` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
80		return (bool) $this->mapAttribute($key);
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `mapAttribute` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
81		}
82
83		return $next($isset, $args);
84		};
85		}
86
87		/**
88		* Register hook on unset call.
89		*
90		* @codeCoverageIgnore
91		*
92		* @return \Closure
93		*/
94		public function __unsetHook()
95		{
96		return function ($next, $value, $args) {
97		$key = $args->get('key');
98
99		if ($this->hasMapping($key)) {
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `hasMapping` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
100		return $this->forget($key);
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `forget` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
101		}
102
103		return $next($value, $args);
104		};
105		}
106
107		/**
108		* Register hook on getAttribute method.
109		*
110		* @codeCoverageIgnore
111		*
112		* @return \Closure
113		*/
114	View Code Duplication	public function getAttribute()
		0 ignored issues – show Duplication introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115		{
116		return function ($next, $value, $args) {
117		$key = $args->get('key');
118
119		if ($this->hasMapping($key)) {
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `hasMapping` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
120		$value = $this->mapAttribute($key);
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `mapAttribute` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
121		}
122
123		return $next($value, $args);
124		};
125		}
126
127		/**
128		* Register hook on setAttribute method.
129		*
130		* @codeCoverageIgnore
131		*
132		* @return \Closure
133		*/
134		public function setAttribute()
135		{
136		return function ($next, $value, $args) {
137		$key = $args->get('key');
138
139		if ($this->hasMapping($key)) {
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `hasMapping` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
140		return $this->setMappedAttribute($key, $value);
		0 ignored issues – show Documentation Bug introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report The method `setMappedAttribute` does not exist on `object<Sofa\Eloquence\Mappable\Hooks>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
141		}
142
143		return $next($value, $args);
144		};
145		}
146
147	View Code Duplication	public function __call($method, $params)
		0 ignored issues – show Duplication introduced 2015-11-21 12:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
148		{
149		if (strpos($method, '__') === 0 && method_exists($this, $method.'Hook')) {
150		return call_user_func_array([$this, $method.'Hook'], $params);
151		}
152
153		throw new BadMethodCallException("Method [{$method}] doesn't exist on this object.");
154		}
155		}
156

jarektkaczyk / eloquence

Pull Request — 5.1 (#39)

Hooks A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like