Sofa\Eloquence\Relations\JoinerFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	make()	0	9	2

<?php

namespace Sofa\Eloquence\Relations;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Sofa\Eloquence\Contracts\Relations\JoinerFactory as FactoryContract;

class JoinerFactory implements FactoryContract
{
    /**
     * Create new joiner instance.
     *
     * @param  \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder $query
     * @param  \Illuminate\Database\Eloquent\Model $model
     * @return \Sofa\Eloquence\Relations\Joiner
     */
    public static function make($query, Model $model = null)
    {
        if ($query instanceof EloquentBuilder) {
            $model = $query->getModel();
            $query = $query->getQuery();
        }

        return new Joiner($query, $model);

It seems like $model defined by parameter $model on line 18 can be null; however, Sofa\Eloquence\Relations\Joiner::__construct() does not accept null, maybe add an additional type check?

    }
}