TimberRequest::__construct() - Code Metrics - Inspection of "Adding request.get/post to TimberSite" - jarednova/timber - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#853)

unknown

created 2016-02-16 20:19 UTC

TimberRequest::__construct() A

↳ Parent: TimberRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

/**
 * TimberRequest exposes $_GET and $_POST to the context
 */
class TimberRequest extends TimberCore implements TimberCoreInterface {


	public $post = array();
	public $get = array();
	
	/**
	 * Constructs a TimberRequest object
	 * @example
	 */
	function __construct() {

		$this->init();
	}

	/**
	 * @internal
	 */
	protected function init() {
		$this->post = $_POST;

		$this->get = $_GET;

	}
}


1			<?php
2
3			/**
4			* TimberRequest exposes $_GET and $_POST to the context
5			*/
6			class TimberRequest extends TimberCore implements TimberCoreInterface {
			0 ignored issues – show Bug introduced 2016-02-16 20:26 UTC by Report Bug Copy Issue Report There is one abstract method `meta` in this class; you could implement it, or declare this class as abstract. Loading history...
7
8			public $post = array();
9			public $get = array();
10
11			/**
12			* Constructs a TimberRequest object
13			* @example
14			*/
15			function __construct() {
			0 ignored issues – show Best Practice introduced 2016-02-16 20:23 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
16			$this->init();
17			}
18
19			/**
20			* @internal
21			*/
22			protected function init() {
23			$this->post = $_POST;
			0 ignored issues – show introduced 2016-02-16 20:23 UTC by Report Bug Copy Issue Report Detected access of super global var $_POST, probably need manual inspection. Loading history... introduced 2016-02-16 20:23 UTC by Report Bug Copy Issue Report Detected usage of a non-sanitized input variable: $_POST Loading history...
24			$this->get = $_GET;
			0 ignored issues – show introduced 2016-02-16 20:23 UTC by Report Bug Copy Issue Report Detected access of super global var $_GET, probably need manual inspection. Loading history... introduced 2016-02-16 20:23 UTC by Report Bug Copy Issue Report Detected usage of a non-sanitized input variable: $_GET Loading history...
25			}
26			}
27

jarednova / timber

Pull Request — master (#853)

TimberRequest::__construct() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like