TimberTwig - Code Metrics - Inspection of "Merge pull request #773 from jarednova/test_for_pa..." - jarednova/timber - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 95b7fe...0721f9 )

by Jared

created 2015-12-08 12:54 UTC

TimberTwig B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	341
Duplicated Lines	21.11 %

Coupling/Cohesion

Components	0
Dependencies	5

Metric	Value
wmc	52
lcom	0
cbo	5
dl	72
loc	341
rs	7.9487

13 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	3	1
A	__construct()	0	4	1
A	add_timber_filters_deprecated()	0	10	1
D	add_timber_filters()	72	147	25
A	to_array()	0	7	2
A	exec_function()	0	8	2
A	twig_pretags()	0	3	1
A	convert_pre_entities()	0	3	1
A	body_class()	0	10	2
B	intl_date()	0	15	5
A	object_docs()	0	13	2
B	time_ago()	0	11	5
A	add_list_separators()	0	15	4

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like TimberTwig often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use TimberTwig, and based on these observations, apply Extract Interface, too.

<?php

class TimberTwig {

	public static $dir_name;

	/**
	 * Initialization
	 */
	public static function init() {
		new TimberTwig();
	}

	function __construct() {

		add_action( 'timber/twig/filters', array( $this, 'add_timber_filters_deprecated' ) );
		add_action( 'timber/twig/filters', array( $this, 'add_timber_filters' ) );
	}

	/**
	 * These are all deprecated and will be removed in 0.21.0
	 *
	 * @param Twig_Environment $twig
	 * @deprecated since 0.20.7
	 * @return Twig_Environment
	 */
	function add_timber_filters_deprecated( $twig ) {

		$twig->addFilter( new Twig_SimpleFilter( 'get_src_from_attachment_id', 'twig_get_src_from_attachment_id' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'wp_body_class', array( $this, 'body_class' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'twitterify', array( 'TimberHelper', 'twitterify' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'twitterfy', array( 'TimberHelper', 'twitterify' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'string', function($arr, $glue = ' '){
			return twig_join_filter($arr, $glue);

		} ) );
		return $twig;
	}

	/**
	 *
	 *
	 * @param Twig_Environment $twig
	 * @return Twig_Environment
	 */
	function add_timber_filters( $twig ) {

		/* image filters */
		$twig->addFilter( new Twig_SimpleFilter( 'resize', array( 'TimberImageHelper', 'resize' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'retina', array( 'TimberImageHelper', 'retina_resize' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'letterbox', array( 'TimberImageHelper', 'letterbox' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'tojpg', array( 'TimberImageHelper', 'img_to_jpg' ) ) );

		/* debugging filters */
		$twig->addFilter( new Twig_SimpleFilter( 'docs', 'twig_object_docs' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'get_class',  'get_class' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'get_type', 'get_type' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'print_r', function( $arr ) {
					return print_r( $arr, true );

				} ) );

		$twig->addFilter( new Twig_SimpleFilter( 'print_a', function( $arr ) {
					return '<pre>' . self::object_docs( $arr, true ) . '</pre>';
				} ) );


		/* other filters */
		$twig->addFilter( new Twig_SimpleFilter( 'stripshortcodes', 'strip_shortcodes' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'array', array( $this, 'to_array' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'excerpt', 'wp_trim_words' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'function', array( $this, 'exec_function' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'pretags', array( $this, 'twig_pretags' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'sanitize', 'sanitize_title' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'shortcodes', 'do_shortcode' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'time_ago', array( $this, 'time_ago' ) ) );
		$twig->addFilter( new Twig_SimpleFilter( 'wpautop', 'wpautop' ) );
		$twig->addFilter( new Twig_SimpleFilter( 'list', array( $this, 'add_list_separators' ) ) );

		$twig->addFilter( new Twig_SimpleFilter( 'relative', function ( $link ) {
					return TimberURLHelper::get_rel_url( $link, true );
				} ) );


		$twig->addFilter( new Twig_SimpleFilter( 'date', array( $this, 'intl_date' ) ) );

		$twig->addFilter( new Twig_SimpleFilter( 'truncate', function ( $text, $len ) {
					return TimberHelper::trim_words( $text, $len );
				} ) );


		/* actions and filters */
		$twig->addFunction( new Twig_SimpleFunction( 'action', function ( $context ) {
					$args = func_get_args();
					array_shift( $args );
					$args[] = $context;
					call_user_func_array( 'do_action', $args );
				}, array( 'needs_context' => true ) ) );


		$twig->addFilter( new Twig_SimpleFilter( 'apply_filters', function () {
					$args = func_get_args();
					$tag = current( array_splice( $args, 1, 1 ) );

					return apply_filters_ref_array( $tag, $args );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'function', array( &$this, 'exec_function' ) ) );
		$twig->addFunction( new Twig_SimpleFunction( 'fn', array( &$this, 'exec_function' ) ) );

		$twig->addFunction( new Twig_SimpleFunction( 'shortcode', 'do_shortcode' ) );

		/* TimberObjects */
		$twig->addFunction( new Twig_SimpleFunction( 'TimberPost', function ( $pid, $PostClass = 'TimberPost' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $PostClass( $p );
						}
						return $pid;
					}
					return new $PostClass( $pid );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'TimberImage', function ( $pid, $ImageClass = 'TimberImage' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $ImageClass( $p );
						}
						return $pid;
					}
					return new $ImageClass( $pid );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'TimberTerm', function ( $pid, $TermClass = 'TimberTerm' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $TermClass( $p );
						}
						return $pid;
					}
					return new $TermClass( $pid );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'TimberUser', function ( $pid, $UserClass = 'TimberUser' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $UserClass( $p );
						}
						return $pid;
					}
					return new $UserClass( $pid );
				} ) );


		/* TimberObjects Alias */
		$twig->addFunction( new Twig_SimpleFunction( 'Post', function ( $pid, $PostClass = 'TimberPost' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $PostClass( $p );
						}
						return $pid;
					}
					return new $PostClass( $pid );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'Image', function ( $pid, $ImageClass = 'TimberImage' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $ImageClass( $p );
						}
						return $pid;
					}
					return new $ImageClass( $pid );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'Term', function ( $pid, $TermClass = 'TimberTerm' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $TermClass( $p );
						}
						return $pid;
					}
					return new $TermClass( $pid );
				} ) );

		$twig->addFunction( new Twig_SimpleFunction( 'User', function ( $pid, $UserClass = 'TimberUser' ) {

					if ( is_array( $pid ) && !TimberHelper::is_array_assoc( $pid ) ) {

						foreach ( $pid as &$p ) {

							$p = new $UserClass( $p );
						}
						return $pid;
					}
					return new $UserClass( $pid );
				} ) );


		/* bloginfo and translate */
		$twig->addFunction( 'bloginfo', new Twig_SimpleFunction( 'bloginfo', function ( $show = '', $filter = 'raw' ) {
					return get_bloginfo( $show, $filter );
				} ) );

		$twig->addFunction( '__', new Twig_SimpleFunction( '__', function ( $text, $domain = 'default' ) {
					return __( $text, $domain );

				} ) );

		/* get_twig is deprecated, use timber/twig */
		$twig = apply_filters( 'get_twig', $twig );
		$twig = apply_filters( 'timber/twig', $twig );
		return $twig;
	}

	/**
	 *
	 *
	 * @param mixed   $arr
	 * @return array
	 */
	function to_array( $arr ) {

		if ( is_array( $arr ) ) {
			return $arr;
		}
		$arr = array( $arr );
		return $arr;
	}

	/**
	 *
	 *
	 * @param string  $function_name
	 * @return mixed
	 */
	function exec_function( $function_name ) {

		$args = func_get_args();
		array_shift( $args );
		if ( is_string($function_name) ) {

			$function_name = trim( $function_name );
		}
		return call_user_func_array( $function_name, ( $args ) );
	}

	/**
	 *
	 *
	 * @param string  $content
	 * @return string
	 */
	function twig_pretags( $content ) {

		return preg_replace_callback( '|<pre.*>(.*)</pre|isU', array( &$this, 'convert_pre_entities' ), $content );
	}

	/**
	 *
	 *
	 * @param array   $matches
	 * @return string
	 */
	function convert_pre_entities( $matches ) {

		return str_replace( $matches[1], htmlentities( $matches[1] ), $matches[0] );
	}

	/**
	 * @param mixed   $body_classes
	 * @deprecated 0.20.7
	 * @return string
	 */
	function body_class( $body_classes ) {

		ob_start();
		if ( is_array( $body_classes ) ) {
			$body_classes = explode( ' ', $body_classes );
		}
		body_class( $body_classes );
		$return = ob_get_contents();
		ob_end_clean();
		return $return;
	}

	/**
	 *
	 *
	 * @param string  $date
	 * @param string  $format (optional)

	 * @return string
	 */
	function intl_date( $date, $format = null ) {

		if ( $format === null ) {
			$format = get_option( 'date_format' );
		}

		if ( $date instanceof DateTime ) {
			$timestamp = $date->getTimestamp();
		} else if (is_numeric( $date ) && strtotime( $date ) === false ) {

			$timestamp = intval( $date );
		} else {
			$timestamp = strtotime( $date );
		}

		return date_i18n( $format, $timestamp );
	}

	//debug

	/**
	 *
	 *
	 * @param mixed   $obj
	 * @param bool    $methods
	 * @return string
	 */
	function object_docs( $obj, $methods = true ) {

		$class = get_class( $obj );
		$properties = (array)$obj;

		if ( $methods ) {
			/** @var array $methods */
			$methods = $obj->get_method_values();
		}
		$rets = array_merge( $properties, $methods );
		ksort( $rets );
		$str = print_r( $rets, true );

		$str = str_replace( 'Array', $class . ' Object', $str );
		return $str;
	}

	/**
	 * @param int|string $from
	 * @param int|string $to

	 * @param string $format_past
	 * @param string $format_future
	 * @return string
	 */
	function time_ago( $from, $to = null, $format_past = '%s ago', $format_future = '%s from now' ) {

		$to = $to === null ? time() : $to;
		$to = is_int( $to ) ? $to : strtotime( $to );
		$from = is_int( $from ) ? $from : strtotime( $from );

		if ( $from < $to ) {
			return sprintf( $format_past, human_time_diff( $from, $to ) );
		} else {
			return sprintf( $format_future, human_time_diff( $to, $from ) );
		}
	}

	/**
	 * @param array $arr
	 * @param string $first_delimiter
	 * @param string $second_delimiter
	 * @return string
	 */
	function add_list_separators( $arr, $first_delimiter = ',', $second_delimiter = 'and' ) {

		$length = count( $arr );
		$list = '';
		foreach( $arr as $index => $item ) {

			if ( $index < $length - 2 ) {
				$delimiter = $first_delimiter.' ';
			} elseif ( $index == $length - 2 ) {
				$delimiter = ' '.$second_delimiter.' ';
			} else {
				$delimiter = '';
			}
			$list = $list.$item.$delimiter;
		}
		return $list;
	}

}


1			<?php
2
3			class TimberTwig {
4
5			public static $dir_name;
6
7			/**
8			* Initialization
9			*/
10			public static function init() {
11			new TimberTwig();
12			}
13
14			function __construct() {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
15			add_action( 'timber/twig/filters', array( $this, 'add_timber_filters_deprecated' ) );
16			add_action( 'timber/twig/filters', array( $this, 'add_timber_filters' ) );
17			}
18
19			/**
20			* These are all deprecated and will be removed in 0.21.0
21			*
22			* @param Twig_Environment $twig
23			* @deprecated since 0.20.7
24			* @return Twig_Environment
25			*/
26			function add_timber_filters_deprecated( $twig ) {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
27			$twig->addFilter( new Twig_SimpleFilter( 'get_src_from_attachment_id', 'twig_get_src_from_attachment_id' ) );
28			$twig->addFilter( new Twig_SimpleFilter( 'wp_body_class', array( $this, 'body_class' ) ) );
29			$twig->addFilter( new Twig_SimpleFilter( 'twitterify', array( 'TimberHelper', 'twitterify' ) ) );
30			$twig->addFilter( new Twig_SimpleFilter( 'twitterfy', array( 'TimberHelper', 'twitterify' ) ) );
31			$twig->addFilter( new Twig_SimpleFilter( 'string', function($arr, $glue = ' '){
32			return twig_join_filter($arr, $glue);
			0 ignored issues – show Coding Style introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
33			} ) );
34			return $twig;
35			}
36
37			/**

jarednova / timber