TimberImageOperationResize

Complexity

Total Complexity

27

Size/Duplication

Total Lines	172
Duplicated Lines	16.28 %

Coupling/Cohesion

Components	1
Dependencies	3

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	3
B	filename()	0	15	5
A	run_animated_gif()	0	21	3
C	get_target_sizes()	14	58	10
B	run()	14	39	6

<?php
/**
	 * Changes image to new size, by shrinking/enlarging
	 * then cropping to respect new ratio.
	 *
	 * Arguments:
	 * - width of new image
	 * - height of new image
	 * - crop method
	 */
class TimberImageOperationResize extends TimberImageOperation {

   private $w, $h, $crop;

Tabs must be used to indent lines; spaces are not allowed

Line indented incorrectly; expected at least 1 tabs, found 0

	/**
	 * @param int    $w    width of new image
	 * @param int    $h    height of new image
	 * @param string $crop cropping method, one of: 'default', 'center', 'top', 'bottom', 'left', 'right'.
	 */
	function __construct($w, $h, $crop) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->w = $w;
		$this->h = $h;
		// Sanitize crop position
		$allowed_crop_positions = array( 'default', 'center', 'top', 'bottom', 'left', 'right' );
		if ( $crop !== false && !in_array( $crop, $allowed_crop_positions ) ) {

Found "!== false". Use Yoda Condition checks, you must

Expected 1 space after "!"; 0 found

			$crop = $allowed_crop_positions[0];
		}
		$this->crop = $crop;
	}

	/**
	 * @param   string    $src_filename     the basename of the file (ex: my-awesome-pic)
	 * @param   string    $src_extension    the extension (ex: .jpg)
	 * @return  string    the final filename to be used (ex: my-awesome-pic-300x200-c-default.jpg)
	 */
	public function filename($src_filename, $src_extension) {
		$w = 0;
		$h = 0;
		if ( $this->w ) {
			$w = $this->w;
		}
		if ( $this->h ) {
			$h = $this->h;
		}
		$result = $src_filename . '-' . $w . 'x' . $h . '-c-' . ( $this->crop ? $this->crop : 'f' ); // Crop will be either user named or f (false)
		if($src_extension) {

Space after opening control structure is required

No space before opening parenthesis is prohibited

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			$result .= '.'.$src_extension;
		}
		return $result;
	}

	protected function run_animated_gif( $load_filename, $save_filename ) {
		$image = wp_get_image_editor( $load_filename );
		$current_size = $image->get_size();
		$src_w = $current_size['width'];

$src_w is not used, you could remove the assignment.

		$src_h = $current_size['height'];

$src_h is not used, you could remove the assignment.

		$w = $this->w;
		$h = $this->h;
		if ( !class_exists('Imagick') ) {

Expected 1 space after "!"; 0 found

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			return false;
		}
		$image = new Imagick($load_filename);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$image = $image->coalesceImages();
		$crop = self::get_target_sizes( $load_filename );
		foreach ($image as $frame) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			$frame->cropImage($crop['src_w'], $crop['src_h'], $crop['x'], $crop['y']);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$frame->thumbnailImage($w, $h);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$frame->setImagePage($w, $h, 0, 0);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		}
		$image = $image->deconstructImages();
		return $image->writeImages($save_filename, true);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

	}

	protected function get_target_sizes( $load_filename ) {
		$image = wp_get_image_editor( $load_filename );
		$w = $this->w;
		$h = $this->h;
		$crop = $this->crop;

		$current_size = $image->get_size();
		$src_w = $current_size['width'];
		$src_h = $current_size['height'];
		$src_ratio = $src_w / $src_h;
		if ( !$h ) {

Expected 1 space after "!"; 0 found

			$h = round( $w / $src_ratio );
		}
		if ( !$w ) {

Expected 1 space after "!"; 0 found

			//the user wants to resize based on constant height
			$w = round( $h * $src_ratio );
		}
		if ( !$crop ) {

This code seems to be duplicated across your project.

Expected 1 space after "!"; 0 found

			return array(
				'x' => 0, 'y' => 0,
				'src_w' => $src_w, 'src_h' => $src_h,
				'target_w' => $w, 'target_h' => $h

Each line in an array declaration must end in a comma

			);
		}
		// Get ratios
		$dest_ratio = $w / $h;
		$src_wt = $src_h * $dest_ratio;
		$src_ht = $src_w / $dest_ratio;
		$src_x = $src_w / 2 - $src_wt / 2;
		$src_y = ( $src_h - $src_ht ) / 6;
		//now specific overrides based on options:
		if ( $crop == 'center' ) {

Found "== '". Use Yoda Condition checks, you must

			// Get source x and y
			$src_x = round( ( $src_w - $src_wt ) / 2 );
			$src_y = round( ( $src_h - $src_ht ) / 2 );
		} else if ( $crop == 'top' ) {

Found "== '". Use Yoda Condition checks, you must

			$src_y = 0;
		} else if ( $crop == 'bottom' ) {

Found "== '". Use Yoda Condition checks, you must

			$src_y = $src_h - $src_ht;
		} else if ( $crop == 'left' ) {

Found "== '". Use Yoda Condition checks, you must

			$src_x = 0;
		} else if ( $crop == 'right' ) {

Found "== '". Use Yoda Condition checks, you must

			$src_x = $src_w - $src_wt;
		}
		// Crop the image
		if ( $dest_ratio > $src_ratio ) {

This code seems to be duplicated across your project.

			return array(
				'x' => 0, 'y' => $src_y,
				'src_w' => $src_w, 'src_h' => $src_ht,
				'target_w' => $w, 'target_h' => $h

Each line in an array declaration must end in a comma

			);
		}
		return array(
			'x' => $src_x, 'y' => 0,
			'src_w' => $src_wt, 'src_h' => $src_h,
			'target_w' => $w, 'target_h' => $h

Each line in an array declaration must end in a comma

		);
	}

	/**
	 * Performs the actual image manipulation,
	 * including saving the target file.
	 *
	 * @param  string $load_filename filepath (not URL) to source file
	 *                               (ex: /src/var/www/wp-content/uploads/my-pic.jpg)
	 * @param  string $save_filename filepath (not URL) where result file should be saved
	 *                               (ex: /src/var/www/wp-content/uploads/my-pic-300x200-c-default.jpg)
	 * @return bool                  true if everything went fine, false otherwise

Should the return type not be boolean|null?

	 */
	public function run($load_filename, $save_filename) {
		//should be resized by gif resizer
		if ( TimberImageHelper::is_animated_gif($load_filename) ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			//attempt to resize
			//return if successful
			//proceed if not
			$gif = self::run_animated_gif($load_filename, $save_filename);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			if ($gif) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

				return true;
			}
		}
		$image = wp_get_image_editor( $load_filename );
		if ( !is_wp_error( $image ) ) {

Expected 1 space after "!"; 0 found

			$crop = self::get_target_sizes( $load_filename );
			$image->crop( 	$crop['x'],
							$crop['y'],

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 28.

							$crop['src_w'],

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 28.

							$crop['src_h'],

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 28.

							$crop['target_w'],

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 28.

							$crop['target_h']

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 28.

			);
			$result = $image->save( $save_filename );
			if ( is_wp_error( $result ) ) {

This code seems to be duplicated across your project.

				// @codeCoverageIgnoreStart
				TimberHelper::error_log( 'Error resizing image' );
				TimberHelper::error_log( $result );
				return false;
				// @codeCoverageIgnoreEnd
			} else {
				return true;
			}
		} else if ( isset( $image->error_data['error_loading_image'] ) ) {

This code seems to be duplicated across your project.

			// @codeCoverageIgnoreStart
			TimberHelper::error_log( 'Error loading ' . $image->error_data['error_loading_image'] );
		} else {
			TimberHelper::error_log( $image );
			// @codeCoverageIgnoreEnd
		}
	}
}