ACFTimber::__construct() - Code Metrics - jarednova/timber - Measure and Improve Code Quality continuously with Scrutinizer

ACFTimber::__construct() A
last analyzed 2016-03-13 16:42 UTC

↳ Parent: ACFTimber

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	8
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php

class ACFTimber {

    function __construct() {

        add_filter( 'timber_post_get_meta', array( $this, 'post_get_meta' ), 10, 2 );
        add_filter( 'timber_post_get_meta_field', array( $this, 'post_get_meta_field' ), 10, 3 );
        add_filter( 'timber_term_get_meta', array( $this, 'term_get_meta' ), 10, 3 );
        add_filter( 'timber_term_get_meta_field', array( $this, 'term_get_meta_field' ), 10, 4 );
        add_filter( 'timber_user_get_meta_field_pre', array( $this, 'user_get_meta_field' ), 10, 3 );
        add_filter( 'timber_term_set_meta', array( $this, 'term_set_meta'), 10, 4 );
    }

    function post_get_meta( $customs, $post_id ) {

        return $customs;
    }

    function post_get_meta_field( $value, $post_id, $field_name ) {

        return get_field( $field_name, $post_id );
    }

    function term_get_meta_field( $value, $term_id, $field_name, $term ) {

        $searcher = $term->taxonomy . "_" . $term->ID;
        return get_field( $field_name, $searcher );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    function term_set_meta( $value, $field, $term_id, $term ) {

        $searcher = $term->taxonomy . "_" . $term->ID;
        update_field( $field, $value, $searcher );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return $value;
    }

    function term_get_meta( $fields, $term_id, $term ) {

        $searcher = $term->taxonomy . "_" . $term->ID; // save to a specific category
        $fds = get_fields( $searcher );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ( is_array( $fds ) ) {
            foreach ( $fds as $key => $value ) {
                $key = preg_replace( '/_/', '', $key, 1 );
                $key = str_replace( $searcher, '', $key );
                $key = preg_replace( '/_/', '', $key, 1 );
                $field = get_field( $key, $searcher );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $fields[$key] = $field;
            }
            $fields = array_merge( $fields, $fds );
        }
        return $fields;
    }

    function user_get_meta( $fields, $user_id ) {

        return $fields;
    }

    function user_get_meta_field( $value, $uid, $field ) {

        return get_field( $field, 'user_' . $uid );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}




1			<?php
2
3			class ACFTimber {
4
5			function __construct() {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
6			add_filter( 'timber_post_get_meta', array( $this, 'post_get_meta' ), 10, 2 );
7			add_filter( 'timber_post_get_meta_field', array( $this, 'post_get_meta_field' ), 10, 3 );
8			add_filter( 'timber_term_get_meta', array( $this, 'term_get_meta' ), 10, 3 );
9			add_filter( 'timber_term_get_meta_field', array( $this, 'term_get_meta_field' ), 10, 4 );
10			add_filter( 'timber_user_get_meta_field_pre', array( $this, 'user_get_meta_field' ), 10, 3 );
11			add_filter( 'timber_term_set_meta', array( $this, 'term_set_meta'), 10, 4 );
12			}
13
14			function post_get_meta( $customs, $post_id ) {
			0 ignored issues – show Unused Code introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report The parameter `$post_id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
15			return $customs;
16			}
17
18			function post_get_meta_field( $value, $post_id, $field_name ) {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
19			return get_field( $field_name, $post_id );
20			}
21
22			function term_get_meta_field( $value, $term_id, $field_name, $term ) {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
23			$searcher = $term->taxonomy . "_" . $term->ID;
24			return get_field( $field_name, $searcher );
			0 ignored issues – show Documentation introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report `$searcher` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			}
26
27			function term_set_meta( $value, $field, $term_id, $term ) {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28			$searcher = $term->taxonomy . "_" . $term->ID;
29			update_field( $field, $value, $searcher );
			0 ignored issues – show Documentation introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report `$searcher` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			return $value;
31			}
32
33			function term_get_meta( $fields, $term_id, $term ) {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
34			$searcher = $term->taxonomy . "_" . $term->ID; // save to a specific category
35			$fds = get_fields( $searcher );
			0 ignored issues – show Documentation introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report `$searcher` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			if ( is_array( $fds ) ) {
37			foreach ( $fds as $key => $value ) {
38			$key = preg_replace( '/_/', '', $key, 1 );
39			$key = str_replace( $searcher, '', $key );
40			$key = preg_replace( '/_/', '', $key, 1 );
41			$field = get_field( $key, $searcher );
			0 ignored issues – show Documentation introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report `$searcher` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			$fields[$key] = $field;
43			}
44			$fields = array_merge( $fields, $fds );
45			}
46			return $fields;
47			}
48
49			function user_get_meta( $fields, $user_id ) {
			0 ignored issues – show Unused Code introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report The parameter `$user_id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
50			return $fields;
51			}
52
53			function user_get_meta_field( $value, $uid, $field ) {
			0 ignored issues – show Best Practice introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
54			return get_field( $field, 'user_' . $uid );
			0 ignored issues – show Documentation introduced 2015-11-23 18:11 UTC by Report Bug Copy Issue Report `'user_' . $uid` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			}
56			}
57
58
59

jarednova / timber

ACFTimber::__construct() A last analyzed 2016-03-13 16:42 UTC

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like

ACFTimber::__construct() A
last analyzed 2016-03-13 16:42 UTC