Completed
Push — master ( 0deb12...7308a5 )
by Jared
03:53 queued 01:30
created

JCRequest   A

Complexity

Total Complexity 12

Size/Duplication

Total Lines 86
Duplicated Lines 32.56 %

Coupling/Cohesion

Components 1
Dependencies 4

Test Coverage

Coverage 86.11%

Importance

Changes 0
Metric Value
wmc 12
lcom 1
cbo 4
dl 28
loc 86
ccs 31
cts 36
cp 0.8611
rs 10
c 0
b 0
f 0

8 Methods

Rating   Name   Duplication   Size   Complexity  
A post() 7 7 1
A put() 7 7 1
A patch() 7 7 1
A delete() 7 7 1
A request() 0 16 4
A get() 0 6 2
A head() 0 6 1
A manipulateUrl() 0 8 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Created by PhpStorm.
4
 * User: jaredchu
5
 * Date: 31/05/2017
6
 * Time: 09:40
7
 */
8
9
namespace JC;
10
11
12
use GuzzleHttp\Client;
13
use Purl\Url;
14
use JC\Enums\Method;
15
16
class JCRequest implements iJCRequest
17
{
18 7
    public static function request($method, $url, $options)
19
    {
20 7
        if (isset($options['params'])) {
21 5
            $params = $options['params'];
22 5
            unset($options['params']);
23
24 5
            if (is_array($params)) {
25 4
                $options['form_params'] = $params;
26
            }
27 5
            if (is_string($params)) {
28 1
                $options['json'] = json_decode($params);
29
            }
30
        }
31
32 7
        return new JCResponse((new Client())->request($method, $url, $options));
33
    }
34
35
    /**
36
     * @param $url
37
     * @param array $headers
38
     * @param array $params
39
     * @param array $options
40
     * @return JCResponse
41
     */
42 1
    public static function get($url, $params = null, $headers = [], $options = [])
43
    {
44 1
        return static::request(Method::GET, is_array($params) ? static::manipulateUrl($url, $params) : $url, [
45 1
            'headers' => $headers
46
        ]);
47
    }
48
49 2 View Code Duplication
    public static function post($url, $params = null, $headers = [], $options = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
50
    {
51 2
        return static::request(Method::POST, $url, [
52 2
            'headers' => $headers,
53 2
            'params' => $params
54
        ]);
55
    }
56
57 1 View Code Duplication
    public static function put($url, $params = null, $headers = [], $options = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
58
    {
59 1
        return static::request(Method::PUT, $url, [
60 1
            'headers' => $headers,
61 1
            'params' => $params
62
        ]);
63
    }
64
65 1 View Code Duplication
    public static function patch($url, $params = null, $headers = [], $options = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
66
    {
67 1
        return static::request(Method::PATCH, $url, [
68 1
            'headers' => $headers,
69 1
            'params' => $params
70
        ]);
71
    }
72
73 1 View Code Duplication
    public static function delete($url, $params = null, $headers = [], $options = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
74
    {
75 1
        return static::request(Method::DELETE, $url, [
76 1
            'headers' => $headers,
77 1
            'params' => $params
78
        ]);
79
    }
80
81 1
    public static function head($url, $params = null, $headers = [], $options = [])
82
    {
83 1
        return static::request(Method::HEAD, $url, [
84 1
            'headers' => $headers,
85
        ]);
86
    }
87
88
    /**
89
     * @param string $url
90
     * @param array $params
91
     * @return string
92
     */
93
    protected static function manipulateUrl($url, $params = [])
94
    {
95
        $urlObject = Url::parse($url);
96
        $queryData = array_merge($urlObject->query->getData(), $params);
97
        $urlObject->query->setData($queryData);
98
99
        return $urlObject->getUrl();
100
    }
101
}