OCA\Ocr\Service\GearmanWorkerService

Complexity

Total Complexity

9

Size/Duplication

Total Lines	59
Duplicated Lines	13.56 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

13.03%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	workerExists()	0	20	6
A	handleException()	8	8	2

<?php
/**
 * nextCloud - ocr
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Janis Koehr <janiskoehr@icloud.com>
 * @copyright Janis Koehr 2016
 */

namespace OCA\Ocr\Service;

use Exception;
use OCP\ILogger;

/**
 * Class GearmanWorkerService
 *
 * @package OCA\Ocr\Service
 */
class GearmanWorkerService {

	/**
	 * @var ILogger
	 */
	private $logger;

	/**
	 * GearmanWorkerService constructor.
	 *
	 * @param ILogger $logger
	 */
	public function __construct(ILogger $logger) {
		$this->logger = $logger;
	}

	/**
	 * Checks if a worker is active and registered at the Gearman Job Server.
	 * returns false if not.
	 * @return bool
	 */
	public function workerExists(){
		try {
			$checkCommand = 'gearadmin -h 127.0.0.1 -p 4730 --workers 2>&1';
			exec($checkCommand, $result, $success);
			if ($success !== 0 && count($result) > 0) {
				throw new NotFoundException('Gearman worker detection failed.');
			}
			// look into the resulting array. 3 because first row is the ps checking command, second row is the grep command separated from the ps and 3rd or more has to be the GearmanOCRWorker.php.
			foreach ($result as $res){

The expression $result of type null|array is not guaranteed to be traversable. How about adding an additional type check?

				if(strpos($res, 'ocr') !== false){
					$this->logger->debug('Worker found.', ['app' => 'ocr']);
					return true;
				}
			}
			$this->logger->debug('No worker found.', ['app' => 'ocr']);
			return false;
		} catch (Exception $e){
			$this->handleException($e);
		}
	}

	/**
	 * Handle the possible thrown Exceptions from all methods of this class.
	 *
	 * @param Exception $e
	 * @throws Exception
	 * @throws NotFoundException
	 */
	private function handleException($e) {

This method seems to be duplicated in your project.

		$this->logger->logException($e, ['app' => 'ocr', 'message' => 'Exception during gearman worker service function processing']);
		if ($e instanceof NotFoundException) {
			throw new NotFoundException($e->getMessage());
		} else {
			throw $e;
		}
	}

}