janis91 / ocr

lib/Service/JobService.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use OCP\IL10N;
 use OCP\ITempManager;
 use OCA\Ocr\Db\OcrJob;
-use OCA\Ocr\Db\File;
 
 /**
  * Class JobService

Spacing +78 added lines, -78 removed lines

@@ -106,44 +106,44 @@ 
 	 */
 	public function process($languages, $files) {
 		try {
-			$this->logger->debug ( 'Will now process files: ' . json_encode ( $files ) . ' with languages: ' . json_encode ( $languages ), [ 
+			$this->logger->debug('Will now process files: ' . json_encode($files) . ' with languages: ' . json_encode($languages), [ 
 					'app' => 'ocr' 
-			] );
+			]);
 			// Check if files and language not empty
-			$noLang = $this->noLanguage ( $languages );
-			if (! empty ( $files ) && ($this->checkForAcceptedLanguages ( $languages ) || $noLang)) {
+			$noLang = $this->noLanguage($languages);
+			if (!empty ($files) && ($this->checkForAcceptedLanguages($languages) || $noLang)) {
 				// language part:
 				if ($noLang) {
 					$languages = [];
 				}
 				// file part:
-				$fileInfo = $this->fileService->buildFileInfo ( $files );
-				foreach ( $fileInfo as $fInfo ) {
+				$fileInfo = $this->fileService->buildFileInfo($files);
+				foreach ($fileInfo as $fInfo) {
 					// Check Shared
-					$shared = $this->fileService->checkSharedWithInitiator ( $fInfo );
-					$target = $this->fileService->buildTarget ( $fInfo, $shared );
-					$source = $this->fileService->buildSource ( $fInfo, $shared );
+					$shared = $this->fileService->checkSharedWithInitiator($fInfo);
+					$target = $this->fileService->buildTarget($fInfo, $shared);
+					$source = $this->fileService->buildSource($fInfo, $shared);
 					
 					// create a temp file for ocr processing purposes
-					$tempFile = $this->tempM->getTemporaryFile ();
+					$tempFile = $this->tempM->getTemporaryFile();
 					
 					// set the running type
-					$fType = $this->fileService->getCorrectType ( $fInfo );
+					$fType = $this->fileService->getCorrectType($fInfo);
 					
 					// TODO: create a security token
 					// Create job object
-					$job = new OcrJob ( 'PENDING', $source, $target, $tempFile, $fType, $this->userId, false, $fInfo->getName(), null );
+					$job = new OcrJob('PENDING', $source, $target, $tempFile, $fType, $this->userId, false, $fInfo->getName(), null);
 					
 					// Init client and send task / job
 					// Feed the worker
-					$this->queueService->sendJob ( $job, $languages, \OC::$SERVERROOT );
+					$this->queueService->sendJob($job, $languages, \OC::$SERVERROOT);
 				}
 				return 'PROCESSING';
 			} else {
-				throw new NotFoundException ( $this->l10n->t ( 'Empty parameters passed.' ) );
+				throw new NotFoundException($this->l10n->t('Empty parameters passed.'));
 			}
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -157,20 +157,20 @@ 
 	 */
 	public function deleteJob($jobId, $userId) {
 		try {
-			$job = $this->jobMapper->find ( $jobId );
-			if ($job->getUserId () !== $userId) {
-				throw new NotFoundException ( $this->l10n->t ( 'Cannot delete. Wrong owner.' ) );
+			$job = $this->jobMapper->find($jobId);
+			if ($job->getUserId() !== $userId) {
+				throw new NotFoundException($this->l10n->t('Cannot delete. Wrong owner.'));
 			} else {
-				$job = $this->jobMapper->delete ( $job );
+				$job = $this->jobMapper->delete($job);
 			}
 			// TODO: return sanitized job for the personal settings page (no information about the source and target and such things.
 			return $job;
-		} catch ( Exception $e ) {
+		} catch (Exception $e) {
 			if ($e instanceof DoesNotExistException) {
-				$ex = new NotFoundException ( $this->l10n->t ( 'Cannot delete. Wrong ID.' ) );
-				$this->handleException ( $ex );
+				$ex = new NotFoundException($this->l10n->t('Cannot delete. Wrong ID.'));
+				$this->handleException($ex);
 			} else {
-				$this->handleException ( $e );
+				$this->handleException($e);
 			}
 		}
 	}
@@ -184,20 +184,20 @@ 
 	 */
 	public function getAllJobsForUser($userId) {
 		try {
-			$jobs = $this->jobMapper->findAll ( $userId );
-			$jobsNew = array ();
-			for($x = 0; $x < count ( $jobs ); $x ++) {
-				$newName = $this->fileService->removeFileExtension ( $jobs [$x] );
-				$jobs [$x]->setTarget ( $newName );
-				$jobs [$x]->setSource ( null );
-				$jobs [$x]->setTempFile ( null );
-				$jobs [$x]->setType ( null );
-				$jobs [$x]->setErrorDisplayed ( null );
-				array_push ( $jobsNew, $jobs [$x] );
+			$jobs = $this->jobMapper->findAll($userId);
+			$jobsNew = array();
+			for ($x = 0; $x < count($jobs); $x++) {
+				$newName = $this->fileService->removeFileExtension($jobs [$x]);
+				$jobs [$x]->setTarget($newName);
+				$jobs [$x]->setSource(null);
+				$jobs [$x]->setTempFile(null);
+				$jobs [$x]->setType(null);
+				$jobs [$x]->setErrorDisplayed(null);
+				array_push($jobsNew, $jobs [$x]);
 			}
 			return $jobsNew;
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -212,20 +212,20 @@ 
 	 */
 	public function jobFinished($jobId, $failed, $errorMessage) {
 		try {
-			$job = $this->jobMapper->find ( $jobId );
-			if (! $failed) {
-				$job->setStatus ( 'PROCESSED' );
-				$this->jobMapper->update ( $job );
+			$job = $this->jobMapper->find($jobId);
+			if (!$failed) {
+				$job->setStatus('PROCESSED');
+				$this->jobMapper->update($job);
 			} else {
-				$job->setStatus ( 'FAILED' );
+				$job->setStatus('FAILED');
 				// TODO: add error message log and so on
-				$this->jobMapper->update ( $job );
-				$this->logger->error ( $errorMessage, [ 
+				$this->jobMapper->update($job);
+				$this->logger->error($errorMessage, [ 
 						'app' => 'ocr' 
-				] );
+				]);
 			}
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -238,31 +238,31 @@ 
 	 */
 	public function handleProcessed() {
 		try {
-			$this->logger->debug ( 'Check if files were processed by ocr and if so, put them to the right dirs.', [ 
+			$this->logger->debug('Check if files were processed by ocr and if so, put them to the right dirs.', [ 
 					'app' => 'ocr' 
-			] );
-			$processed = $this->jobMapper->findAllProcessed ( $this->userId );
-			foreach ( $processed as $job ) {
-				if ($job->getType () === 'tess' && $this->fileService->fileExists ( $job->getTempFile () . '.txt' )) {
+			]);
+			$processed = $this->jobMapper->findAllProcessed($this->userId);
+			foreach ($processed as $job) {
+				if ($job->getType() === 'tess' && $this->fileService->fileExists($job->getTempFile() . '.txt')) {
 					// Save the tmp file with newname
-					$this->view->file_put_contents ( $job->getTarget (), $this->fileService->getFileContents ( $job->getTempFile () . '.txt' ) ); // need .txt because tesseract saves it like this
+					$this->view->file_put_contents($job->getTarget(), $this->fileService->getFileContents($job->getTempFile() . '.txt')); // need .txt because tesseract saves it like this
 					                                                                                                                              // Cleaning temp files
-					$this->jobMapper->delete ( $job );
-					$this->fileService->execRemove ( $job->getTempFile () . '.txt' );
-				} elseif ($job->getType () === 'mypdf' && $this->fileService->fileExists ( $job->getTempFile () )) {
+					$this->jobMapper->delete($job);
+					$this->fileService->execRemove($job->getTempFile() . '.txt');
+				} elseif ($job->getType() === 'mypdf' && $this->fileService->fileExists($job->getTempFile())) {
 					// Save the tmp file with newname
-					$this->view->file_put_contents ( $job->getTarget (), $this->fileService->getFileContents ( $job->getTempFile () ) ); // don't need to extend with .pdf / it uses the tmp file to save
-					$this->jobMapper->delete ( $job );
-					$this->fileService->execRemove ( $job->getTempFile () );
+					$this->view->file_put_contents($job->getTarget(), $this->fileService->getFileContents($job->getTempFile())); // don't need to extend with .pdf / it uses the tmp file to save
+					$this->jobMapper->delete($job);
+					$this->fileService->execRemove($job->getTempFile());
 				} else {
-					$job->setStatus ( 'FAILED' );
-					$this->jobMapper->update ( $job );
-					throw new NotFoundException ( $this->l10n->t ( 'Temp file does not exist.' ) );
+					$job->setStatus('FAILED');
+					$this->jobMapper->update($job);
+					throw new NotFoundException($this->l10n->t('Temp file does not exist.'));
 				}
 			}
 			return $processed;
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -273,20 +273,20 @@ 
 	 */
 	public function handleFailed() {
 		try {
-			$failed = $this->jobMapper->findAllFailed ( $this->userId );
-			foreach ( $failed as $job ) {
+			$failed = $this->jobMapper->findAllFailed($this->userId);
+			foreach ($failed as $job) {
 				// clean the tempfile
-				$this->fileService->execRemove ( $job->getTempFile () );
+				$this->fileService->execRemove($job->getTempFile());
 				// set error displayed
-				$job->setErrorDisplayed ( true );
-				$this->jobMapper->update ( $job );
+				$job->setErrorDisplayed(true);
+				$this->jobMapper->update($job);
 			}
-			$this->logger->debug ( 'Following jobs failed: ' . json_encode ( $failed ), [ 
+			$this->logger->debug('Following jobs failed: ' . json_encode($failed), [ 
 					'app' => 'ocr' 
-			] );
+			]);
 			return $failed;
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -298,10 +298,10 @@ 
 	 * @return boolean
 	 */
 	private function checkForAcceptedLanguages($languages) {
-		if (count ( array_diff ( $languages, [ 
+		if (count(array_diff($languages, [ 
 				'deu',
 				'eng' 
-		] ) ) === 0) {
+		])) === 0) {
 			return true;
 		} else {
 			return false;
@@ -315,7 +315,7 @@ 
 	 * @return boolean
 	 */
 	private function noLanguage($languages) {
-		if (in_array ( 'none', $languages )) {
+		if (in_array('none', $languages)) {
 			return true;
 		} else {
 			return false;
@@ -330,12 +330,12 @@ 
 	 * @throws NotFoundException
 	 */
 	private function handleException($e) {
-		$this->logger->logException ( $e, [ 
+		$this->logger->logException($e, [ 
 				'app' => 'ocr',
 				'message' => 'Exception during job service function processing' 
-		] );
+		]);
 		if ($e instanceof NotFoundException) {
-			throw new NotFoundException ( $e->getMessage () );
+			throw new NotFoundException($e->getMessage());
 		} else {
 			throw $e;
 		}

lib/Controller/JobController.php

Spacing +9 added lines, -9 removed lines

@@ -47,7 +47,7 @@ 
 	 *        	$UserId
 	 */
 	public function __construct($AppName, IRequest $request, JobService $service, $UserId) {
-		parent::__construct ( $AppName, $request );
+		parent::__construct($AppName, $request);
 		$this->userId = $UserId;
 		$this->service = $service;
 	}
@@ -62,8 +62,8 @@ 
 	 * @return DataResponse
 	 */
 	public function process($languages, $files) {
-		return $this->handleNotFound ( function () use ($languages, $files) {
-			return $this->service->process ( $languages, $files );
+		return $this->handleNotFound(function() use ($languages, $files) {
+			return $this->service->process($languages, $files);
 		} );
 	}
 	
@@ -73,8 +73,8 @@ 
 	 * @return \OCP\AppFramework\Http\DataResponse
 	 */
 	public function getAllJobs() {
-		return $this->handleNotFound ( function () {
-			return $this->service->getAllJobsForUser ( $this->userId );
+		return $this->handleNotFound(function() {
+			return $this->service->getAllJobsForUser($this->userId);
 		} );
 	}
 	
@@ -85,8 +85,8 @@ 
 	 * @return \OCP\AppFramework\Http\DataResponse
 	 */
 	public function deleteJob($id) {
-		return $this->handleNotFound ( function () use ($id) {
-			return $this->service->deleteJob ( $id, $this->userId );
+		return $this->handleNotFound(function() use ($id) {
+			return $this->service->deleteJob($id, $this->userId);
 		} );
 	}
 	
@@ -101,8 +101,8 @@ 
 	 * @return \OCP\AppFramework\Http\DataResponse
 	 */
 	public function finish($id, $failed, $error) {
-		return $this->handleNotFound ( function () use ($id, $failed, $error) {
-			return $this->service->jobFinished ( $id, $failed, $error );
+		return $this->handleNotFound(function() use ($id, $failed, $error) {
+			return $this->service->jobFinished($id, $failed, $error);
 		} );
 	}
 }
\ No newline at end of file

lib/Service/StatusService.php

Spacing +13 added lines, -13 removed lines

@@ -82,23 +82,23 @@ 
 		try {
 			// TODO: release lock
 			// returns user specific processed files
-			$processed = $this->jobMapper->findAllProcessed ( $this->userId );
-			$this->jobService->handleProcessed ();
+			$processed = $this->jobMapper->findAllProcessed($this->userId);
+			$this->jobService->handleProcessed();
 			
 			// return user specific pending state
-			$pending = $this->jobMapper->findAllPending ( $this->userId );
+			$pending = $this->jobMapper->findAllPending($this->userId);
 			
 			// return user specific failed state and set up error
-			$failed = $this->jobMapper->findAllFailed ( $this->userId );
-			$this->jobService->handleFailed ();
+			$failed = $this->jobMapper->findAllFailed($this->userId);
+			$this->jobService->handleFailed();
 			
 			return [ 
-					'processed' => count ( $processed ),
-					'failed' => count ( $failed ),
-					'pending' => count ( $pending ) 
+					'processed' => count($processed),
+					'failed' => count($failed),
+					'pending' => count($pending) 
 			];
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -110,12 +110,12 @@ 
 	 * @throws NotFoundException
 	 */
 	private function handleException($e) {
-		$this->logger->logException ( $e, [ 
+		$this->logger->logException($e, [ 
 				'app' => 'ocr',
 				'message' => 'Exception during status service function processing' 
-		] );
+		]);
 		if ($e instanceof NotFoundException) {
-			throw new NotFoundException ( $e->getMessage () );
+			throw new NotFoundException($e->getMessage());
 		} else {
 			throw $e;
 		}

lib/Service/FileService.php

Spacing +52 added lines, -52 removed lines

@@ -104,7 +104,7 @@ 
 	 */
 	public function checkSharedWithInitiator($fileInfo) {
 		try {
-			$owner = str_replace ( 'home::', '', $fileInfo->getStoragename () );
+			$owner = str_replace('home::', '', $fileInfo->getStoragename());
 			if ($this->userId === $owner) {
 				// user is owner (no shared file)
 				return false;
@@ -112,8 +112,8 @@ 
 				// user is not owner (shared file)
 				return true;
 			}
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -126,9 +126,9 @@ 
 	 */
 	public function buildTarget($fileInfo, $shared) {
 		if ($shared) {
-			$target = $this->buildTargetForShared ( $fileInfo );
+			$target = $this->buildTargetForShared($fileInfo);
 		} else {
-			$target = $this->buildTargetNotForShared ( $fileInfo );
+			$target = $this->buildTargetNotForShared($fileInfo);
 		}
 		return $target;
 	}
@@ -141,9 +141,9 @@ 
 	 * @return string
 	 */
 	public function buildSource($fileInfo, $shared) {
-		$source = $fileInfo->getPath ();
+		$source = $fileInfo->getPath();
 		if ($shared) {
-			$source = str_replace ( 'home::', '', $fileInfo->getStoragename () ) . '/' . $source;
+			$source = str_replace('home::', '', $fileInfo->getStoragename()) . '/' . $source;
 		} else {
 			$source = $this->userId . '/' . $source;
 		}
@@ -160,22 +160,22 @@ 
 	 */
 	public function buildFileInfo($files) {
 		try {
-			$fileArray = array ();
-			foreach ( $files as $file ) {
+			$fileArray = array();
+			foreach ($files as $file) {
 				// Check if anything is missing and file type is correct
-				if (! empty ( $file ['id'] )) {
+				if (!empty ($file ['id'])) {
 					
-					$fileInfo = $this->fileMapper->find ( $file ['id'] );
-					$this->checkMimeType ( $fileInfo );
+					$fileInfo = $this->fileMapper->find($file ['id']);
+					$this->checkMimeType($fileInfo);
 					
-					array_push ( $fileArray, $fileInfo );
+					array_push($fileArray, $fileInfo);
 				} else {
-					throw new NotFoundException ( $this->l10n->t ( 'Wrong parameter.' ) );
+					throw new NotFoundException($this->l10n->t('Wrong parameter.'));
 				}
 			}
 			return $fileArray;
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -186,7 +186,7 @@ 
 	 * @return string
 	 */
 	public function removeFileExtension($job) {
-		return substr ( $job->getTarget (), 0, strrpos ( $job->getTarget (), '_OCR' ) );
+		return substr($job->getTarget(), 0, strrpos($job->getTarget(), '_OCR'));
 	}
 	
 	/**
@@ -197,7 +197,7 @@ 
 	 * @return string
 	 */
 	public function getCorrectType($fileInfo) {
-		if ($fileInfo->getMimetype () === FileService::$MIMETYPE_PDF) {
+		if ($fileInfo->getMimetype() === FileService::$MIMETYPE_PDF) {
 			return 'mypdf';
 		} else {
 			return 'tess';
@@ -212,7 +212,7 @@ 
 	 * @param string $pathToFile        	
 	 */
 	public function execRemove($pathToFile) {
-		exec ( 'rm ' . $pathToFile );
+		exec('rm ' . $pathToFile);
 	}
 	
 	/**
@@ -224,7 +224,7 @@ 
 	 * @return string
 	 */
 	public function getFileContents($pathToFile) {
-		return file_get_contents ( $pathToFile );
+		return file_get_contents($pathToFile);
 	}
 	
 	/**
@@ -236,7 +236,7 @@ 
 	 * @return boolean
 	 */
 	public function fileExists($pathToFile) {
-		return file_exists ( $pathToFile );
+		return file_exists($pathToFile);
 	}
 	
 	/**
@@ -251,32 +251,32 @@ 
 	 */
 	protected function buildTargetForShared(File $fileInfo) {
 		try {
-			$share = $this->shareMapper->find ( $fileInfo->getFileid (), $this->userId, str_replace ( 'home::', '', $fileInfo->getStoragename () ) );
+			$share = $this->shareMapper->find($fileInfo->getFileid(), $this->userId, str_replace('home::', '', $fileInfo->getStoragename()));
 			
 			// get rid of the .png or .pdf and so on
-			$fileName = substr ( $share->getFileTarget (), 0, (strrpos ( $share->getFileTarget (), '.' )) ); // '/thedom.png' => '/thedom' || '/Test/thedom.png' => '/Test/thedom'
+			$fileName = substr($share->getFileTarget(), 0, (strrpos($share->getFileTarget(), '.'))); // '/thedom.png' => '/thedom' || '/Test/thedom.png' => '/Test/thedom'
 			                                                                                                 
 			// remove everything in front of and including of the first appearance of a slash from behind
-			$fileName = substr ( strrchr ( $fileName, "/" ), 1 ); // '/thedom' => 'thedom' || '/Test/thedom' => 'thedom'
+			$fileName = substr(strrchr($fileName, "/"), 1); // '/thedom' => 'thedom' || '/Test/thedom' => 'thedom'
 			                                                      
 			// eliminate the file name from the path
-			$filePath = dirname ( $share->getFileTarget () ); // '/thedom.png' => '/' || '/Test/thedom.png' => '/Test'
+			$filePath = dirname($share->getFileTarget()); // '/thedom.png' => '/' || '/Test/thedom.png' => '/Test'
 			                                                  
 			// replace the first slash
-			$pos = strpos ( $filePath, '/' );
+			$pos = strpos($filePath, '/');
 			if ($pos !== false) {
-				$filePath = substr_replace ( $filePath, '', $pos, strlen ( '/' ) ); // '/' => '' || '/Test/' => 'Test'
+				$filePath = substr_replace($filePath, '', $pos, strlen('/')); // '/' => '' || '/Test/' => 'Test'
 			}
 			
-			if ($fileInfo->getMimetype () === FileService::$MIMETYPE_PDF) {
+			if ($fileInfo->getMimetype() === FileService::$MIMETYPE_PDF) {
 				// PDFs:
-				return \OCP\Files::buildNotExistingFileName ( $filePath, $fileName . '_OCR.pdf' );
+				return \OCP\Files::buildNotExistingFileName($filePath, $fileName . '_OCR.pdf');
 			} else {
 				// IMAGES:
-				return \OCP\Files::buildNotExistingFileName ( $filePath, $fileName . '_OCR.txt' );
+				return \OCP\Files::buildNotExistingFileName($filePath, $fileName . '_OCR.txt');
 			}
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -293,32 +293,32 @@ 
 	protected function buildTargetNotForShared(File $fileInfo) {
 		try {
 			// get rid of the .png or .pdf and so on
-			$fileName = substr ( $fileInfo->getName (), 0, (strrpos ( $fileInfo->getName (), '.' )) ); // 'thedom.png' => 'thedom'
+			$fileName = substr($fileInfo->getName(), 0, (strrpos($fileInfo->getName(), '.'))); // 'thedom.png' => 'thedom'
 			                                                                                           
 			// eliminate the file name from the path
-			$filePath = str_replace ( $fileInfo->getName (), '', $fileInfo->getPath () ); // 'files/Test/thedom.png' => 'files/Test/' || 'files/thedom.png' => 'files/'
+			$filePath = str_replace($fileInfo->getName(), '', $fileInfo->getPath()); // 'files/Test/thedom.png' => 'files/Test/' || 'files/thedom.png' => 'files/'
 			                                                                              
 			// and get the path on top of the files/ dir
-			$filePath = str_replace ( 'files', '', $filePath ); // 'files/Test/' => '/Test/' || 'files/' => '/'
+			$filePath = str_replace('files', '', $filePath); // 'files/Test/' => '/Test/' || 'files/' => '/'
 			                                                    
 			// remove the last slash
-			$filePath = substr_replace ( $filePath, '', strrpos ( $filePath, '/' ), strlen ( '/' ) ); // '/Test/' => '/Test' || '/' => ''
+			$filePath = substr_replace($filePath, '', strrpos($filePath, '/'), strlen('/')); // '/Test/' => '/Test' || '/' => ''
 			                                                                                          
 			// replace the first slash
-			$pos = strpos ( $filePath, '/' );
+			$pos = strpos($filePath, '/');
 			if ($pos !== false) {
-				$filePath = substr_replace ( $filePath, '', $pos, strlen ( '/' ) ); // '/Test' => '// 'Test' || '/' => ''
+				$filePath = substr_replace($filePath, '', $pos, strlen('/')); // '/Test' => '// 'Test' || '/' => ''
 			}
 			
-			if ($fileInfo->getMimetype () === FileService::$MIMETYPE_PDF) {
+			if ($fileInfo->getMimetype() === FileService::$MIMETYPE_PDF) {
 				// PDFs:
-				return \OCP\Files::buildNotExistingFileName ( $filePath, $fileName . '_OCR.pdf' );
+				return \OCP\Files::buildNotExistingFileName($filePath, $fileName . '_OCR.pdf');
 			} else {
 				// IMAGES:
-				return \OCP\Files::buildNotExistingFileName ( $filePath, $fileName . '_OCR.txt' );
+				return \OCP\Files::buildNotExistingFileName($filePath, $fileName . '_OCR.txt');
 			}
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -329,14 +329,14 @@ 
 	 */
 	private function checkMimeType(File $fileInfo) {
 		try {
-			if (! $fileInfo || ! in_array ( $fileInfo->getMimetype (), FileService::$ALLOWED_MIMETYPES )) {
-				$this->logger->debug ( 'Getting FileInfo did not work or not included in the ALLOWED_MIMETYPES array.', [ 
+			if (!$fileInfo || !in_array($fileInfo->getMimetype(), FileService::$ALLOWED_MIMETYPES)) {
+				$this->logger->debug('Getting FileInfo did not work or not included in the ALLOWED_MIMETYPES array.', [ 
 						'app' => 'ocr' 
-				] );
-				throw new NotFoundException ( $this->l10n->t ( 'Wrong MIME type.' ) );
+				]);
+				throw new NotFoundException($this->l10n->t('Wrong MIME type.'));
 			}
-		} catch ( Exception $e ) {
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			$this->handleException($e);
 		}
 	}
 	
@@ -348,12 +348,12 @@ 
 	 * @throws NotFoundException
 	 */
 	private function handleException($e) {
-		$this->logger->logException ( $e, [ 
+		$this->logger->logException($e, [ 
 				'app' => 'ocr',
 				'message' => 'Exception during file service function processing' 
-		] );
+		]);
 		if ($e instanceof NotFoundException) {
-			throw new NotFoundException ( $e->getMessage () );
+			throw new NotFoundException($e->getMessage());
 		} else {
 			throw $e;
 		}

lib/Settings/Section.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 	 *
 	 */
 	public function getName() {
-		return $this->l->t ( 'OCR' );
+		return $this->l->t('OCR');
 	}
 	/**
 	 *

lib/Settings/Admin.php

Spacing +3 added lines, -3 removed lines

@@ -31,9 +31,9 @@
 	 * @return TemplateResponse
 	 */
 	public function getForm() {
-		return new TemplateResponse( 'ocr', 'settings-admin', [ 
-				'languages' => $this->config->getAppValue ( 'ocr', 'languages' ) 
-		], 'blank' );
+		return new TemplateResponse('ocr', 'settings-admin', [ 
+				'languages' => $this->config->getAppValue('ocr', 'languages') 
+		], 'blank');
 	}
 	/**
 	 *

lib/Service/AppConfigService.php

Spacing +4 added lines, -4 removed lines

@@ -51,7 +51,7 @@ 
 	 * @return string
 	 */
 	public function getAppValue($key) {
-		return $this->config->getAppValue ( $this->appName, $key );
+		return $this->config->getAppValue($this->appName, $key);
 	}
 	/**
 	 * Set a value by key
@@ -62,10 +62,10 @@ 
 	 */
 	public function setAppValue($key, $value) {
 		if ($key === 'languages') {
-			if (! preg_match ( '/^(([a-z]{3,4}|[a-z]{3,4}\-[a-z]{3,4});)*([a-z]{3,4}|[a-z]{3,4}\-[a-z]{3,4})$/', $value )) {
-				throw new NotFoundException ( $this->l10n->t ( 'The languages are not specified in the correct format.' ) );
+			if (!preg_match('/^(([a-z]{3,4}|[a-z]{3,4}\-[a-z]{3,4});)*([a-z]{3,4}|[a-z]{3,4}\-[a-z]{3,4})$/', $value)) {
+				throw new NotFoundException($this->l10n->t('The languages are not specified in the correct format.'));
 			}
 		}
-		return $this->config->setAppValue ( $this->appName, $key, $value );
+		return $this->config->setAppValue($this->appName, $key, $value);
 	}
 }
\ No newline at end of file

lib/Controller/AdminSettingsController.php

Spacing +7 added lines, -7 removed lines

@@ -39,7 +39,7 @@ 
 	 * @param string $userId        	
 	 */
 	public function __construct($appName, IRequest $request, IL10N $l10n, AppConfigService $appConfig, $userId) {
-		parent::__construct ( $appName, $request );
+		parent::__construct($appName, $request);
 		$this->l10n = $l10n;
 		$this->appConfig = $appConfig;
 	}
@@ -50,8 +50,8 @@ 
 	 * @return DataResponse
 	 */
 	public function getSettings() {
-		return $this->handleNotFound ( function () {
-			return [ 'languages' => $this->appConfig->getAppValue ( 'languages' )];
+		return $this->handleNotFound(function() {
+			return ['languages' => $this->appConfig->getAppValue('languages')];
 		} );
 	}
 	
@@ -62,12 +62,12 @@ 
 	 * @return DataResponse
 	 */
 	public function setSettings($languages) {
-		return $this->handleNotFound ( function () use ($languages) {
+		return $this->handleNotFound(function() use ($languages) {
 			if ($languages !== null) {
-				$this->appConfig->setAppValue ( 'languages', $languages );
-				return $this->l10n->t ( 'Saved' );
+				$this->appConfig->setAppValue('languages', $languages);
+				return $this->l10n->t('Saved');
 			} else {
-				throw new NotFoundException ( $this->l10n->t ( 'The languages are not specified in the correct format.' ) );
+				throw new NotFoundException($this->l10n->t('The languages are not specified in the correct format.'));
 			}
 		} );
 	}

lib/Service/RedisService.php

Spacing +23 added lines, -23 removed lines

@@ -88,35 +88,35 @@ 
 	public function sendJob($job, $languages, $occDir) {
 		try {
 			// check for messaging and put everything together
-			if (!extension_loaded ( 'redis' )) {
-				$this->logger->debug ( 'It seems that the message queueing capabilities are not available in your local php installation. Please install php-redis.', [
+			if (!extension_loaded('redis')) {
+				$this->logger->debug('It seems that the message queueing capabilities are not available in your local php installation. Please install php-redis.', [
 						'app' => 'ocr'
-				] );
+				]);
 				throw new NotFoundException($this->l10n->t('Message queueing capabilities are missing on the server.'));
 			}
 			// TODO: adjust mapping according to zettel
-			$job = $this->mapper->insert ( $job );
-			$msg = json_encode ( array (
-					'type' => $job->getType (),
-					'source' => $this->config->getSystemValue ( 'datadirectory' ) . '/' . $job->getSource (),
-					'tempfile' => $job->getTempFile (),
+			$job = $this->mapper->insert($job);
+			$msg = json_encode(array(
+					'type' => $job->getType(),
+					'source' => $this->config->getSystemValue('datadirectory') . '/' . $job->getSource(),
+					'tempfile' => $job->getTempFile(),
 					'languages' => $languages,
-					'jobid' => $job->getId (),
+					'jobid' => $job->getId(),
 					'occdir' => $occDir 
-			) );
-			if (msg_send ( $this->queue, 1, $msg )) {
-				$this->logger->debug ( 'Client message: ' . $msg, [ 
+			));
+			if (msg_send($this->queue, 1, $msg)) {
+				$this->logger->debug('Client message: ' . $msg, [ 
 						'app' => 'ocr' 
-				] );
+				]);
 			} else {
-				$this->mapper->delete ( $job );
-				throw new NotFoundException ( $this->l10n->t ( 'Could not add files to the OCR processing queue.' ) );
+				$this->mapper->delete($job);
+				throw new NotFoundException($this->l10n->t('Could not add files to the OCR processing queue.'));
 			}
-		} catch ( Exception $e ) {
-			exec ( 'rm ' . $job->getTempFile () );
-			$job->setStatus ( 'FAILED' );
-			$this->mapper->update ( $job );
-			$this->handleException ( $e );
+		} catch (Exception $e) {
+			exec('rm ' . $job->getTempFile());
+			$job->setStatus('FAILED');
+			$this->mapper->update($job);
+			$this->handleException($e);
 		}
 	}
 	
@@ -130,12 +130,12 @@ 
 	 * @throws NotFoundException
 	 */
 	private function handleException($e) {
-		$this->logger->logException ( $e, [ 
+		$this->logger->logException($e, [ 
 				'app' => 'ocr',
 				'message' => 'Exception during message queue processing' 
-		] );
+		]);
 		if ($e instanceof NotFoundException) {
-			throw new NotFoundException ( $e->getMessage () );
+			throw new NotFoundException($e->getMessage());
 		} else {
 			throw $e;
 		}