JobService::checkForFinishedJobs() - Code Metrics - Inspection of "68: Refactored the worker to docker and redis envi..." - janis91/ocr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#93)

by Janis

created 2017-07-02 20:43 UTC

JobService::checkForFinishedJobs() A

↳ Parent: JobService

Complexity

Conditions	3
Paths	7

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	15
ccs	10
cts	10
cp	1
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	10
nc	7
nop	0
crap	3

<?php

/**
 * Nextcloud - OCR
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING file.
 * 
 * @author Janis Koehr <[email protected]>
 * @copyright Janis Koehr 2017
 */
namespace OCA\Ocr\Service;

use OCA\Ocr\Db\OcrJobMapper;
use OC\Files\View;
use OCP\ILogger;
use OCP\IL10N;
use OCP\ITempManager;
use OCA\Ocr\Db\OcrJob;
use OCA\Ocr\Constants\OcrConstants;
use OCA\Ocr\Util\PHPUtil;
use Exception;
use OCP\AppFramework\Db\DoesNotExistException;
use OCA\Ocr\Util\FileUtil;


/**
 * Class JobService
 * 
 * @package OCA\Ocr\Service
 */
class JobService {

    /**
     *
     * @var ILogger
     */
    private $logger;

    /**
     *
     * @var RedisService
     */
    private $redisService;

    /**
     *
     * @var OcrJobMapper
     */
    private $jobMapper;

    /**
     *
     * @var View
     */
    private $view;

    /**
     *
     * @var String
     */
    private $userId;

    /**
     *
     * @var IL10N
     */
    private $l10n;

    /**
     *
     * @var FileService
     */
    private $fileService;

    /**
     *
     * @var ITempManager
     */
    private $tempM;

    /**
     *
     * @var AppConfigService
     */
    private $appConfigService;

    /**
     *
     * @var PHPUtil
     */
    private $phpUtil;

    /**
     *
     * @var FileUtil
     */
    private $fileUtil;

    /**
     * JobService constructor.
     * 
     * @param IL10N $l10n            
     * @param ILogger $logger            
     * @param string $userId            
     * @param View $view            
     * @param RedisService $queueService            
     * @param OcrJobMapper $mapper            
     * @param FileService $fileService            
     * @param AppConfigService $appConfigService            
     * @param PHPUtil $phpUtil            
     * @param FileUtil $fileUtil            
     */
    public function __construct(IL10N $l10n, ILogger $logger, $userId, View $view, ITempManager $tempManager, 
            RedisService $queueService, OcrJobMapper $mapper, FileService $fileService, 
            AppConfigService $appConfigService, PHPUtil $phpUtil, FileUtil $fileUtil) {
        $this->logger = $logger;
        $this->redisService = $queueService;
        $this->jobMapper = $mapper;
        $this->view = $view;
        $this->userId = $userId;
        $this->l10n = $l10n;
        $this->fileService = $fileService;
        $this->tempM = $tempManager;
        $this->appConfigService = $appConfigService;
        $this->phpUtil = $phpUtil;
        $this->fileUtil = $fileUtil;
    }

    /**
     * Processes and prepares the files for OCR.
     * Sends the stuff to the client in order to OCR async.
     * 
     * @param string[] $languages            
     * @param array $files            
     * @return string
     */
    public function process($languages, $files) {
        try {
            $this->logger->debug('Will now process files: {files} with languages: {languages}', 
                    [
                            'files' => json_encode($files),
                            'languages' => json_encode($languages)
                    ]);
            // Check if files and language not empty
            $noLang = $this->noLanguage($languages);
            if (!empty($files) && ($this->checkForAcceptedLanguages($languages) || $noLang)) {
                // language part:
                if ($noLang) {
                    $languages = [];
                }
                // file part:
                $fileInfo = $this->fileService->buildFileInfo($files);
                foreach ($fileInfo as $fInfo) {
                    // Check Shared
                    $shared = $this->fileService->checkSharedWithInitiator($fInfo);
                    $target = $this->fileService->buildTarget($fInfo, $shared);
                    $source = $this->fileService->buildSource($fInfo, $shared);
                    // set the running type
                    $fType = $this->fileService->getCorrectType($fInfo);
                    // create a temp file for ocr processing purposes
                    $tempFile = $this->getTempFile($fType);
                    // Create job object
                    $job = new OcrJob(OcrConstants::STATUS_PENDING, $source, $target, $tempFile, $fType, $this->userId, 
                            false, $fInfo->getName(), null);

                    // Init client and send task / job
                    // Feed the worker
                    $this->redisService->sendJob($job, $languages);
                }
                return 'PROCESSING';
            } else {
                throw new NotFoundException($this->l10n->t('Empty parameters passed.'));
            }
        } catch (Exception $e) {
            $this->handleException($e);
        }
    }

    /**
     * Delete an ocr job for a given id and userId.
     * 
     * @param
     *            $jobId
     * @param string $userId            
     * @return OcrJob
     */
    public function deleteJob($jobId, $userId) {
        try {
            $job = $this->jobMapper->find($jobId);
            if ($job->getUserId() !== $userId) {
                throw new NotFoundException($this->l10n->t('Cannot delete because of wrong owner.'));
            } else {
                $job = $this->jobMapper->delete($job);
            }
            $job->setTarget(null);
            $job->setSource(null);
            $job->setStatus(null);
            $job->setTempFile(null);
            $job->setType(null);
            $job->setUserId(null);
            $job->setErrorDisplayed(null);
            $job->setErrorLog(null);
            return $job;
        } catch (Exception $e) {
            if ($e instanceof DoesNotExistException) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $ex = new NotFoundException($this->l10n->t('Cannot delete because of wrong ID.'));
                $this->handleException($ex);
            } else {
                $this->handleException($e);
            }
        }
    }

    /**
     * Gets all job objects for a specific user.
     * 
     * @param string $userId            
     * @return OcrJob[]
     */
    public function getAllJobsForUser($userId) {
        try {
            $jobs = $this->jobMapper->findAll($userId);
            $jobsNew = array();
            foreach ($jobs as $job) {
                $job->setTarget(null);
                $job->setSource(null);
                $job->setTempFile(null);
                $job->setType(null);
                $job->setUserId(null);
                $job->setErrorDisplayed(null);
                array_push($jobsNew, $job);
            }
            return $jobsNew;
        } catch (Exception $e) {
            $this->handleException($e);
        }
    }

    /**
     * The function checks if there are finished jobs to process finally.
     * 
     * @throws NotFoundException
     */
    public function checkForFinishedJobs() {
        try {
            $finishedJobs = $this->redisService->readingFinishedJobs();
            foreach ($finishedJobs as $finishedJob) {
                $fJob = $this->transformJob($finishedJob);
                $this->logger->debug('The following job finished: {job}', 
                        [
                                'job' => $fJob
                        ]);
                $this->jobFinished($fJob->id, $fJob->error, $fJob->log);
            }
        } catch (Exception $e) {
            throw new NotFoundException($this->l10n->t('Reading the finished jobs from redis went wrong.'));
        }
    }

    /**
     * Finishes all Processed files by copying them to the right path and deleteing the temp files.
     * Returns the number of processed files.
     * 
     * @return array
     */
    public function handleProcessed() {
        try {
            $this->logger->debug('Check if files were processed by ocr and if so, put them to the right dirs.');
            $processed = $this->jobMapper->findAllProcessed($this->userId);
            foreach ($processed as $job) {
                if ($this->fileUtil->fileExists($job->getTempFile())) {
                    // Save the tmp file with newname
                    $this->view->file_put_contents($job->getTarget(), 
                            $this->fileUtil->getFileContents($job->getTempFile()));
                    $this->jobMapper->delete($job);
                    $this->fileUtil->execRemove($job->getTempFile());
                } else {
                    $job->setStatus(OcrConstants::STATUS_FAILED);
                    $job->setErrorLog('Temp file does not exist.');
                    $this->jobMapper->update($job);
                    throw new NotFoundException($this->l10n->t('Temp file does not exist.'));
                }
            }
            return $processed;
        } catch (Exception $e) {
            $this->handleException($e);
        }
    }

    /**
     * Handles all failed orders of ocr processing queue and returns the job objects.
     * 
     * @return array
     */
    public function handleFailed() {
        try {
            $failed = $this->jobMapper->findAllFailed($this->userId);
            foreach ($failed as $job) {
                // clean the tempfile
                $this->fileUtil->execRemove($job->getTempFile());
                // set error displayed
                $job->setErrorDisplayed(true);
                $this->jobMapper->update($job);
            }
            $this->logger->debug('Following jobs failed: {failed}', 
                    [
                            'failed' => json_encode($failed)
                    ]);
            return $failed;
        } catch (Exception $e) {
            $this->handleException($e);
        }
    }

    /**
     * The function the worker will call in order to set the jobs status.
     * The worker should call it automatically after each processing step.
     * 
     * @param integer $jobId            
     * @param boolean $error            
     * @param string $log            
     */
    private function jobFinished($jobId, $error, $log) {
        try {
            $job = $this->jobMapper->find($jobId);
            if (!$error) {
                $job->setStatus(OcrConstants::STATUS_PROCESSED);
                $this->jobMapper->update($job);
            } else {
                $job->setStatus(OcrConstants::STATUS_FAILED);
                $job->setErrorLog($log);
                $this->jobMapper->update($job);
                $this->logger->error($log);
            }
        } catch (Exception $e) {
            $this->handleException($e);
        }
    }

    /**
     * Gives a temp file name back depending on the type of the OCR.
     * Later in the worker this file is used as an output.
     * 
     * @param integer $type            
     * @return string
     */
    private function getTempFile($type) {
        if ($type === OcrConstants::TESSERACT) {
            $fileName = $this->phpUtil->tempnamWrapper($this->tempM->getTempBaseDir(), OcrConstants::TEMPFILE_PREFIX);
            $this->phpUtil->unlinkWrapper($fileName);
            $fileNameWithPostfix = $fileName . '.txt';
            $this->phpUtil->touchWrapper($fileNameWithPostfix);
            $this->phpUtil->chmodWrapper($fileNameWithPostfix, 0600);
            return $fileNameWithPostfix;
        } else {
            return $this->phpUtil->tempnamWrapper($this->tempM->getTempBaseDir(), OcrConstants::TEMPFILE_PREFIX);
        }
    }

    /**
     * Takes care of transforming an incoming finished job into a php readable object.
     * 
     * @param string $job            
     * @throws NotFoundException
     * @return mixed
     */
    private function transformJob($job) {
        $decoded = json_decode($job);
        if ($decoded !== null && isset($decoded->id)) {
            return $decoded;
        } else {
            $this->logger->debug('The finished job retrieved by Redis was corrupt.');
            throw new NotFoundException('The finished job retrieved by Redis was corrupt.');
        }
    }

    /**
     * Checks if the given languages are supported or not.
     * 
     * @param string[] $languages            
     * @return boolean
     */
    private function checkForAcceptedLanguages($languages) {
        $installedLanguages = explode(';', $this->appConfigService->getAppValue('languages'));
        if (count(array_diff($languages, $installedLanguages)) === 0) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * Checks if the process should be initiated without any language specified.
     * 
     * @param string[] $languages            
     * @return boolean
     */
    private function noLanguage($languages) {
        if (in_array('any', $languages)) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * Handle the possible thrown Exceptions from all methods of this class.
     * 
     * @param Exception $e            
     * @throws Exception
     * @throws NotFoundException
     */
    private function handleException($e) {
        $this->logger->logException($e, 
                [
                        'message' => 'Exception during job service function processing'
                ]);
        throw $e;
    }
}

Pull Request — master (#93)

JobService::checkForFinishedJobs() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		/**
4		* Nextcloud - OCR
5		* This file is licensed under the Affero General Public License version 3 or
6		* later.
7		* See the COPYING file.
8		*
9		* @author Janis Koehr <[email protected]>
10		* @copyright Janis Koehr 2017
11		*/
12		namespace OCA\Ocr\Service;
13
14		use OCA\Ocr\Db\OcrJobMapper;
15		use OC\Files\View;
16		use OCP\ILogger;
17		use OCP\IL10N;
18		use OCP\ITempManager;
19		use OCA\Ocr\Db\OcrJob;
20		use OCA\Ocr\Constants\OcrConstants;
21		use OCA\Ocr\Util\PHPUtil;
22		use Exception;
23		use OCP\AppFramework\Db\DoesNotExistException;
24		use OCA\Ocr\Util\FileUtil;
25
26
27		/**
28		* Class JobService
29		*
30		* @package OCA\Ocr\Service
31		*/
32		class JobService {
33
34		/**
35		*
36		* @var ILogger
37		*/
38		private $logger;
39
40		/**
41		*
42		* @var RedisService
43		*/
44		private $redisService;
45
46		/**
47		*
48		* @var OcrJobMapper
49		*/
50		private $jobMapper;
51
52		/**
53		*
54		* @var View
55		*/
56		private $view;
57
58		/**
59		*
60		* @var String
61		*/
62		private $userId;
63
64		/**
65		*
66		* @var IL10N
67		*/
68		private $l10n;
69
70		/**
71		*
72		* @var FileService
73		*/
74		private $fileService;
75
76		/**
77		*
78		* @var ITempManager
79		*/
80		private $tempM;
81
82		/**
83		*
84		* @var AppConfigService
85		*/
86		private $appConfigService;
87
88		/**
89		*
90		* @var PHPUtil
91		*/
92		private $phpUtil;
93
94		/**
95		*
96		* @var FileUtil
97		*/
98		private $fileUtil;
99
100		/**
101		* JobService constructor.
102		*
103		* @param IL10N $l10n
104		* @param ILogger $logger
105		* @param string $userId
106		* @param View $view
107		* @param RedisService $queueService
108		* @param OcrJobMapper $mapper
109		* @param FileService $fileService
110		* @param AppConfigService $appConfigService
111		* @param PHPUtil $phpUtil
112		* @param FileUtil $fileUtil
113		*/
114	22	public function __construct(IL10N $l10n, ILogger $logger, $userId, View $view, ITempManager $tempManager,
115		RedisService $queueService, OcrJobMapper $mapper, FileService $fileService,
116		AppConfigService $appConfigService, PHPUtil $phpUtil, FileUtil $fileUtil) {
117	22	$this->logger = $logger;
118	22	$this->redisService = $queueService;
119	22	$this->jobMapper = $mapper;
120	22	$this->view = $view;
121	22	$this->userId = $userId;
122	22	$this->l10n = $l10n;
123	22	$this->fileService = $fileService;
124	22	$this->tempM = $tempManager;
125	22	$this->appConfigService = $appConfigService;
126	22	$this->phpUtil = $phpUtil;
127	22	$this->fileUtil = $fileUtil;
128	22	}
129
130		/**
131		* Processes and prepares the files for OCR.
132		* Sends the stuff to the client in order to OCR async.
133		*
134		* @param string[] $languages
135		* @param array $files
136		* @return string
137		*/
138	9	public function process($languages, $files) {
139		try {
140	9	$this->logger->debug('Will now process files: {files} with languages: {languages}',
141		[
142	9	'files' => json_encode($files),
143	9	'languages' => json_encode($languages)
144		]);
145		// Check if files and language not empty
146	9	$noLang = $this->noLanguage($languages);
147	9	if (!empty($files) && ($this->checkForAcceptedLanguages($languages) \|\| $noLang)) {
148		// language part:
149	6	if ($noLang) {
150	5	$languages = [];
151		}
152		// file part:
153	6	$fileInfo = $this->fileService->buildFileInfo($files);
154	6	foreach ($fileInfo as $fInfo) {
155		// Check Shared
156	6	$shared = $this->fileService->checkSharedWithInitiator($fInfo);
157	6	$target = $this->fileService->buildTarget($fInfo, $shared);
158	6	$source = $this->fileService->buildSource($fInfo, $shared);
159		// set the running type
160	6	$fType = $this->fileService->getCorrectType($fInfo);
161		// create a temp file for ocr processing purposes
162	6	$tempFile = $this->getTempFile($fType);
163		// Create job object
164	2	$job = new OcrJob(OcrConstants::STATUS_PENDING, $source, $target, $tempFile, $fType, $this->userId,
165	2	false, $fInfo->getName(), null);
		1 ignored issue – show Bug introduced 2017-06-30 13:59 UTC by Report Bug Copy Issue Report Consider using `$fInfo->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
166		// Init client and send task / job
167		// Feed the worker
168	2	$this->redisService->sendJob($job, $languages);
169		}
170	2	return 'PROCESSING';
171		} else {
172	3	throw new NotFoundException($this->l10n->t('Empty parameters passed.'));
173		}
174	7	} catch (Exception $e) {
175	7	$this->handleException($e);
176		}
177		}
178
179		/**
180		* Delete an ocr job for a given id and userId.
181		*
182		* @param
183		* $jobId
184		* @param string $userId
185		* @return OcrJob
186		*/
187	3	public function deleteJob($jobId, $userId) {
188		try {
189	3	$job = $this->jobMapper->find($jobId);
190	2	if ($job->getUserId() !== $userId) {
191	1	throw new NotFoundException($this->l10n->t('Cannot delete because of wrong owner.'));
192		} else {
193	1	$job = $this->jobMapper->delete($job);
194		}
195	1	$job->setTarget(null);
196	1	$job->setSource(null);
197	1	$job->setStatus(null);
198	1	$job->setTempFile(null);
199	1	$job->setType(null);
200	1	$job->setUserId(null);
201	1	$job->setErrorDisplayed(null);
202	1	$job->setErrorLog(null);
203	1	return $job;
204	2	} catch (Exception $e) {
205	2	if ($e instanceof DoesNotExistException) {
		0 ignored issues – show Bug introduced 2017-01-13 12:52 UTC by Report Bug Copy Issue Report The class `OCP\AppFramework\Db\DoesNotExistException` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
206	1	$ex = new NotFoundException($this->l10n->t('Cannot delete because of wrong ID.'));
207	1	$this->handleException($ex);
208		} else {
209	1	$this->handleException($e);
210		}
211		}
212		}
213
214		/**
215		* Gets all job objects for a specific user.
216		*
217		* @param string $userId
218		* @return OcrJob[]
219		*/
220	1	public function getAllJobsForUser($userId) {
221		try {
222	1	$jobs = $this->jobMapper->findAll($userId);
223	1	$jobsNew = array();
224	1	foreach ($jobs as $job) {
225	1	$job->setTarget(null);
226	1	$job->setSource(null);
227	1	$job->setTempFile(null);
228	1	$job->setType(null);
229	1	$job->setUserId(null);
230	1	$job->setErrorDisplayed(null);
231	1	array_push($jobsNew, $job);
232		}
233	1	return $jobsNew;
234		} catch (Exception $e) {
235		$this->handleException($e);
236		}
237		}
238
239		/**
240		* The function checks if there are finished jobs to process finally.
241		*
242		* @throws NotFoundException
243		*/
244	2	public function checkForFinishedJobs() {
245		try {
246	2	$finishedJobs = $this->redisService->readingFinishedJobs();
247	2	foreach ($finishedJobs as $finishedJob) {
248	1	$fJob = $this->transformJob($finishedJob);
249	1	$this->logger->debug('The following job finished: {job}',
250		[
251	1	'job' => $fJob
252		]);
253	1	$this->jobFinished($fJob->id, $fJob->error, $fJob->log);
254		}
255	1	} catch (Exception $e) {
256	1	throw new NotFoundException($this->l10n->t('Reading the finished jobs from redis went wrong.'));
257		}
258	1	}
259
260		/**
261		* Finishes all Processed files by copying them to the right path and deleteing the temp files.
262		* Returns the number of processed files.
263		*
264		* @return array
265		*/
266	2	public function handleProcessed() {
267		try {
268	2	$this->logger->debug('Check if files were processed by ocr and if so, put them to the right dirs.');
269	2	$processed = $this->jobMapper->findAllProcessed($this->userId);
270	2	foreach ($processed as $job) {
271	2	if ($this->fileUtil->fileExists($job->getTempFile())) {
272		// Save the tmp file with newname
273	1	$this->view->file_put_contents($job->getTarget(),
274	1	$this->fileUtil->getFileContents($job->getTempFile()));
275	1	$this->jobMapper->delete($job);
276	1	$this->fileUtil->execRemove($job->getTempFile());
277		} else {
278	1	$job->setStatus(OcrConstants::STATUS_FAILED);
279	1	$job->setErrorLog('Temp file does not exist.');
280	1	$this->jobMapper->update($job);
281	2	throw new NotFoundException($this->l10n->t('Temp file does not exist.'));
282		}
283		}
284	1	return $processed;
285	1	} catch (Exception $e) {
286	1	$this->handleException($e);
287		}
288		}
289
290		/**
291		* Handles all failed orders of ocr processing queue and returns the job objects.
292		*
293		* @return array
294		*/
295	1	public function handleFailed() {
296		try {
297	1	$failed = $this->jobMapper->findAllFailed($this->userId);
298	1	foreach ($failed as $job) {
299		// clean the tempfile
300	1	$this->fileUtil->execRemove($job->getTempFile());
301		// set error displayed
302	1	$job->setErrorDisplayed(true);
303	1	$this->jobMapper->update($job);
304		}
305	1	$this->logger->debug('Following jobs failed: {failed}',
306		[
307	1	'failed' => json_encode($failed)
308		]);
309	1	return $failed;
310		} catch (Exception $e) {
311		$this->handleException($e);
312		}
313		}
314
315		/**
316		* The function the worker will call in order to set the jobs status.
317		* The worker should call it automatically after each processing step.
318		*
319		* @param integer $jobId
320		* @param boolean $error
321		* @param string $log
322		*/
323	1	private function jobFinished($jobId, $error, $log) {
324		try {
325	1	$job = $this->jobMapper->find($jobId);
326	1	if (!$error) {
327	1	$job->setStatus(OcrConstants::STATUS_PROCESSED);
328	1	$this->jobMapper->update($job);
329		} else {
330	1	$job->setStatus(OcrConstants::STATUS_FAILED);
331	1	$job->setErrorLog($log);
332	1	$this->jobMapper->update($job);
333	1	$this->logger->error($log);
334		}
335		} catch (Exception $e) {
336		$this->handleException($e);
337		}
338	1	}
339
340		/**
341		* Gives a temp file name back depending on the type of the OCR.
342		* Later in the worker this file is used as an output.
343		*
344		* @param integer $type
345		* @return string
346		*/
347	6	private function getTempFile($type) {
348	6	if ($type === OcrConstants::TESSERACT) {
349	5	$fileName = $this->phpUtil->tempnamWrapper($this->tempM->getTempBaseDir(), OcrConstants::TEMPFILE_PREFIX);
350	5	$this->phpUtil->unlinkWrapper($fileName);
351	4	$fileNameWithPostfix = $fileName . '.txt';
352	4	$this->phpUtil->touchWrapper($fileNameWithPostfix);
353	3	$this->phpUtil->chmodWrapper($fileNameWithPostfix, 0600);
354	2	return $fileNameWithPostfix;
355		} else {
356	3	return $this->phpUtil->tempnamWrapper($this->tempM->getTempBaseDir(), OcrConstants::TEMPFILE_PREFIX);
357		}
358		}
359
360		/**
361		* Takes care of transforming an incoming finished job into a php readable object.
362		*
363		* @param string $job
364		* @throws NotFoundException
365		* @return mixed
366		*/
367	1	private function transformJob($job) {
368	1	$decoded = json_decode($job);
369	1	if ($decoded !== null && isset($decoded->id)) {
370	1	return $decoded;
371		} else {
372		$this->logger->debug('The finished job retrieved by Redis was corrupt.');
373		throw new NotFoundException('The finished job retrieved by Redis was corrupt.');
374		}
375		}
376
377		/**
378		* Checks if the given languages are supported or not.
379		*
380		* @param string[] $languages
381		* @return boolean
382		*/
383	8	private function checkForAcceptedLanguages($languages) {
384	8	$installedLanguages = explode(';', $this->appConfigService->getAppValue('languages'));
385	8	if (count(array_diff($languages, $installedLanguages)) === 0) {
386	1	return true;
387		} else {
388	7	return false;
389		}
390		}
391
392		/**
393		* Checks if the process should be initiated without any language specified.
394		*
395		* @param string[] $languages
396		* @return boolean
397		*/
398	9	private function noLanguage($languages) {
399	9	if (in_array('any', $languages)) {
400	6	return true;
401		} else {
402	3	return false;
403		}
404		}
405
406		/**
407		* Handle the possible thrown Exceptions from all methods of this class.
408		*
409		* @param Exception $e
410		* @throws Exception
411		* @throws NotFoundException
412		*/
413	10	private function handleException($e) {
414	10	$this->logger->logException($e,
415		[
416		'message' => 'Exception during job service function processing'
417	10	]);
418	10	throw $e;
419		}
420		}

janis91 / ocr

Pull Request — master (#93)

JobService::checkForFinishedJobs() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like