BodyParameterGenerator::resolveSchema() - Code Metrics - Inspection of "Update to last version of jane, add support for mu..." - janephp/openapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1c6d46...3dbc46 )

by Joel

created 2017-01-01 23:46 UTC

BodyParameterGenerator::resolveSchema() A

↳ Parent: Project

Complexity

Conditions	2
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	15
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	15
loc	15
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	1
nop	2
crap	6

<?php

namespace Joli\Jane\OpenApi\Generator\Parameter;

use Doctrine\Common\Inflector\Inflector;
use Joli\Jane\Generator\Context\Context;
use Joli\Jane\Runtime\Reference;
use Joli\Jane\Reference\Resolver;
use Joli\Jane\OpenApi\Model\BodyParameter;
use Joli\Jane\OpenApi\Model\Schema;
use PhpParser\Node;
use PhpParser\Parser;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;

class BodyParameterGenerator extends ParameterGenerator
{
    /**
     * @var DenormalizerInterface
     */
    private $denormalizer;

    public function __construct(Parser $parser, DenormalizerInterface $denormalizer)
    {
        parent::__construct($parser);

        $this->denormalizer = $denormalizer;
    }

    /**
     * {@inheritDoc}
     *
     * @param $parameter BodyParameter
     */
    public function generateMethodParameter($parameter, Context $context)
    {
        $name = Inflector::camelize($parameter->getName());

        list($class, $array) = $this->getClass($parameter, $context);

        if (null === $array || true === $array) {
            if ($class == "array") {
                return new Node\Param($name, null, "array");
            }

            return new Node\Param($name);
        }

        return new Node\Param($name, null, $class);
    }

    /**
     * {@inheritDoc}
     *
     * @param $parameter BodyParameter
     */
    public function generateDocParameter($parameter, Context $context)
    {
        list($class, $array) = $this->getClass($parameter, $context);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        if (null === $class) {
            return sprintf('%s $%s %s', 'mixed', Inflector::camelize($parameter->getName()), $parameter->getDescription() ?: '');
        }

        return sprintf('%s $%s %s', $class, Inflector::camelize($parameter->getName()), $parameter->getDescription() ?: '');
    }

    /**
     * @param BodyParameter $parameter
     * @param Context $context
     *
     * @return array
     */
    protected function getClass(BodyParameter $parameter, Context $context)
    {
        $resolvedSchema = null;
        $reference      = null;
        $array          = false;
        $schema         = $parameter->getSchema();

        if ($schema instanceof Reference) {
            list($reference, $resolvedSchema) = $this->resolveSchema($schema, Schema::class);
        }

        if ($schema instanceof Schema && $schema->getType() == "array" && $schema->getItems() instanceof Reference) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            list($reference, $resolvedSchema) = $this->resolveSchema($schema->getItems(), Schema::class);
            $array          = true;
        }

        if ($resolvedSchema === null) {
            return [$schema->getType(), null];
        }

        $class = $context->getRegistry()->getClass($reference);
        $class = "\\" . $context->getRegistry()->getSchema($reference)->getNamespace() . "\\Model\\" . $class->getName();

        if ($array) {
            $class .= "[]";
        }

        return [$class, $array];
    }

    /**
     * @param Reference $reference
     * @param $class
     *
     * @return mixed
     */
    private function resolveSchema(Reference $reference, $class)

    {
        $result    = $reference;

        do {
            $refString = (string) $reference->getMergedUri();
            $result = $result->resolve(function ($data) use($result, $class) {
                return $this->denormalizer->denormalize($data, $class, 'json', [
                    'document-origin' => (string) $result->getMergedUri()->withFragment('')
                ]);
            });
        } while ($result instanceof Reference);

        return [$refString, $result];
    }
}


1			<?php
2
3			namespace Joli\Jane\OpenApi\Generator\Parameter;
4
5			use Doctrine\Common\Inflector\Inflector;
6			use Joli\Jane\Generator\Context\Context;
7			use Joli\Jane\Runtime\Reference;
8			use Joli\Jane\Reference\Resolver;
9			use Joli\Jane\OpenApi\Model\BodyParameter;
10			use Joli\Jane\OpenApi\Model\Schema;
11			use PhpParser\Node;
12			use PhpParser\Parser;
13			use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
14
15			class BodyParameterGenerator extends ParameterGenerator
16			{
17			/**
18			* @var DenormalizerInterface
19			*/
20			private $denormalizer;
21	7
22			public function __construct(Parser $parser, DenormalizerInterface $denormalizer)
23	7		{
24			parent::__construct($parser);
25	7
26	7		$this->denormalizer = $denormalizer;
27			}
28
29			/**
30			* {@inheritDoc}
31			*
32			* @param $parameter BodyParameter
33	2		*/
34			public function generateMethodParameter($parameter, Context $context)
35	2		{
36			$name = Inflector::camelize($parameter->getName());
37	2
38			list($class, $array) = $this->getClass($parameter, $context);
39	2
40	2		if (null === $array \|\| true === $array) {
41	1		if ($class == "array") {
42			return new Node\Param($name, null, "array");
43			}
44	2
45			return new Node\Param($name);
46			}
47	1
48			return new Node\Param($name, null, $class);
49			}
50
51			/**
52			* {@inheritDoc}
53			*
54			* @param $parameter BodyParameter
55	2		*/
56			public function generateDocParameter($parameter, Context $context)
57	2		{
58			list($class, $array) = $this->getClass($parameter, $context);
			0 ignored issues – show Unused Code introduced 2016-09-01 16:10 UTC by Report Bug Copy Issue Report The assignment to `$array` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
59	2
60			if (null === $class) {
61			return sprintf('%s $%s %s', 'mixed', Inflector::camelize($parameter->getName()), $parameter->getDescription() ?: '');
62			}
63	2
64			return sprintf('%s $%s %s', $class, Inflector::camelize($parameter->getName()), $parameter->getDescription() ?: '');
65			}
66
67			/**
68			* @param BodyParameter $parameter
69			* @param Context $context
70			*
71			* @return array
72	2		*/
73			protected function getClass(BodyParameter $parameter, Context $context)
74	2		{
75	2		$resolvedSchema = null;
76	2		$reference = null;
77			$array = false;
78	2		$schema = $parameter->getSchema();
79	1
80	1		if ($schema instanceof Reference) {
81			list($reference, $resolvedSchema) = $this->resolveSchema($schema, Schema::class);
82	2		}
83
84		View Code Duplication	if ($schema instanceof Schema && $schema->getType() == "array" && $schema->getItems() instanceof Reference) {
			0 ignored issues – show Bug introduced 2016-09-01 16:10 UTC by Report Bug Copy Issue Report The class `Joli\Jane\OpenApi\Model\Schema` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history... Duplication introduced 2016-09-01 16:10 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85			list($reference, $resolvedSchema) = $this->resolveSchema($schema->getItems(), Schema::class);
86			$array = true;
87	2		}
88	2
89			if ($resolvedSchema === null) {
90			return [$schema->getType(), null];
91	1		}
92	1
93			$class = $context->getRegistry()->getClass($reference);
94	1		$class = "\\" . $context->getRegistry()->getSchema($reference)->getNamespace() . "\\Model\\" . $class->getName();
95
96			if ($array) {
97			$class .= "[]";
98	1		}
99
100			return [$class, $array];
101			}
102
103			/**
104			* @param Reference $reference
105			* @param $class
106			*
107			* @return mixed
108			*/
109		View Code Duplication	private function resolveSchema(Reference $reference, $class)
			0 ignored issues – show Duplication introduced 2017-01-01 23:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110			{
111			$result = $reference;
112
113			do {
114			$refString = (string) $reference->getMergedUri();
115			$result = $result->resolve(function ($data) use($result, $class) {
116			return $this->denormalizer->denormalize($data, $class, 'json', [
117			'document-origin' => (string) $result->getMergedUri()->withFragment('')
118			]);
119			});
120			} while ($result instanceof Reference);
121
122			return [$refString, $result];
123			}
124			}
125

janephp / openapi

Push — master ( 1c6d46...3dbc46 )

BodyParameterGenerator::resolveSchema() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like