LoadBalancers - Code Metrics - Inspection of "Merge pull request #38 from jamesryanbell/traffic_..." - jamesryanbell/cloudflare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5e838e...5ac056 )

by James

created 2016-10-01 20:36 UTC

LoadBalancers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	5
c	2
b	1
f	0
lcom	0
cbo	1
dl	0
loc	92
rs	10

5 Methods

Rating	Name	Size	Complexity
A	load_balancers()	4	1
A	details()	4	1
A	delete_load_balancer()	4	1
A	create()	12	1
A	update()	12	1

<?php

namespace Cloudflare\Zone;

use Cloudflare\Api;

/**
 * CloudFlare API wrapper
 *
 * CTM Load Balancer
 * User-level Cloud Traffic Manager Load Balancer
 *
 * @author James Bell <[email protected]>
 *
 * @version 1
 */
class LoadBalancers extends Api
{
    /**
     * List load balancers
     * List configured load balancers
     *
     * @param string $zone_identifier
     */
    public function load_balancers($zone_identifier)
    {
        return $this->get('/zones/'.$zone_identifier.'/load_balancers');
    }

    /**
     * Create a load balancer
     * Create a new load balancer
     *
     * @param string      $zone_identifier
     * @param string      $name            A hostname of the record that should provide load balancing capabilities.
     *                                     If this name already exists as a DNS record in your CloudFlare DNS,
     *                                     the existing record will take precedence over the Load Balancer.
     * @param string      $global_policy   ID of the Global Policy object.
     * @param string|null $description     Object description.
     * @param int|null    $ttl             Time to live (TTL) of the DNS entry for the IP address returned
     *                                     by this load balancer.
     * @param bool|null   $proxied         Whether the hostname should be grey clouded (False) or orange clouded (True).
     */
    public function create($zone_identifier, $name, $global_policy, $description = null, $ttl = null, $proxied = null)
    {
        $data = [
            'name'          => $name,
            'global_policy' => $global_policy,
            'description'   => $description,
            'ttl'           => $ttl,
            'proxied'       => $proxied,
        ];

        return $this->post('/zones/'.$zone_identifier.'/load_balancers', $data);
    }

    /**
     * Load balancer details
     * Fetch a single configured load balancer
     *
     * @param string $zone_identifier
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $identifier
     */
    public function details($identifier)
    {
        return $this->get('/zones/'.$zone_identifier.'/load_balancers/'.$identifier);

    }

    /**
     * Modify a load balancer
     * Modify a configured load balancer
     *
     * @param string      $zone_identifier
     * @param string      $identifier
     * @param string|null $name            A hostname of the record that should provide load balancing capabilities.
     *                                     If this name already exists as a DNS record in your CloudFlare DNS,
     *                                     the existing record will take precedence over the Load Balancer.
     * @param string|null $global_policy   ID of the Global Policy object.
     * @param string|null $description     Object description.
     * @param int|null    $ttl             Time to live (TTL) of the DNS entry for the IP address returned
     *                                     by this load balancer.
     * @param bool|null   $proxied         Whether the hostname should be grey clouded (False) or orange clouded (True).
     */
    public function update($zone_identifier, $identifier, $name = null, $global_policy = null, $description = null, $ttl = null, $proxied = null)

    {
        $data = [
            'name'          => $name,
            'global_policy' => $global_policy,
            'description'   => $description,
            'ttl'           => $ttl,
            'proxied'       => $proxied,
        ];

        return $this->patch('/zones/'.$zone_identifier.'/load_balancers/'.$identifier, $data);
    }

    /**
     * Delete a load balancer
     * Delete a configured load balancer
     *
     * @param string $zone_identifier
     * @param string $identifier
     */
    public function delete_load_balancer($zone_identifier, $identifier)
    {
        return $this->delete('/zones/'.$zone_identifier.'/load_balancers/'.$identifier);
    }
}


1			<?php
2
3			namespace Cloudflare\Zone;
4
5			use Cloudflare\Api;
6
7			/**
8			* CloudFlare API wrapper
9			*
10			* CTM Load Balancer
11			* User-level Cloud Traffic Manager Load Balancer
12			*
13			* @author James Bell <[email protected]>
14			*
15			* @version 1
16			*/
17			class LoadBalancers extends Api
18			{
19			/**
20			* List load balancers
21			* List configured load balancers
22			*
23			* @param string $zone_identifier
24			*/
25			public function load_balancers($zone_identifier)
26			{
27			return $this->get('/zones/'.$zone_identifier.'/load_balancers');
28			}
29
30			/**
31			* Create a load balancer
32			* Create a new load balancer
33			*
34			* @param string $zone_identifier
35			* @param string $name A hostname of the record that should provide load balancing capabilities.
36			* If this name already exists as a DNS record in your CloudFlare DNS,
37			* the existing record will take precedence over the Load Balancer.
38			* @param string $global_policy ID of the Global Policy object.
39			* @param string\|null $description Object description.
40			* @param int\|null $ttl Time to live (TTL) of the DNS entry for the IP address returned
41			* by this load balancer.
42			* @param bool\|null $proxied Whether the hostname should be grey clouded (False) or orange clouded (True).
43			*/
44			public function create($zone_identifier, $name, $global_policy, $description = null, $ttl = null, $proxied = null)
45			{
46			$data = [
47			'name' => $name,
48			'global_policy' => $global_policy,
49			'description' => $description,
50			'ttl' => $ttl,
51			'proxied' => $proxied,
52			];
53
54			return $this->post('/zones/'.$zone_identifier.'/load_balancers', $data);
55			}
56
57			/**
58			* Load balancer details
59			* Fetch a single configured load balancer
60			*
61			* @param string $zone_identifier
			0 ignored issues – show Documentation introduced 2016-10-01 20:12 UTC by Report Bug Copy Issue Report There is no parameter named `$zone_identifier`. Did you maybe mean `$identifier`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
62			* @param string $identifier
63			*/
64			public function details($identifier)
65			{
66			return $this->get('/zones/'.$zone_identifier.'/load_balancers/'.$identifier);
			0 ignored issues – show Bug introduced 2016-10-01 20:12 UTC by Report Bug Copy Issue Report The variable `$zone_identifier` does not exist. Did you mean `$identifier`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
67			}
68
69			/**
70			* Modify a load balancer
71			* Modify a configured load balancer
72			*
73			* @param string $zone_identifier
74			* @param string $identifier
75			* @param string\|null $name A hostname of the record that should provide load balancing capabilities.
76			* If this name already exists as a DNS record in your CloudFlare DNS,
77			* the existing record will take precedence over the Load Balancer.
78			* @param string\|null $global_policy ID of the Global Policy object.
79			* @param string\|null $description Object description.
80			* @param int\|null $ttl Time to live (TTL) of the DNS entry for the IP address returned
81			* by this load balancer.
82			* @param bool\|null $proxied Whether the hostname should be grey clouded (False) or orange clouded (True).
83			*/
84			public function update($zone_identifier, $identifier, $name = null, $global_policy = null, $description = null, $ttl = null, $proxied = null)
			1 ignored issue – show Duplication introduced 2016-10-01 20:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85			{
86			$data = [
87			'name' => $name,
88			'global_policy' => $global_policy,
89			'description' => $description,
90			'ttl' => $ttl,
91			'proxied' => $proxied,
92			];
93
94			return $this->patch('/zones/'.$zone_identifier.'/load_balancers/'.$identifier, $data);
95			}
96
97			/**
98			* Delete a load balancer
99			* Delete a configured load balancer
100			*
101			* @param string $zone_identifier
102			* @param string $identifier
103			*/
104			public function delete_load_balancer($zone_identifier, $identifier)
105			{
106			return $this->delete('/zones/'.$zone_identifier.'/load_balancers/'.$identifier);
107			}
108			}
109

jamesryanbell / cloudflare

GitHub Access Token became invalid

Push — master ( 5e838e...5ac056 )

LoadBalancers A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like