Issues in AuthenticationMiddlewareTest.php (master) - Issues in master - jakubigla/PSR7Auth - Measure and Improve Code Quality continuously with Scrutinizer

Issues (9)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

test/Middleware/AuthenticationMiddlewareTest.php (6 issues)

Labels

Severity

Major 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PSR7AuthTest\Middleware;

use PHPUnit_Framework_TestCase;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use PSR7Auth\AccessRule\AccessRuleInterface;
use PSR7Auth\Domain\Entity\UserInterface;
use PSR7Auth\Exception\IdentityNotFoundException;
use PSR7Auth\IdentityProvider\IdentityProviderInterface;
use PSR7Auth\Middleware\AuthenticationMiddleware;
use PSR7Auth\Verifier\VerifierInterface;
use stdClass;

/**
 * Class AuthenticationMiddlewareTest
 */
class AuthenticationMiddlewareTest extends PHPUnit_Framework_TestCase
{
    /** @var IdentityProviderInterface|\PHPUnit_Framework_MockObject_MockObject */
    private $identityProvider;

    /** @var AccessRuleInterface|\PHPUnit_Framework_MockObject_MockObject */
    private $accessRule;

    /** @var VerifierInterface|\PHPUnit_Framework_MockObject_MockObject */
    private $verifier;

    /** @var ServerRequestInterface|\PHPUnit_Framework_MockObject_MockObject */
    private $request;

    /** @var ResponseInterface|\PHPUnit_Framework_MockObject_MockObject */
    private $response;

    /** @var callable|\PHPUnit_Framework_MockObject_MockObject */
    private $nextMiddleware;

    /** @var AuthenticationMiddleware|\PHPUnit_Framework_MockObject_MockObject */
    private $middleware;

    public function setUp()
    {
        $this->identityProvider = self::getMock(IdentityProviderInterface::class, ['__invoke']);
        $this->accessRule       = self::getMock(AccessRuleInterface::class, ['__invoke']);
        $this->verifier         = self::getMock(VerifierInterface::class, ['__invoke']);
        $this->request          = self::getMock(ServerRequestInterface::class);
        $this->response         = self::getMock(ResponseInterface::class);
        $this->nextMiddleware   = self::getMock(stdClass::class, ['__invoke']);
        $this->middleware       = new AuthenticationMiddleware(

            $this->identityProvider,
            $this->accessRule,
            $this->verifier
        );
    }

    public function testAccessRulePipesToTheNextMiddlewareWhenNotSatisfied()
    {
        $nextReturnValue = $this->getMock(ResponseInterface::class);

        $this

            ->nextMiddleware
            ->expects(self::once())
            ->method('__invoke')
            ->with($this->request, $this->response)
            ->willReturn($nextReturnValue);

        $this
            ->accessRule
            ->expects(self::once())
            ->method('__invoke')
            ->willReturn(false);

        $result = $this->middleware->__invoke($this->request, $this->response, $this->nextMiddleware);

        self::assertSame($nextReturnValue, $result);
    }

    public function testIdentityNotFoundFromIdentityProvider()
    {
        $nextReturnValue = $this->getMock(ResponseInterface::class);

        $this

            ->nextMiddleware
            ->expects(self::once())
            ->method('__invoke')
            ->with($this->request, $this->response)
            ->willReturn($nextReturnValue);

        $this
            ->accessRule
            ->expects(self::once())
            ->method('__invoke')
            ->with($this->request)
            ->willReturn(true);

        $this
            ->identityProvider
            ->expects($this->once())
            ->method('__invoke')
            ->willThrowException(new IdentityNotFoundException());

        $this
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->request
            ->expects(self::once())
            ->method('withAttribute')
            ->willReturn($this->request);

        $result = $this->middleware->__invoke($this->request, $this->response, $this->nextMiddleware);
        self::assertSame($nextReturnValue, $result);
    }

    public function testIdentityAuthenticated()
    {
        $nextReturnValue = $this->getMock(ResponseInterface::class);

        $this

            ->nextMiddleware
            ->expects(self::once())
            ->method('__invoke')
            ->with($this->request, $this->response)
            ->willReturn($nextReturnValue);

        $this
            ->accessRule
            ->expects(self::once())
            ->method('__invoke')
            ->with($this->request)
            ->willReturn(true);

        $this
            ->identityProvider
            ->expects(self::once())
            ->method('__invoke')
            ->with($this->request)
            ->willReturn($this->getMock(UserInterface::class));

        $this
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->request
            ->expects(self::once())
            ->method('withAttribute')
            ->willReturn($this->request);

        $result = $this->middleware->__invoke($this->request, $this->response, $this->nextMiddleware);
        self::assertSame($nextReturnValue, $result);
    }
}


1			<?php
2
3			namespace PSR7AuthTest\Middleware;
4
5			use PHPUnit_Framework_TestCase;
6			use Psr\Http\Message\ResponseInterface;
7			use Psr\Http\Message\ServerRequestInterface;
8			use PSR7Auth\AccessRule\AccessRuleInterface;
9			use PSR7Auth\Domain\Entity\UserInterface;
10			use PSR7Auth\Exception\IdentityNotFoundException;
11			use PSR7Auth\IdentityProvider\IdentityProviderInterface;
12			use PSR7Auth\Middleware\AuthenticationMiddleware;
13			use PSR7Auth\Verifier\VerifierInterface;
14			use stdClass;
15
16			/**
17			* Class AuthenticationMiddlewareTest
18			*/
19			class AuthenticationMiddlewareTest extends PHPUnit_Framework_TestCase
20			{
21			/** @var IdentityProviderInterface\|\PHPUnit_Framework_MockObject_MockObject */
22			private $identityProvider;
23
24			/** @var AccessRuleInterface\|\PHPUnit_Framework_MockObject_MockObject */
25			private $accessRule;
26
27			/** @var VerifierInterface\|\PHPUnit_Framework_MockObject_MockObject */
28			private $verifier;
29
30			/** @var ServerRequestInterface\|\PHPUnit_Framework_MockObject_MockObject */
31			private $request;
32
33			/** @var ResponseInterface\|\PHPUnit_Framework_MockObject_MockObject */
34			private $response;
35
36			/** @var callable\|\PHPUnit_Framework_MockObject_MockObject */
37			private $nextMiddleware;
38
39			/** @var AuthenticationMiddleware\|\PHPUnit_Framework_MockObject_MockObject */
40			private $middleware;
41
42			public function setUp()
43			{
44			$this->identityProvider = self::getMock(IdentityProviderInterface::class, ['__invoke']);
45			$this->accessRule = self::getMock(AccessRuleInterface::class, ['__invoke']);
46			$this->verifier = self::getMock(VerifierInterface::class, ['__invoke']);
47			$this->request = self::getMock(ServerRequestInterface::class);
48			$this->response = self::getMock(ResponseInterface::class);
49			$this->nextMiddleware = self::getMock(stdClass::class, ['__invoke']);
50			$this->middleware = new AuthenticationMiddleware(
			0 ignored issues – show Documentation Bug introduced 2016-03-26 14:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \PSR7Auth\Middleware...sRule, $this->verifier)` of type `object<PSR7Auth\Middlewa...thenticationMiddleware>` is incompatible with the declared type `object<PHPUnit_Framework_MockObject_MockObject>` of property `$middleware`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
51			$this->identityProvider,
52			$this->accessRule,
53			$this->verifier
54			);
55			}
56
57			public function testAccessRulePipesToTheNextMiddlewareWhenNotSatisfied()
58			{
59			$nextReturnValue = $this->getMock(ResponseInterface::class);
60
61			$this
			0 ignored issues – show Bug introduced 2016-03-26 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` cannot be called on `$this->nextMiddleware` (of type `callable`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
62			->nextMiddleware
63			->expects(self::once())
64			->method('__invoke')
65			->with($this->request, $this->response)
66			->willReturn($nextReturnValue);
67
68			$this
69			->accessRule
70			->expects(self::once())
71			->method('__invoke')
72			->willReturn(false);
73
74			$result = $this->middleware->__invoke($this->request, $this->response, $this->nextMiddleware);
75
76			self::assertSame($nextReturnValue, $result);
77			}
78
79			public function testIdentityNotFoundFromIdentityProvider()
80			{
81			$nextReturnValue = $this->getMock(ResponseInterface::class);
82
83			$this
			0 ignored issues – show Bug introduced 2016-03-26 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` cannot be called on `$this->nextMiddleware` (of type `callable`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
84			->nextMiddleware
85			->expects(self::once())
86			->method('__invoke')
87			->with($this->request, $this->response)
88			->willReturn($nextReturnValue);
89
90			$this
91			->accessRule
92			->expects(self::once())
93			->method('__invoke')
94			->with($this->request)
95			->willReturn(true);
96
97			$this
98			->identityProvider
99			->expects($this->once())
100			->method('__invoke')
101			->willThrowException(new IdentityNotFoundException());
102
103			$this
			0 ignored issues – show Bug introduced 2016-03-26 14:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Psr\Http\Message\ServerRequestInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
104			->request
105			->expects(self::once())
106			->method('withAttribute')
107			->willReturn($this->request);
108
109			$result = $this->middleware->__invoke($this->request, $this->response, $this->nextMiddleware);
110			self::assertSame($nextReturnValue, $result);
111			}
112
113			public function testIdentityAuthenticated()
114			{
115			$nextReturnValue = $this->getMock(ResponseInterface::class);
116
117			$this
			0 ignored issues – show Bug introduced 2016-03-26 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` cannot be called on `$this->nextMiddleware` (of type `callable`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
118			->nextMiddleware
119			->expects(self::once())
120			->method('__invoke')
121			->with($this->request, $this->response)
122			->willReturn($nextReturnValue);
123
124			$this
125			->accessRule
126			->expects(self::once())
127			->method('__invoke')
128			->with($this->request)
129			->willReturn(true);
130
131			$this
132			->identityProvider
133			->expects(self::once())
134			->method('__invoke')
135			->with($this->request)
136			->willReturn($this->getMock(UserInterface::class));
137
138			$this
			0 ignored issues – show Bug introduced 2016-03-26 14:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Psr\Http\Message\ServerRequestInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
139			->request
140			->expects(self::once())
141			->method('withAttribute')
142			->willReturn($this->request);
143
144			$result = $this->middleware->__invoke($this->request, $this->response, $this->nextMiddleware);
145			self::assertSame($nextReturnValue, $result);
146			}
147			}
148

jakubigla / PSR7Auth

Issues (9)

Security Analysis no request data

test/Middleware/AuthenticationMiddlewareTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like