jakim / ig-monitoring

components/MediaManager.php

<?php
/**
 * Created for IG Monitoring.
 * User: jakim <pawel@jakimowski.info>
 * Date: 12.01.2018
 */

namespace app\components;


use app\components\traits\FindOrCreateTrait;
use app\components\builders\MediaBuilder;
use app\models\Account;
use app\models\Media;
use jakim\ig\Text;
use Yii;
use yii\base\Component;

class MediaManager extends Component
{
    use FindOrCreateTrait;

    /**
     * @var \app\models\Account
     */
    public $account;

    /**
     * @param \app\models\Account $account
     * @param \app\components\instagram\models\Post[]
     * @throws \yii\base\InvalidConfigException
     */
    public function addToAccount(Account $account, array $posts)
    {
        foreach ($posts as $post) {
            /** @var Media $media */
            $media = $this->findOrCreate([
                'account_id' => $account->id,
                'shortcode' => $post->shortcode,
            ], Media::class);
            /** @var \app\components\builders\MediaBuilder $updater */
            $updater = Yii::createObject([
                'class' => MediaBuilder::class,
                'media' => $media,
            ]);
            $updater->setDetails($post)
                ->save();

            $this->saveRelatedData($media, $account);
        }
    }

    protected function saveRelatedData(Media $media, Account $account)
    {
        if (empty($media->caption)) {
            return false;
        }

        $tags = (array) Text::getTags($media->caption);
        if ($tags) {

The expression $tags of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $manager = Yii::createObject(TagManager::class);
            $manager->addToMedia($media, $tags);
        }

        $usernames = (array) Text::getUsernames($media->caption);
        if ($usernames) {

The expression $usernames of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            // ignore owner of media
            ArrayHelper::removeValue($usernames, $account->username);

            $manager = Yii::createObject(AccountManager::class);
            $manager->addToMedia($media, $usernames);
        }

        return true;
    }
}