app\components\stats\providers\AccountDiffDataProvider::prepareModels()

Complexity

Conditions	6
Paths	12

Size

Total Lines	33
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function prepareModels()
    {
        $models = [];

        $dbFrom = $this->from->copy();
        switch ($this->grouping) {
            case Grouping::MONTHLY:
                $dbFrom = $dbFrom->subMonth()->endOfMonth();
                break;
            case Grouping::WEEKLY:
                $dbFrom = $dbFrom->subWeek()->endOfWeek();
                break;
            case Grouping::DAILY:
            default:
                $dbFrom = $dbFrom->subDay()->endOfDay();
        }
        $dbFrom = $this->findDbDate($dbFrom);

        $dbTo = $this->to->copy()->endOfDay()->toDateTimeString();

        $idsQuery = $this->findStatsIds($dbFrom, $dbTo, false);

It seems like $dbFrom can also be of type false; however, parameter $dbFrom of app\components\stats\providers\AccountDataProvider::findStatsIds() does only seem to accept null|string, maybe add an additional type check?

        $data = $this->findDataModels($idsQuery);

        $older = array_shift($data);
        foreach ($data as $stats) {
            foreach ($this->statsAttributes as $statsAttribute) {
                $value = ArrayHelper::getValue($stats, $statsAttribute, 0) - ArrayHelper::getValue($older, $statsAttribute, 0);
                $models[$stats['created_at']][$statsAttribute] = $value;
            }
            $older = $stats;
        }

        return $models;
    }
}