app\components\stats\AccountDaily

Complexity

Total Complexity

6

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	initDiff()	0	35	4
A	get()	0	3	1

<?php
/**
 * Created for IG Monitoring.
 * User: jakim <pawel@jakimowski.info>
 * Date: 19.06.2018
 */

namespace app\components\stats;


use app\models\Account;
use app\models\AccountStats;
use Carbon\Carbon;
use yii\base\Component;
use yii\db\Expression;
use yii\helpers\ArrayHelper;

class AccountDaily extends Component
{
    /**
     * @var \app\models\Account
     */
    public $model;

    private $statsAttributes = [
        'media',
        'followed_by',
        'follows',
        'er',
    ];

    private static $cache = [];

    public function __construct(Account $model, array $config = [])
    {
        $this->model = $model;
        static::$cache = [];

Since $cache is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $cache to at least protected.

        parent::__construct($config);
    }

    public function get()
    {
        return static::$cache;

Since $cache is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $cache to at least protected.

    }

    /**
     * The difference between the data from subsequent days from a given date range.
     *
     * @param $olderDate
     * @param null $newerDate

Are you sure the doc-type for parameter $newerDate is correct as it would always require null to be passed?

     * @return \app\components\stats\AccountDaily
     */
    public function initDiff($olderDate, $newerDate = null)
    {
        $olderDate = (new Carbon($olderDate))->startOfDay()->toDateTimeString();
        $newerDate = (new Carbon($newerDate))->endOfDay()->toDateTimeString();

        if (empty(static::$cache)) {

Since $cache is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $cache to at least protected.

            //group by DATE Y-m-d
            $ids = AccountStats::find()
                ->select(new Expression('MAX(id) as id'))
                ->andWhere(['account_id' => $this->model->id])
                ->andWhere(['>=', 'created_at', $olderDate])
                ->andWhere(['<=', 'created_at', $newerDate])
                ->groupBy(new Expression('DATE(created_at)'))
                ->column();

            $stats = AccountStats::find()
                ->select([
                    'account_stats.*',
                    new Expression('DATE(created_at) as created_at'),
                ])
                ->andWhere(['account_id' => $this->model->id])
                ->andWhere(['id' => $ids])
                ->orderBy('id ASC')
                ->asArray()
                ->all();

            foreach ($stats as $stat) {
                foreach ($this->statsAttributes as $statsAttribute) {
                    $value = ArrayHelper::getValue($stat, $statsAttribute, 0);
                    static::$cache[$stat['created_at']][$statsAttribute] = $value;
                }
            }
        }

        return $this;
    }
}