app\commands\AdminController::actionDictionaries()

Complexity

Conditions	6
Paths	7

Size

Total Lines	33
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function actionDictionaries()
    {
        $dictionaries = [
            AccountInvalidationType::class,
            TagInvalidationType::class,
        ];

        /** @var \app\dictionaries\Dictionary $dictionary */
        foreach ($dictionaries as $dictionary) {
            $this->stdout("$dictionary\n");

            $modelClass = '\\app\\models\\' . StringHelper::basename($dictionary);
            if (!class_exists($modelClass)) {
                $this->stderr("ERR: '$modelClass'\n");

                return ExitCode::UNSPECIFIED_ERROR;
            }

            foreach ($dictionary::labels() as $id => $name) {
                /** @var \yii\db\ActiveRecord $modelClass */
                $model = $modelClass::findOne($id);
                if ($model === null) {
                    $model = new $modelClass();
                    $model->id = $id;
                }
                $model->name = $name;

The property name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                /** @var \yii\db\ActiveRecord $model */
                if (!$model->save()) {
                    echo Console::errorSummary($model);

                    return ExitCode::DATAERR;
                }
                $this->stdout("$id => $name\n");
            }
}