app\modules\admin\widgets\favorites\SideMenu

Complexity

Total Complexity

10

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	5	1
A	renderItem()	0	26	2
A	run()	0	19	3
A	isItemActive()	0	16	4

<?php
/**
 * Created for IG Monitoring.
 * User: jakim <pawel@jakimowski.info>
 * Date: 01.02.2018
 */

namespace app\modules\admin\widgets\favorites;


use app\components\ArrayHelper;
use app\models\Favorite;
use app\modules\admin\widgets\AjaxButton;
use dmstr\widgets\Menu;
use Yii;
use yii\helpers\Url;

class SideMenu extends Menu
{
    public $encodeLabels = false;
    public $linkTemplate = '<a href="{url}">{icon} {label} {btn-delete}</a>';

    public function init()
    {
        $this->options = ['class' => 'sidebar-menu tree favorites', 'data-widget' => 'tree'];
        $this->defaultIconHtml = '<i class="fa fa-star"></i> ';
        parent::init();
    }

    public function run()
    {
        $favorites = Favorite::find()
            ->andWhere([
                'user_id' => Yii::$app->user->id,
            ])
            ->orderBy('label ASC')
            ->all();
        foreach ($favorites as $favorite) {
            $this->items[] = [
                'label' => $favorite->label,

Accessing label on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

                'url' => $favorite->url,

Accessing url on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

                'id' => $favorite->id,

Accessing id on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            ];
        }
        if ($this->items) {

The expression $this->items of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            array_unshift($this->items, ['label' => 'Favorites', 'options' => ['class' => 'header']]);
        }
        parent::run();
    }

    protected function isItemActive($item)
    {
        if (!isset($item['url'])) {
            return false;
        }

        if ($item['url'] == Url::current()) {
            return true;
        }
        if (isset($item['url'])) {
            $url = Url::to(["/admin/{$this->view->context->id}/dashboard", 'id' => Yii::$app->request->get('id')]);

Accessing id on the interface yii\base\ViewContextInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $item['url'] == $url;
        }

        return false;
    }

    protected function renderItem($item)
    {
        $tmp = $this->linkTemplate;
        $id = ArrayHelper::getValue($item, 'id');
        $btnDelete = '';
        if ($id) {
            $btnDelete = AjaxButton::widget([
                'confirm' => true,
                'tag' => 'span',
                'text' => '<i class="fa fa-trash-o pull-right delete"></i>',
                'url' => ['favorite/delete', 'id' => $id],
                'options' => [
                    'class' => 'pull-right-container',
                    'data' => [
                        'style' => 'slide-right',
                    ],
                ],
            ]);
        }

        $this->linkTemplate = str_replace('{btn-delete}', $btnDelete, $this->linkTemplate);

        $html = parent::renderItem($item);
        $this->linkTemplate = $tmp;

        return $html;
    }
}