app\modules\admin\widgets\OnOffMonitoringButton

Complexity

Total Complexity

9

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	7	2
A	getIdent()	0	13	3
A	run()	0	29	4

<?php
/**
 * Created for IG Monitoring.
 * User: jakim <pawel@jakimowski.info>
 * Date: 06.02.2018
 */

namespace app\modules\admin\widgets;


use app\components\ArrayHelper;
use app\dictionaries\TrackerType;
use app\models\Tag;
use app\modules\admin\models\MonitoringForm;
use yii\base\Widget;
use yii\helpers\Url;

class OnOffMonitoringButton extends Widget
{
    /**
     * @var \app\models\Tag|\app\models\Account
     */
    public $model;
    public $form;
    public $btnCssClass = 'btn btn-block';
    public $stopBtnCssClass = 'btn-danger';
    public $startBtnCssClass = 'btn-success';
    public $stopBtnLabel = '<span class="fa fa-stop"></span> Turn off monitoring';
    public $startBtnLabel = '<span class="fa fa-play"></span> Turn on monitoring';

    public $offAjaxOptions = [];

    protected $trackerType = TrackerType::ACCOUNT;

    public function init()
    {
        parent::init();
        if ($this->model instanceof Tag) {
            $this->trackerType = TrackerType::TAG;
        } else {
            $this->trackerType = TrackerType::ACCOUNT;
        }
    }

    public function run()
    {
        if ($this->model->monitoring) {
            return AjaxButton::widget([
                'confirm' => true,
                'url' => Url::to(["monitoring/delete-{$this->trackerType}", 'id' => $this->model->id]),
                'options' => [
                    'class' => "{$this->btnCssClass} {$this->stopBtnCssClass}",
                    'data' => [
                        'style' => 'slide-right',
                    ],
                ],
                'text' => $this->stopBtnLabel,
                'ajaxOptions' => $this->offAjaxOptions,
            ]);
        }

        $form = $this->form ?: new MonitoringForm([
            'scenario' => $this->trackerType,
            'names' => $this->getIdent(),
            'categories' => $this->trackerType == TrackerType::ACCOUNT ? ArrayHelper::getColumn($this->model->categories, 'name') : null,

The property categories does not exist on app\models\Tag. Since you implemented __get, consider adding a @property annotation.

        ]);

        return CreateMonitoringModal::widget([
            'form' => $form,
            'trackerType' => $this->trackerType,
            'modalToggleButton' => [
                'class' => "{$this->btnCssClass} {$this->startBtnCssClass}",
                'label' => $this->startBtnLabel,
            ],
        ]);
    }

    protected function getIdent(): string
    {
        switch ($this->trackerType) {
            case TrackerType::ACCOUNT:
                $ident = 'username';
                break;
            case TrackerType::TAG:
            default:
                $ident = 'name';
                break;
        }

        return ArrayHelper::getValue($this->model, $ident);

The expression return app\components\ArrayHelper::getValue($this->model, $ident) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}