app\components\instagram\AccountScraper

Complexity

Total Complexity

4

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Importance

Changes	3
Bugs	2	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchOne()	0	22	1
A	fetchLastPosts()	0	7	1
A	fetchProfilePicIfNeeded()	0	18	2

<?php
/**
 * Created for IG Monitoring.
 * User: jakim <pawel@jakimowski.info>
 * Date: 11.01.2018
 */

namespace app\components\instagram;


use app\components\instagram\base\Scraper;
use app\components\instagram\contracts\AccountScraperInterface;
use app\components\instagram\models\Account as IgAccount;
use Jakim\Query\AccountQuery;
use Yii;

class AccountScraper extends Scraper implements AccountScraperInterface
{
    /**
     * @param string $ident username or id
     * @return \app\components\instagram\models\Account|null
     */
    public function fetchOne(string $ident): ?IgAccount
    {
        $query = new AccountQuery($this->httpClient);
        $account = $query->findOne($ident);
        $profilePic = $this->fetchProfilePicIfNeeded($account->username, $account->profilePicUrl);

        $model = new IgAccount();
        $model->id = $account->id;
        $model->username = $account->username;
        $model->profilePicUrl = $profilePic;
        $model->fullName = $account->fullName;
        $model->biography = $account->biography;
        $model->externalUrl = $account->externalUrl;
        $model->followedBy = $account->followedBy;
        $model->follows = $account->follows;
        $model->media = $account->media;
        $model->isPrivate = $account->isPrivate;
        $model->isVerified = $account->isVerified;
        $model->isBusiness = $account->isBusiness;
        $model->businessCategory = $account->businessCategory;

        return $model;
    }

    /**
     * @param string $username
     * @return \app\components\instagram\models\Post[]
     * @throws \Jakim\Exception\EmptyContentException
     * @throws \Jakim\Exception\RestrictedProfileException
     */
    public function fetchLastPosts(string $username): array
    {
        $query = new AccountQuery($this->httpClient);
        $posts = $query->findLastPosts($username, 10);
        $posts = $this->preparePosts($posts);

        return $posts;
    }

    private function fetchProfilePicIfNeeded($username, $profilePicUrl)
    {
        $username = strtolower($username);
        $filename = sprintf('%s_%s', $username, basename($profilePicUrl));
        $filename = explode('?', $filename)['0'];
        $path = sprintf('/uploads/%s', substr($username, 0, 2));

        $fullPath = Yii::getAlias("@app/web/{$path}");
        @mkdir($fullPath);

It seems like you do not handle an error condition for mkdir(). This can introduce security issues, and is generally not recommended.

        @chmod($fullPath, 0777);

It seems like you do not handle an error condition for chmod(). This can introduce security issues, and is generally not recommended.

        $file = "{$fullPath}/{$filename}";
        if (!file_exists($file)) {
            $content = $this->httpClient->get($profilePicUrl)->getBody()->getContents();
            file_put_contents($file, $content);
        }

        return "{$path}/{$filename}";
    }
}