Issues in Valitron.php (master) - Issues in master - jacques/php-validators - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Valitron.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Validations reworked for use with Valitron.
 *
 * @author Jacques Marneweck <[email protected]>
 * @copyright 2002-2018 Jacques Marneweck.  All rights strictly reserved.
 */

namespace Jacques\Validators;

use Carbon\Carbon;

class Valitron
{
    public static function addrules()
    {
        \Valitron\Validator::addRule('street_address', function ($field, $value, array $params, array $fields) {

            return !preg_match('/^(Private Bag X\d+|P\.?O\.?\s?Box\s\d+).*$/i', $value);
        }, 'must be a physical street address');

        /**
         * Validate the possibility of a mobile number being a valid Namibian Mobile Number.
         */
        \Valitron\Validator::addRule('na_mobile_number', function ($field, $value, array $params, array $fields) {

            $msisdn = str_replace(array(' ', '-', '(', ')'), '', $value);
            $country = 'NA';

            $phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
            try {
                $phoneNumberProto = $phoneUtil->parse($msisdn, $country);
            } catch (\libphonenumber\NumberParseException $e) {
                return false;
            }

            if (!$phoneUtil->isValidNumber($phoneNumberProto)) {
                return false;
            }

            if (
                !in_array(
                    $phoneUtil->getNumberType($phoneNumberProto),
                    [
                        1,
                        2,
                    ]
                )
            ) {
                return false;
            }

            if (
                !is_null($country)
            ) {
                if ($country == $phoneUtil->getRegionCodeForNumber($phoneNumberProto)) {
                    return true;
                }

                return false;
            }

            return true;
        }, 'must be a valid Namibian Mobile Number');

        /**
         * Validate the possibility of the South African Identity Number beng a valid South
         * African identity number.
         */
        \Valitron\Validator::addRule('za_identity_number', function ($field, $value, array $params, array $fields) {

            if (!ctype_digit($value)) {
                return false;
            }

            $match = preg_match("!^(\d{2})(\d{2})(\d{2})\d\d{6}$!", $value, $matches);
            if (!$match) {
                return false;
            }
            list(, $year, $month, $day) = $matches;
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

            /**
             * Check citizenship of the users id (0 = .za, 1 = permanent resident)
             */
            if (!in_array($value{10}, array(0, 1))) {
                return false;
            }

            /**
             * Seen 8 or 9 here.
             */
            if (!in_array($value{11}, [8, 9])) {
                return false;
            }

            $idvalid = \PayBreak\Luhn\Luhn::validateNumber($value);

            return ($idvalid);
        }, 'must be a valid South African Identity Number');

        /**
         * Validate the possibility of a mobile number being a valid South African Mobile Number.
         */
        \Valitron\Validator::addRule('za_mobile_number', function ($field, $value, array $params, array $fields) {

            $msisdn = str_replace(array(' ', '-', '(', ')'), '', $value);
            $country = 'ZA';

            $phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
            try {
                $phoneNumberProto = $phoneUtil->parse($msisdn, $country);
            } catch (\libphonenumber\NumberParseException $e) {
                return false;
            }

            if (!$phoneUtil->isValidNumber($phoneNumberProto)) {
                return false;
            }

            if (
                !in_array(
                    $phoneUtil->getNumberType($phoneNumberProto),
                    [
                        1,
                        2,
                    ]
                )
            ) {
                return false;
            }

            if (
                !is_null($country)
            ) {
                if ($country == $phoneUtil->getRegionCodeForNumber($phoneNumberProto)) {
                    return true;
                }

                return false;
            }

            return true;
        }, 'must be a valid South African Mobile Number');
    }
}


1		<?php
2		/**
3		* Validations reworked for use with Valitron.
4		*
5		* @author Jacques Marneweck <[email protected]>
6		* @copyright 2002-2018 Jacques Marneweck. All rights strictly reserved.
7		*/
8
9		namespace Jacques\Validators;
10
11		use Carbon\Carbon;
12
13		class Valitron
14		{
15		public static function addrules()
16		{
17		\Valitron\Validator::addRule('street_address', function ($field, $value, array $params, array $fields) {
		0 ignored issues – show Unused Code introduced 2018-05-10 22:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-05-10 22:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$fields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
18		return !preg_match('/^(Private Bag X\d+\|P\.?O\.?\s?Box\s\d+).*$/i', $value);
19		}, 'must be a physical street address');
20
21		/**
22		* Validate the possibility of a mobile number being a valid Namibian Mobile Number.
23		*/
24	View Code Duplication	\Valitron\Validator::addRule('na_mobile_number', function ($field, $value, array $params, array $fields) {
		0 ignored issues – show Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$fields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2018-05-10 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		$msisdn = str_replace(array(' ', '-', '(', ')'), '', $value);
26		$country = 'NA';
27
28		$phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
29		try {
30		$phoneNumberProto = $phoneUtil->parse($msisdn, $country);
31		} catch (\libphonenumber\NumberParseException $e) {
32		return false;
33		}
34
35		if (!$phoneUtil->isValidNumber($phoneNumberProto)) {
36		return false;
37		}
38
39		if (
40		!in_array(
41		$phoneUtil->getNumberType($phoneNumberProto),
42		[
43		1,
44		2,
45		]
46		)
47		) {
48		return false;
49		}
50
51		if (
52		!is_null($country)
53		) {
54		if ($country == $phoneUtil->getRegionCodeForNumber($phoneNumberProto)) {
55		return true;
56		}
57
58		return false;
59		}
60
61		return true;
62		}, 'must be a valid Namibian Mobile Number');
63
64		/**
65		* Validate the possibility of the South African Identity Number beng a valid South
66		* African identity number.
67		*/
68		\Valitron\Validator::addRule('za_identity_number', function ($field, $value, array $params, array $fields) {
		0 ignored issues – show Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$fields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
69		if (!ctype_digit($value)) {
70		return false;
71		}
72
73		$match = preg_match("!^(\d{2})(\d{2})(\d{2})\d\d{6}$!", $value, $matches);
74		if (!$match) {
75		return false;
76		}
77		list(, $year, $month, $day) = $matches;
		0 ignored issues – show Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$year` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history... Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$month` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history... Unused Code introduced 2018-05-05 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$day` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
78
79		/**
80		* Check citizenship of the users id (0 = .za, 1 = permanent resident)
81		*/
82		if (!in_array($value{10}, array(0, 1))) {
83		return false;
84		}
85
86		/**
87		* Seen 8 or 9 here.
88		*/
89		if (!in_array($value{11}, [8, 9])) {
90		return false;
91		}
92
93		$idvalid = \PayBreak\Luhn\Luhn::validateNumber($value);
94
95		return ($idvalid);
96		}, 'must be a valid South African Identity Number');
97
98		/**
99		* Validate the possibility of a mobile number being a valid South African Mobile Number.
100		*/
101	View Code Duplication	\Valitron\Validator::addRule('za_mobile_number', function ($field, $value, array $params, array $fields) {
		0 ignored issues – show Unused Code introduced 2018-05-10 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-05-10 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$fields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2018-05-10 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		$msisdn = str_replace(array(' ', '-', '(', ')'), '', $value);
103		$country = 'ZA';
104
105		$phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
106		try {
107		$phoneNumberProto = $phoneUtil->parse($msisdn, $country);
108		} catch (\libphonenumber\NumberParseException $e) {
109		return false;
110		}
111
112		if (!$phoneUtil->isValidNumber($phoneNumberProto)) {
113		return false;
114		}
115
116		if (
117		!in_array(
118		$phoneUtil->getNumberType($phoneNumberProto),
119		[
120		1,
121		2,
122		]
123		)
124		) {
125		return false;
126		}
127
128		if (
129		!is_null($country)
130		) {
131		if ($country == $phoneUtil->getRegionCodeForNumber($phoneNumberProto)) {
132		return true;
133		}
134
135		return false;
136		}
137
138		return true;
139		}, 'must be a valid South African Mobile Number');
140		}
141		}
142

jacques / php-validators

Issues (21)

Security Analysis no request data

src/Valitron.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like