Jacques\Validators\Valitron::addrules()

Complexity

Conditions	10
Paths	1

Size

Total Lines	79
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    static public function addrules()

As per PSR2, the static declaration should come after the visibility declaration.

    {
        /**
         * Validate the possibility of the South African Identity Number beng a valid South
         * African identity number.
         */
        \Valitron\Validator::addRule('za_identity_number', function($field, $value, array $params, array $fields) {

The parameter $params is not used and could be removed.

The parameter $fields is not used and could be removed.

            if (!ctype_digit($value)) {
                return false;
            }

            $match = preg_match("!^(\d{2})(\d{2})(\d{2})\d\d{6}$!", $value, $matches);
            if (!$match) {
                return false;
            }
            list (, $year, $month, $day) = $matches;

The assignment to $year is unused. Consider omitting it like so list($first,,$third).

The assignment to $month is unused. Consider omitting it like so list($first,,$third).

The assignment to $day is unused. Consider omitting it like so list($first,,$third).

            /**
             * Check citizenship of the users id (0 = .za, 1 = permanent resident)
             */
            if (!in_array($value{10}, array(0, 1))) {
                return false;
            }

            /**
             * Seen 8 or 9 here.
             */
            if (!in_array($value{11}, [8, 9])) {
                return false;
            }

            $idvalid = \PayBreak\Luhn\Luhn::validateNumber($value);

            return ($idvalid);
        }, 'must be a valid South African Identity Number');

        /**
         * Validate the possibility of a mobile number being a valid South African Mobile Number.
         */
        \Valitron\Validator::addRule('za_mobile_number', function($field, $value, array $params, array $fields) {

The parameter $params is not used and could be removed.

The parameter $fields is not used and could be removed.

            $msisdn = str_replace(array(' ', '-', '(', ')'), '', $value);
            $country = 'ZA';

            $phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
            try {
                $phoneNumberProto = $phoneUtil->parse($msisdn, $country);
            } catch (\libphonenumber\NumberParseException $e) {
                return false;
            }

            if (!$phoneUtil->isValidNumber($phoneNumberProto)) {
                return false;
            }

            if (
                !in_array(
                    $phoneUtil->getNumberType($phoneNumberProto),
                    [
                        1,
                        2,
                    ]
                )
            ) {
                return false;
            }

            if (
                !is_null($country)
            ) {
                if ($country == $phoneUtil->getRegionCodeForNumber($phoneNumberProto)) {
                    return true;
                }

                return false;
            }

            return true;
        }, 'must be a valid South African Mobile Number');
    }
}