Birthdate::is_valid_for_id() - Code Metrics - jacques/php-validators - Measure and Improve Code Quality continuously with Scrutinizer

Birthdate::is_valid_for_id() B
last analyzed 2019-03-12 22:53 UTC

↳ Parent: Birthdate

Complexity

Conditions	6
Paths	10

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
nc	10
nop	2
dl	0
loc	31
rs	8.8017
c	0
b	0
f	0

<?php
/**
 * Birthdate Validation
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license.
 *
 * @author    Jacques Marneweck <[email protected]>
 * @copyright 2015-2016 Jacques Marneweck.  All rights strictly reserved.
 * @license   MIT
 */

namespace Jacques\Validators;

use Carbon\Carbon;

class Birthdate
{
    public static function is_valid($birthdate)
    {
        try {
            $date = Carbon::createFromFormat('Y-m-d', $birthdate, 'UTC');
            if ($date->toDateString() === $birthdate) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                return true;
            }

            return false;
        } catch (\Exception $e) {
            return false;
        }
    }

    public static function is_valid_for_id($birthdate, $id)
    {
        $match = preg_match("!^(\d{2})(\d{2})(\d{2})\d\d{6}$!", $id, $matches);
        if (!$match) {
            return false;
        }
        list(, $year, $month, $day) = $matches;
        /**
         * Check that the date is valid
         */
        if (!Birthdate::is_valid($birthdate)) {
            return false;
        }

        if ($year > 23) {
            $year += 1900;
        } else {
            $year += 2000;
        }

        try {
            $date = Carbon::createFromFormat('Y-m-d', vsprintf("%d-%d-%d", [$year, $month, $day]), 'UTC');
            if ($date->toDateString() === $birthdate) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                return true;
            }

            return false;
        } catch (\Exception $e) {
            return false;
        }
    }
}


Birthdate::is_valid_for_id() B
last analyzed 2019-03-12 22:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Birthdate Validation
4			*
5			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
6			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
7			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
8			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
9			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
10			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
11			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
12			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
13			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
14			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
15			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
16			*
17			* This software consists of voluntary contributions made by many individuals
18			* and is licensed under the MIT license.
19			*
20			* @author Jacques Marneweck <[email protected]>
21			* @copyright 2015-2016 Jacques Marneweck. All rights strictly reserved.
22			* @license MIT
23			*/
24
25			namespace Jacques\Validators;
26
27			use Carbon\Carbon;
28
29			class Birthdate
30			{
31			public static function is_valid($birthdate)
32			{
33			try {
34			$date = Carbon::createFromFormat('Y-m-d', $birthdate, 'UTC');
35			if ($date->toDateString() === $birthdate) {
			0 ignored issues – show Bug introduced 2019-03-12 22:53 UTC by Report Bug Copy Issue Report The method `toDateString` does only exist in `Carbon\CarbonInterface`, but not in `Carbon\Traits\Creator`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
36			return true;
37			}
38
39			return false;
40			} catch (\Exception $e) {
41			return false;
42			}
43			}
44
45			public static function is_valid_for_id($birthdate, $id)
46			{
47			$match = preg_match("!^(\d{2})(\d{2})(\d{2})\d\d{6}$!", $id, $matches);
48			if (!$match) {
49			return false;
50			}
51			list(, $year, $month, $day) = $matches;
52			/**
53			* Check that the date is valid
54			*/
55			if (!Birthdate::is_valid($birthdate)) {
56			return false;
57			}
58
59			if ($year > 23) {
60			$year += 1900;
61			} else {
62			$year += 2000;
63			}
64
65			try {
66			$date = Carbon::createFromFormat('Y-m-d', vsprintf("%d-%d-%d", [$year, $month, $day]), 'UTC');
67			if ($date->toDateString() === $birthdate) {
			0 ignored issues – show Bug introduced 2019-03-12 22:53 UTC by Report Bug Copy Issue Report The method `toDateString` does only exist in `Carbon\CarbonInterface`, but not in `Carbon\Traits\Creator`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
68			return true;
69			}
70
71			return false;
72			} catch (\Exception $e) {
73			return false;
74			}
75			}
76			}
77

jacques / php-validators

Birthdate::is_valid_for_id() B last analyzed 2019-03-12 22:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Birthdate::is_valid_for_id() B
last analyzed 2019-03-12 22:53 UTC