jacques /
php-smartcall-httpclient
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | trait SmartLoad |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * Authenticate and retrieves the dealer balance in Rands. |
||
| 19 | * |
||
| 20 | * @param string $dealerMsisdn |
||
| 21 | * |
||
| 22 | * @throws Exception |
||
| 23 | * |
||
| 24 | * @return array |
||
| 25 | */ |
||
| 26 | 4 | View Code Duplication | public function balance($dealerMsisdn) |
| 52 | |||
| 53 | /** |
||
| 54 | * Authenticate and request to cancel a previous recharge request. Will only |
||
| 55 | * succeed if the recharge has not been successfully submitted to the network. |
||
| 56 | * |
||
| 57 | * @param string $dealerMsisdn |
||
| 58 | * @param string $clientReference |
||
| 59 | * |
||
| 60 | * @throws Exception |
||
| 61 | * |
||
| 62 | * @return array |
||
| 63 | */ |
||
| 64 | 3 | View Code Duplication | public function cancelRecharge($dealerMsisdn, $clientReference) |
| 65 | { |
||
| 66 | try { |
||
| 67 | 3 | $response = $this->delete( |
|
| 68 | 3 | sprintf( |
|
| 69 | 3 | '/webservice/smartload/recharges/%s/%s', |
|
| 70 | 3 | $dealerMsisdn, |
|
| 71 | 3 | $clientReference |
|
| 72 | ), |
||
| 73 | [ |
||
| 74 | 'headers' => [ |
||
| 75 | 3 | 'Authorization' => $this->bearerOrBasic(), |
|
| 76 | ], |
||
| 77 | ] |
||
| 78 | ); |
||
| 79 | |||
| 80 | return [ |
||
| 81 | 1 | 'status' => 'ok', |
|
| 82 | 1 | 'http_code' => $response->getStatusCode(), |
|
| 83 | 1 | 'body' => (string) $response->getBody(), |
|
| 84 | ]; |
||
| 85 | 2 | } catch (\GuzzleHttp\Exception\ClientException $e) { |
|
| 86 | 2 | return $this->clientError($e); |
|
| 87 | } catch (\GuzzleHttp\Exception\ServerException $e) { |
||
| 88 | return $this->parseError($e); |
||
| 89 | } |
||
| 90 | } |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Authenticate and request period based cashup reports. |
||
| 94 | * |
||
| 95 | * @param string $dealerMsisdn |
||
| 96 | * @param string $start |
||
| 97 | * @param string $end |
||
| 98 | * |
||
| 99 | * @throws Exception |
||
| 100 | * |
||
| 101 | * @return array |
||
| 102 | */ |
||
| 103 | View Code Duplication | public function cashup($dealerMsisdn, $start, $end) |
|
| 131 | |||
| 132 | /** |
||
| 133 | * Authenticate and request current day cashup report. |
||
| 134 | * |
||
| 135 | * @param string $dealerMsisdn |
||
| 136 | * |
||
| 137 | * @throws Exception |
||
| 138 | * |
||
| 139 | * @return array |
||
| 140 | */ |
||
| 141 | View Code Duplication | public function cashupToday($dealerMsisdn) |
|
| 167 | |||
| 168 | /** |
||
| 169 | * Authenticate and request to transfer funds from one Smartload account to another. |
||
| 170 | * |
||
| 171 | * @param string $fromDealerMsisdn |
||
| 172 | * @param string $toDealerMsisdn |
||
| 173 | * @param string $amount |
||
| 174 | * @param string $sendSms |
||
| 175 | * |
||
| 176 | * @throws Exception |
||
| 177 | * |
||
| 178 | * @return array |
||
| 179 | */ |
||
| 180 | 3 | View Code Duplication | public function fundstransfer($fromDealerMsisdn, $toDealerMsisdn, $amount, $sendSms) |
| 209 | |||
| 210 | /** |
||
| 211 | * Authenticate and retrieves a list of all available networks. |
||
| 212 | * |
||
| 213 | * @throws Exception |
||
| 214 | * |
||
| 215 | * @return array |
||
| 216 | */ |
||
| 217 | 2 | View Code Duplication | public function network($id) |
| 243 | |||
| 244 | /** |
||
| 245 | * Authenticate and retrieves a list of all available networks. |
||
| 246 | * |
||
| 247 | * @throws Exception |
||
| 248 | * |
||
| 249 | * @return array |
||
| 250 | */ |
||
| 251 | 2 | View Code Duplication | public function networks() |
| 274 | |||
| 275 | /** |
||
| 276 | * Authenticate and recharge prevend request. |
||
| 277 | * |
||
| 278 | * @param string $dealerMsisdn |
||
| 279 | * @param string $clientReference |
||
| 280 | * @param string $smsRecipientMsisdn |
||
| 281 | * @param string $deviceId |
||
| 282 | * @param int $productId |
||
| 283 | * @param int $amount |
||
| 284 | * @param bool $pinless |
||
| 285 | * @param bool $sendSms |
||
| 286 | */ |
||
| 287 | 2 | View Code Duplication | public function prevend($dealerMsisdn, $clientReference, $smsRecipientMsisdn, $deviceId, $productId, $amount, $pinless, $sendSms) |
| 320 | |||
| 321 | /** |
||
| 322 | * Authenticate and retrieves a list of all available networks. |
||
| 323 | * |
||
| 324 | * @param int $id |
||
| 325 | * |
||
| 326 | * @throws Exception |
||
| 327 | * |
||
| 328 | * @return array |
||
| 329 | */ |
||
| 330 | 2 | View Code Duplication | public function products($id) |
| 356 | |||
| 357 | /** |
||
| 358 | * Authenticate and recharge request. |
||
| 359 | * |
||
| 360 | * @param string $dealerMsisdn |
||
| 361 | * @param string $clientReference |
||
| 362 | * @param string $smsRecipientMsisdn |
||
| 363 | * @param string $deviceId |
||
| 364 | * @param int $productId |
||
| 365 | * @param int $amount |
||
| 366 | * @param bool $pinless |
||
| 367 | * @param bool $sendSms |
||
| 368 | */ |
||
| 369 | 2 | View Code Duplication | public function recharge($dealerMsisdn, $clientReference, $smsRecipientMsisdn, $deviceId, $productId, $amount, $pinless, $sendSms) |
| 402 | |||
| 403 | /** |
||
| 404 | * Authenticate and checks if the provided ID (MSISDN) is registered with Smartload. |
||
| 405 | * |
||
| 406 | * @param string $dealerMsisdn |
||
| 407 | * |
||
| 408 | * @throws Exception |
||
| 409 | * |
||
| 410 | * @return array |
||
| 411 | */ |
||
| 412 | 3 | View Code Duplication | public function registered($dealerMsisdn) |
| 438 | |||
| 439 | /** |
||
| 440 | * Authenticate and retrieves the details of the transaction that was performed |
||
| 441 | * by the dealer using the Client reference number. |
||
| 442 | * |
||
| 443 | * @param string $dealerMsisdn |
||
| 444 | * @param string $clientReference |
||
| 445 | */ |
||
| 446 | 4 | View Code Duplication | public function transaction($dealerMsisdn, $clientReference) |
| 473 | } |
||
| 474 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.