Utilities - Code Metrics - Inspection of "Move network lookup for sim and network status cal..." - jacques/php-smartcall-httpclient - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 280670...1a4dd3 )

by Jacques

created 2019-08-23 19:52 UTC

Utilities A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	69
Duplicated Lines	71.01 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

83.33%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	0
dl	49
loc	69
ccs	20
cts	24
cp	0.8333
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	health()	23	23	3
A	simnetwork()	26	26	3

How to fix Duplicated Code

<?php declare(strict_types=1);
/**
 * SmartCall Restful API (v3) HTTP Client.
 *
 * PLEASE NOTE: The interface is very fluid while the intial integration
 * is taking place.  It will be refactored in the near future.
 *
 * @author    Jacques Marneweck <[email protected]>
 * @copyright 2017-2019 Jacques Marneweck.  All rights strictly reserved.
 * @license   MIT
 */

namespace Jacques\Smartcall\HttpClient\Traits;

trait Utilities
{
    /**
     * Gets the current connection status to the various mobile networks.
     *
     * @throws Exception
     *
     * @return array
     */
    public function health()

    {
        try {
            $response = $this->get(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                '/webservice/utilities/health',
                [
                    'headers' => [
                        'Authorization' => $this->bearerOrBasic(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                    ],
                ]
            );

            return [
                'status'    => 'ok',
                'http_code' => $response->getStatusCode(),
                'body'      => (string) $response->getBody(),
            ];
        } catch (\GuzzleHttp\Exception\ClientException $e) {

            return $this->clientError($e);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } catch (\GuzzleHttp\Exception\ServerException $e) {

            return $this->parseError($e);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * Gets the mobile network on which the SIM is connected.
     *
     * @param string $msisdn
     *
     * @throws Exception
     *
     * @return array
     */
    public function simnetwork($msisdn)

    {
        try {
            $response = $this->get(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                sprintf(
                    '/webservice/utilities/simnetwork/%d',
                    $msisdn
                ),
                [
                    'headers' => [
                        'Authorization' => $this->bearerOrBasic(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                    ],
                ]
            );

            return [
                'status'    => 'ok',
                'http_code' => $response->getStatusCode(),
                'body'      => (string) $response->getBody(),
            ];
        } catch (\GuzzleHttp\Exception\ClientException $e) {

            return $this->clientError($e);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } catch (\GuzzleHttp\Exception\ServerException $e) {

            return $this->parseError($e);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1			<?php declare(strict_types=1);
2			/**
3			* SmartCall Restful API (v3) HTTP Client.
4			*
5			* PLEASE NOTE: The interface is very fluid while the intial integration
6			* is taking place. It will be refactored in the near future.
7			*
8			* @author Jacques Marneweck <[email protected]>
9			* @copyright 2017-2019 Jacques Marneweck. All rights strictly reserved.
10			* @license MIT
11			*/
12
13			namespace Jacques\Smartcall\HttpClient\Traits;
14
15			trait Utilities
16			{
17			/**
18			* Gets the current connection status to the various mobile networks.
19			*
20			* @throws Exception
21			*
22			* @return array
23			*/
24	3	View Code Duplication	public function health()
			0 ignored issues – show Duplication introduced 2019-02-01 09:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26			try {
27	3		$response = $this->get(
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28	3		'/webservice/utilities/health',
29			[
30			'headers' => [
31	3		'Authorization' => $this->bearerOrBasic(),
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `bearerOrBasic()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			],
33			]
34			);
35
36			return [
37	1		'status' => 'ok',
38	1		'http_code' => $response->getStatusCode(),
39	1		'body' => (string) $response->getBody(),
40			];
41	2		} catch (\GuzzleHttp\Exception\ClientException $e) {
			0 ignored issues – show Bug introduced 2019-08-23 19:45 UTC by Report Bug Copy Issue Report The class `GuzzleHttp\Exception\ClientException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
42	2		return $this->clientError($e);
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `clientError()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			} catch (\GuzzleHttp\Exception\ServerException $e) {
			0 ignored issues – show Bug introduced 2019-08-23 19:45 UTC by Report Bug Copy Issue Report The class `GuzzleHttp\Exception\ServerException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
44			return $this->parseError($e);
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `parseError()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45			}
46			}
47
48			/**
49			* Gets the mobile network on which the SIM is connected.
50			*
51			* @param string $msisdn
52			*
53			* @throws Exception
54			*
55			* @return array
56			*/
57	4	View Code Duplication	public function simnetwork($msisdn)
			0 ignored issues – show Duplication introduced 2019-01-28 14:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58			{
59			try {
60	4		$response = $this->get(
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
61	4		sprintf(
62	4		'/webservice/utilities/simnetwork/%d',
63	4		$msisdn
64			),
65			[
66			'headers' => [
67	4		'Authorization' => $this->bearerOrBasic(),
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `bearerOrBasic()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
68			],
69			]
70			);
71
72			return [
73	2		'status' => 'ok',
74	2		'http_code' => $response->getStatusCode(),
75	2		'body' => (string) $response->getBody(),
76			];
77	2		} catch (\GuzzleHttp\Exception\ClientException $e) {
			0 ignored issues – show Bug introduced 2019-08-23 19:45 UTC by Report Bug Copy Issue Report The class `GuzzleHttp\Exception\ClientException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
78	2		return $this->clientError($e);
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `clientError()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
79			} catch (\GuzzleHttp\Exception\ServerException $e) {
			0 ignored issues – show Bug introduced 2019-08-23 19:45 UTC by Report Bug Copy Issue Report The class `GuzzleHttp\Exception\ServerException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
80			return $this->parseError($e);
			0 ignored issues – show Bug introduced 2019-08-23 19:54 UTC by Report Bug Copy Issue Report It seems like `parseError()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
81			}
82			}
83			}
84

jacques / php-smartcall-httpclient

Push — master ( 280670...1a4dd3 )

Utilities A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like