Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class Client extends \GuzzleHttp\Client |
||
16 | { |
||
17 | /** |
||
18 | * @const string Version number |
||
19 | */ |
||
20 | const VERSION = '0.0.1'; |
||
21 | |||
22 | /** |
||
23 | * Defaults to expecting that Apache Tomcat runs on port 8080 on localhost |
||
24 | * (127.0.0.1). |
||
25 | * |
||
26 | * @var array[] |
||
27 | */ |
||
28 | protected $options = [ |
||
29 | 'scheme' => 'https', |
||
30 | 'hostname' => 'localhost', |
||
31 | 'port' => '8080', |
||
32 | 'token' => null, |
||
33 | 'username' => null, |
||
34 | 'password' => null, |
||
35 | ]; |
||
36 | |||
37 | /** |
||
38 | * @param $options array |
||
39 | */ |
||
40 | 11 | public function __construct($options = []) |
|
63 | |||
64 | /** |
||
65 | * Set the bearer token. |
||
66 | * |
||
67 | * @param string $token Bearer Token from Auth request |
||
68 | */ |
||
69 | 3 | public function setBearerToken($token) |
|
73 | |||
74 | /** |
||
75 | * Authenticate and get Bearer token from SmartCall. |
||
76 | * |
||
77 | * @param string $username |
||
78 | * @param string $password |
||
79 | * |
||
80 | * @throws Exception |
||
81 | * |
||
82 | * @return array |
||
83 | */ |
||
84 | 3 | View Code Duplication | public function auth($username, $password) |
116 | |||
117 | /** |
||
118 | * Authenticate and invalidates all the user allocated tokens. |
||
119 | * |
||
120 | * @throws Exception |
||
121 | * |
||
122 | * @return array |
||
123 | */ |
||
124 | 2 | public function authDelete() |
|
150 | |||
151 | /** |
||
152 | * Authenticate and invalidates all the user allocated tokens. |
||
153 | * |
||
154 | * @param string $username |
||
155 | * @param string $password |
||
156 | * |
||
157 | * @throws Exception |
||
158 | * |
||
159 | * @return array |
||
160 | */ |
||
161 | View Code Duplication | public function authFlush($username, $password) |
|
193 | |||
194 | /** |
||
195 | * Authenticate and gets the number of available session tokens. |
||
196 | * |
||
197 | * @param string $username |
||
198 | * @param string $password |
||
199 | * |
||
200 | * @throws Exception |
||
201 | * |
||
202 | * @return array |
||
203 | */ |
||
204 | 3 | View Code Duplication | public function authToken($username, $password) |
236 | |||
237 | /** |
||
238 | * Test SmartCall is responding. |
||
239 | * |
||
240 | * @throws Exception |
||
241 | * |
||
242 | * @return array |
||
243 | */ |
||
244 | 1 | public function ping() |
|
262 | |||
263 | /** |
||
264 | * Parse the java exception that we receive from Smartcall's Tomcat's. |
||
265 | * |
||
266 | * @param \GuzzleHttp\Exception\ServerException $exception |
||
267 | * |
||
268 | * @return array |
||
269 | */ |
||
270 | 5 | View Code Duplication | private function clientError(\GuzzleHttp\Exception\ClientException $exception) |
280 | |||
281 | /** |
||
282 | * Parse the java exception that we receive from Smartcall's Tomcat's. |
||
283 | * |
||
284 | * @param \GuzzleHttp\Exception\ServerException $exception |
||
285 | * |
||
286 | * @return array |
||
287 | */ |
||
288 | View Code Duplication | private function parseError(\GuzzleHttp\Exception\ServerException $exception) |
|
298 | } |
||
299 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..