OfxParser\Entities\Investment\Transaction\Traits\Pricing

Complexity

Total Complexity

1

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	loadPricing()	0	9	1

<?php

namespace OfxParser\Entities\Investment\Transaction\Traits;

use SimpleXMLElement;

/**
 * Combo for units, price, and total
 */
trait Pricing
{
    /**
     * @var float
     */
    public $units;

    /**
     * @var float
     */
    public $unitPrice;

    /**
     * @var float
     */
    public $total;

    /**
     * Where did the money for the transaction come from or go to?
     * CASH, MARGIN, SHORT, OTHER
     * @var string
     */
    public $subAccountFund;

    /**
     * Sub-account type for the security:
     * CASH, MARGIN, SHORT, OTHER
     * @var string
     */
    public $subAccountSec;

    /**
     * @param SimpleXMLElement $node
     * @return $this for chaining
     */
    protected function loadPricing(SimpleXMLElement $node)
    {
        $this->units = (string) $node->UNITS;

The property $units was declared of type double, but (string)$node->UNITS is of type string. Maybe add a type cast?

        $this->unitPrice = (string) $node->UNITPRICE;

The property $unitPrice was declared of type double, but (string)$node->UNITPRICE is of type string. Maybe add a type cast?

        $this->total = (string) $node->TOTAL;

The property $total was declared of type double, but (string)$node->TOTAL is of type string. Maybe add a type cast?

        $this->subAccountFund = (string) $node->SUBACCTFUND;
        $this->subAccountSec = (string) $node->SUBACCTSEC;

        return $this;
    }
}