MysqlChangelogRepositoryTest::testGetChangesRange() - Code Metrics - Inspection of "Adds more strict checking of returned interface" - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c6be8...89e88a )

by Jacob

created 2016-02-21 04:39 UTC

testGetChangesRange() B

↳ Parent: MysqlChangelogRepositoryTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	33
Code Lines	18

Duplication

Lines	33
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	33
loc	33
rs	8.8571
cc	2
eloc	18
nc	2
nop	0

<?php

namespace Jacobemerick\Web\Domain\Stream\Changelog;

use Aura\Sql\ConnectionLocator;
use Aura\Sql\ExtendedPdo;
use PHPUnit_Framework_TestCase;

class MysqlChangelogRepositoryTest extends PHPUnit_Framework_TestCase
{

    protected static $connection;

    public static function setUpBeforeClass()

    {
        $extendedPdo = new ExtendedPdo('sqlite::memory:');
        $extendedPdo->exec("ATTACH DATABASE `jpemeric_stream.db` AS `jpemeric_stream`");
        $extendedPdo->exec("
            CREATE TABLE IF NOT EXISTS `jpemeric_stream`.`changelog` (
              `id` integer PRIMARY KEY AUTOINCREMENT,
              `hash` char(40) NOT NULL,
              `message` text,
              `message_short` varchar(100),
              `datetime` datetime NOT NULL,
              `author` varchar(50) NOT NULL,
              `commit_link` varchar(100) NOT NULL,
              `created_at` datetime,
              `updated_at` datetime
            )"
        );

        self::$connection = new ConnectionLocator(function () use ($extendedPdo) {
            return $extendedPdo;
        });
    }

    public function testIsInstanceOfChangelogRepository()
    {
        $repository = new MysqlChangelogRepository(self::$connection);

        $this->assertInstanceOf(
            'Jacobemerick\Web\Domain\Stream\Changelog\MysqlChangelogRepository',
            $repository
        );
    }

    public function testImplementsChangelogInterface()
    {
        $repository = new MysqlChangelogRepository(self::$connection);

        $this->assertInstanceOf(
            'Jacobemerick\Web\Domain\Stream\Changelog\ChangelogRepositoryInterface',
            $repository
        );
    }

    public function testConstructSetsConnections()
    {
        $respository = new MysqlChangelogRepository(self::$connection);

        $this->assertAttributeSame(
            self::$connection,
            'connections',
            $respository
        );
    }

    public function testGetChanges()
    {
        $testData = [
            [
                'id' => rand(1, 100),
                'message' => 'test one',
            ],
            [
                'id' => rand(101, 200),
                'message' => 'test two',
            ],
        ];

        array_walk($testData, [$this, 'insertData']);

        $repository = new MysqlChangelogRepository(self::$connection);
        $data = $repository->getChanges();

        $this->assertNotFalse($data);
        $this->assertInternalType('array', $data);
        foreach ($testData as $key => $testRow) {
            $this->assertInternalType('array', $testRow);
            $this->assertArraySubset($testRow, $data[$key]);
            $this->assertArrayHasKey('id', $data[$key]);
            $this->assertArrayHasKey('message', $data[$key]);
            $this->assertArrayHasKey('message_short', $data[$key]);
            $this->assertArrayHasKey('datetime', $data[$key]);
            $this->assertArrayHasKey('commit_link', $data[$key]);
        }
    }

    public function testGetChangesFailure()
    {
        $repository = new MysqlChangelogRepository(self::$connection);
        $data = $repository->getChanges();

        $this->assertEmpty($data);
        $this->assertInternalType('array', $data);
    }

    public function testGetChangesRange()

    {
        $testData = [
            [
                'id' => rand(1, 100),
                'message' => 'test one',
            ],
            [
                'id' => rand(101, 200),
                'message' => 'test two',
            ],
            [
                'id' => rand(201, 300),
                'message' => 'test three',
            ],
        ];

        array_walk($testData, [$this, 'insertData']);

        $repository = new MysqlChangelogRepository(self::$connection);
        $data = $repository->getChanges(2, 1);

        $this->assertNotFalse($data);
        $this->assertInternalType('array', $data);
        $this->assertCount(2, $data);

        $testData = array_slice($testData, 1, 2);

        foreach ($testData as $key => $testRow) {
            $this->assertInternalType('array', $testRow);
            $this->assertArraySubset($testRow, $data[$key]);
        }
    }

    public function testGetChangesRangeFailure()

    {
        $testData = [
            [
                'id' => rand(1, 100),
                'message' => 'test one',
            ],
            [
                'id' => rand(101, 200),
                'message' => 'test two',
            ],
        ];

        array_walk($testData, [$this, 'insertData']);

        $repository = new MysqlChangelogRepository(self::$connection);
        $data = $repository->getChanges(1, 3);

        $this->assertEmpty($data);
        $this->assertInternalType('array', $data);
    }

    protected function tearDown()
    {
        self::$connection->getDefault()->perform("DELETE FROM `jpemeric_stream`.`changelog`");
    }

    public static function tearDownAfterClass()
    {
        self::$connection->getDefault()->disconnect();

        unlink('jpemeric_stream.db');
    }

    protected function insertData(array $data)
    {
        $defaultData = [
            'id' => null,
            'hash' => '',
            'message' => null,
            'message_short' => null,
            'datetime' => '',
            'author' => '',
            'commit_link' => '',
        ];

        $data = array_merge($defaultData, $data);

        return self::$connection->getDefault()->perform("
            INSERT INTO `jpemeric_stream`.`changelog`
                (id, hash, message, message_short, datetime, author, commit_link)
            VALUES
                (:id, :hash, :message, :message_short, :datetime, :author, :commit_link)",
            $data
        );
    }
}


1		<?php
2
3		namespace Jacobemerick\Web\Domain\Stream\Changelog;
4
5		use Aura\Sql\ConnectionLocator;
6		use Aura\Sql\ExtendedPdo;
7		use PHPUnit_Framework_TestCase;
8
9		class MysqlChangelogRepositoryTest extends PHPUnit_Framework_TestCase
10		{
11
12		protected static $connection;
13
14	View Code Duplication	public static function setUpBeforeClass()
		0 ignored issues – show Duplication introduced 2016-02-21 04:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15		{
16		$extendedPdo = new ExtendedPdo('sqlite::memory:');
17		$extendedPdo->exec("ATTACH DATABASE `jpemeric_stream.db` AS `jpemeric_stream`");
18		$extendedPdo->exec("
19		CREATE TABLE IF NOT EXISTS `jpemeric_stream`.`changelog` (
20		`id` integer PRIMARY KEY AUTOINCREMENT,
21		`hash` char(40) NOT NULL,
22		`message` text,
23		`message_short` varchar(100),
24		`datetime` datetime NOT NULL,
25		`author` varchar(50) NOT NULL,
26		`commit_link` varchar(100) NOT NULL,
27		`created_at` datetime,
28		`updated_at` datetime
29		)"
30		);
31
32		self::$connection = new ConnectionLocator(function () use ($extendedPdo) {
33		return $extendedPdo;
34		});
35		}
36
37		public function testIsInstanceOfChangelogRepository()
38		{
39		$repository = new MysqlChangelogRepository(self::$connection);
40
41		$this->assertInstanceOf(
42		'Jacobemerick\Web\Domain\Stream\Changelog\MysqlChangelogRepository',
43		$repository
44		);
45		}
46
47		public function testImplementsChangelogInterface()
48		{
49		$repository = new MysqlChangelogRepository(self::$connection);
50
51		$this->assertInstanceOf(
52		'Jacobemerick\Web\Domain\Stream\Changelog\ChangelogRepositoryInterface',
53		$repository
54		);
55		}
56
57		public function testConstructSetsConnections()
58		{
59		$respository = new MysqlChangelogRepository(self::$connection);
60
61		$this->assertAttributeSame(
62		self::$connection,
63		'connections',
64		$respository
65		);
66		}
67
68		public function testGetChanges()
69		{
70		$testData = [
71		[
72		'id' => rand(1, 100),
73		'message' => 'test one',
74		],
75		[
76		'id' => rand(101, 200),
77		'message' => 'test two',
78		],
79		];
80
81		array_walk($testData, [$this, 'insertData']);
82
83		$repository = new MysqlChangelogRepository(self::$connection);
84		$data = $repository->getChanges();
85
86		$this->assertNotFalse($data);
87		$this->assertInternalType('array', $data);
88		foreach ($testData as $key => $testRow) {
89		$this->assertInternalType('array', $testRow);
90		$this->assertArraySubset($testRow, $data[$key]);
91		$this->assertArrayHasKey('id', $data[$key]);
92		$this->assertArrayHasKey('message', $data[$key]);
93		$this->assertArrayHasKey('message_short', $data[$key]);
94		$this->assertArrayHasKey('datetime', $data[$key]);
95		$this->assertArrayHasKey('commit_link', $data[$key]);
96		}
97		}
98
99		public function testGetChangesFailure()
100		{
101		$repository = new MysqlChangelogRepository(self::$connection);
102		$data = $repository->getChanges();
103
104		$this->assertEmpty($data);
105		$this->assertInternalType('array', $data);
106		}
107
108	View Code Duplication	public function testGetChangesRange()
		0 ignored issues – show Duplication introduced 2016-02-21 04:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		{
110		$testData = [
111		[
112		'id' => rand(1, 100),
113		'message' => 'test one',
114		],
115		[
116		'id' => rand(101, 200),
117		'message' => 'test two',
118		],
119		[
120		'id' => rand(201, 300),
121		'message' => 'test three',
122		],
123		];
124
125		array_walk($testData, [$this, 'insertData']);
126
127		$repository = new MysqlChangelogRepository(self::$connection);
128		$data = $repository->getChanges(2, 1);
129
130		$this->assertNotFalse($data);
131		$this->assertInternalType('array', $data);
132		$this->assertCount(2, $data);
133
134		$testData = array_slice($testData, 1, 2);
135
136		foreach ($testData as $key => $testRow) {
137		$this->assertInternalType('array', $testRow);
138		$this->assertArraySubset($testRow, $data[$key]);
139		}
140		}
141
142	View Code Duplication	public function testGetChangesRangeFailure()
		0 ignored issues – show Duplication introduced 2016-02-21 04:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
143		{
144		$testData = [
145		[
146		'id' => rand(1, 100),
147		'message' => 'test one',
148		],
149		[
150		'id' => rand(101, 200),
151		'message' => 'test two',
152		],
153		];
154
155		array_walk($testData, [$this, 'insertData']);
156
157		$repository = new MysqlChangelogRepository(self::$connection);
158		$data = $repository->getChanges(1, 3);
159
160		$this->assertEmpty($data);
161		$this->assertInternalType('array', $data);
162		}
163
164		protected function tearDown()
165		{
166		self::$connection->getDefault()->perform("DELETE FROM `jpemeric_stream`.`changelog`");
167		}
168
169		public static function tearDownAfterClass()
170		{
171		self::$connection->getDefault()->disconnect();
		0 ignored issues – show Bug introduced 2016-02-21 04:42 UTC by Report Bug Copy Issue Report The method `disconnect()` does not exist on `Aura\Sql\ExtendedPdoInterface`. Did you maybe mean `connect()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
172		unlink('jpemeric_stream.db');
173		}
174
175		protected function insertData(array $data)
176		{
177		$defaultData = [
178		'id' => null,
179		'hash' => '',
180		'message' => null,
181		'message_short' => null,
182		'datetime' => '',
183		'author' => '',
184		'commit_link' => '',
185		];
186
187		$data = array_merge($defaultData, $data);
188
189		return self::$connection->getDefault()->perform("
190		INSERT INTO `jpemeric_stream`.`changelog`
191		(id, hash, message, message_short, datetime, author, commit_link)
192		VALUES
193		(:id, :hash, :message, :message_short, :datetime, :author, :commit_link)",
194		$data
195		);
196		}
197		}
198

jacobemerick / web

Push — master ( 4c6be8...89e88a )

testGetChangesRange() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like