Inspection of "Adds new repository for recent activity and uses i..." - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( be7975...b1edf3 )

by Jacob

created 2015-12-25 12:45 UTC

Status

Indentation +102 added lines, -102 removed lines patch added patch discarded remove patch

@@ -7,132 +7,132 @@
 block discarded – undo
 class MysqlPostRepository implements PostRepositoryInterface
 {
 
-    /** @var  ConnectionLocator */
-    protected $connections;
-
-    /**
-     * @param ConnectonLocator $connections
-     */
-    public function __construct(ConnectionLocator $connections)
-    {
-        $this->connections = $connections;
-    }
-
-    /**
-     * @param integer $id
-     *
-     * @return array|false
-     */
-    public function getPostById($id)
-    {
-        $query = "
+	/** @var  ConnectionLocator */
+	protected $connections;
+
+	/**
+	 * @param ConnectonLocator $connections
+	 */
+	public function __construct(ConnectionLocator $connections)
+	{
+		$this->connections = $connections;
+	}
+
+	/**
+	 * @param integer $id
+	 *
+	 * @return array|false
+	 */
+	public function getPostById($id)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`post`
             WHERE `id` = :id
             LIMIT 1";
-        $bindings = [
-            'id' => $id,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
-
-    /**
-     * @param string  $type
-     * @param integer $type_id
-     *
-     * @return array|false
-     */
-    public function getPostByType($type, $type_id)
-    {
-        $query = "
+		$bindings = [
+			'id' => $id,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
+
+	/**
+	 * @param string  $type
+	 * @param integer $type_id
+	 *
+	 * @return array|false
+	 */
+	public function getPostByType($type, $type_id)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`post`
             WHERE `type` = :type && `type_id` = :type_id
             LIMIT 1";
-        $bindings = [
-            'type'    => $type,
-            'type_id' => $type_id,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
-
-    /**
-     * @param integer $limit
-     * @param integer $offset
-     *
-     * @return array|false
-     */
-    public function getPosts($limit = null, $offset = 0)
-    {
-        $query = "
+		$bindings = [
+			'type'    => $type,
+			'type_id' => $type_id,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
+
+	/**
+	 * @param integer $limit
+	 * @param integer $offset
+	 *
+	 * @return array|false
+	 */
+	public function getPosts($limit = null, $offset = 0)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`post`
             ORDER BY `date` DESC";
-        if (!is_null($limit)) {
-            $query .= "
+		if (!is_null($limit)) {
+			$query .= "
             LIMIT {$offset}, {$limit}";
-        }
+		}
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query);
+	}
 
-    public function getPostsCount()
-    {
-        $query = "
+	public function getPostsCount()
+	{
+		$query = "
             SELECT COUNT(1) AS `count`
             FROM `jpemeric_stream`.`post`";
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchValue($query);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchValue($query);
+	}
 
-    public function getPostsByTag($tag, $limit = null, $offset = 0)
-    {
-        $query = "
+	public function getPostsByTag($tag, $limit = null, $offset = 0)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`post`
             WHERE `tag` = :tag
             ORDER BY `date` DESC";
-        if (!is_null($limit)) {
-            $query .= "
+		if (!is_null($limit)) {
+			$query .= "
             LIMIT {$offset}, {$limit}";
-        }
-        $bindings = [
-            'tag' => $tag,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query, $bindings);
-    }
-
-    public function getPostsByTagCount($tag)
-    {
-        $query = "
+		}
+		$bindings = [
+			'tag' => $tag,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query, $bindings);
+	}
+
+	public function getPostsByTagCount($tag)
+	{
+		$query = "
             SELECT COUNT(1) AS `count`
             FROM `jpemeric_stream`.`post`
             WHERE `tag` = :tag";
-        $bindings = [
-            'tag' => $tag,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query, $bindings);
-    }
+		$bindings = [
+			'tag' => $tag,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query, $bindings);
+	}
 }

Please login to merge, or discard this patch.

src/Domain/Stream/Post/PostRepositoryInterface.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -4,10 +4,10 @@
 block discarded – undo
 
 interface PostRepositoryInterface
 {
-    public function getPostById($id);
-    public function getPostByType($type, $type_id);
-    public function getPosts($limit = null, $offset = 0);
-    public function getPostsCount();
-    public function getPostsByTag($tag, $limit = null, $offset = 0);
-    public function getPostsByTagCount($tag);
+	public function getPostById($id);
+	public function getPostByType($type, $type_id);
+	public function getPosts($limit = null, $offset = 0);
+	public function getPostsCount();
+	public function getPostsByTag($tag, $limit = null, $offset = 0);
+	public function getPostsByTagCount($tag);
 }

Please login to merge, or discard this patch.

controller/PageController.class.inc.php 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -60,9 +60,9 @@  discard block
 block discarded – undo
 
 	protected function get_recent_activity()
 	{
-    global $container;
-    $activityRepository = new Jacobemerick\Web\Domain\Stream\Post\MysqlPostRepository($container['db_connection_locator']);
-    $post_result = $activityRepository->getPosts(5);
+	global $container;
+	$activityRepository = new Jacobemerick\Web\Domain\Stream\Post\MysqlPostRepository($container['db_connection_locator']);
+	$post_result = $activityRepository->getPosts(5);
 
 		$post_array = array();
 		foreach($post_result as $row)
@@ -125,9 +125,9 @@  discard block
 block discarded – undo
 					if(strlen($row->title) > 0)
 						$post->title .= " I was hiking up around the {$row->title} area.";
 				}
-                else if ($row->type == 'walking') {
-                    $post->title = "Walked {$row->distance} miles and felt {$row->felt}.";
-                }
+				else if ($row->type == 'walking') {
+					$post->title = "Walked {$row->distance} miles and felt {$row->felt}.";
+				}
 			break;
 			case 'hulu' :
 				$row = HuluCollector::getRow($raw_post->type_id);
@@ -194,11 +194,11 @@  discard block
 block discarded – undo
 				Loader::load('view', URLDecode::getSite() . '/' . $view, $this->data_array['body']);
 		}
         
-        if (URLDecode::getSite() == 'waterfalls') {
-            Loader::load('view', '/WaterfallFoot');
-        } else {
-            Loader::load('view', '/Foot', array('tracking_code' => self::$TRACKING_CODE));
-        }
+		if (URLDecode::getSite() == 'waterfalls') {
+			Loader::load('view', '/WaterfallFoot');
+		} else {
+			Loader::load('view', '/Foot', array('tracking_code' => self::$TRACKING_CODE));
+		}
 		
 		if($view == '/404' || $view == '/503')
 			exit;

Please login to merge, or discard this patch.

		@@ -7,132 +7,132 @@
		block discarded – undo
7	7	class MysqlPostRepository implements PostRepositoryInterface
8	8	{
9	9
10		- /** @var ConnectionLocator */
11		- protected $connections;
12		-
13		- /**
14		- * @param ConnectonLocator $connections
15		- */
16		- public function __construct(ConnectionLocator $connections)
17		- {
18		- $this->connections = $connections;
19		- }
20		-
21		- /**
22		- * @param integer $id
23		- *
24		- * @return array\|false
25		- */
26		- public function getPostById($id)
27		- {
28		- $query = "
	10	+ /** @var ConnectionLocator */
	11	+ protected $connections;
	12	+
	13	+ /**
	14	+ * @param ConnectonLocator $connections
	15	+ */
	16	+ public function __construct(ConnectionLocator $connections)
	17	+ {
	18	+ $this->connections = $connections;
	19	+ }
	20	+
	21	+ /**
	22	+ * @param integer $id
	23	+ *
	24	+ * @return array\|false
	25	+ */
	26	+ public function getPostById($id)
	27	+ {
	28	+ $query = "
29	29	SELECT *
30	30	FROM `jpemeric_stream`.`post`
31	31	WHERE `id` = :id
32	32	LIMIT 1";
33		- $bindings = [
34		- 'id' => $id,
35		- ];
36		-
37		- return $this
38		- ->connections
39		- ->getRead()
40		- ->fetchOne($query, $bindings);
41		- }
42		-
43		- /**
44		- * @param string $type
45		- * @param integer $type_id
46		- *
47		- * @return array\|false
48		- */
49		- public function getPostByType($type, $type_id)
50		- {
51		- $query = "
	33	+ $bindings = [
	34	+ 'id' => $id,
	35	+ ];
	36	+
	37	+ return $this
	38	+ ->connections
	39	+ ->getRead()
	40	+ ->fetchOne($query, $bindings);
	41	+ }
	42	+
	43	+ /**
	44	+ * @param string $type
	45	+ * @param integer $type_id
	46	+ *
	47	+ * @return array\|false
	48	+ */
	49	+ public function getPostByType($type, $type_id)
	50	+ {
	51	+ $query = "
52	52	SELECT *
53	53	FROM `jpemeric_stream`.`post`
54	54	WHERE `type` = :type && `type_id` = :type_id
55	55	LIMIT 1";
56		- $bindings = [
57		- 'type' => $type,
58		- 'type_id' => $type_id,
59		- ];
60		-
61		- return $this
62		- ->connections
63		- ->getRead()
64		- ->fetchOne($query, $bindings);
65		- }
66		-
67		- /**
68		- * @param integer $limit
69		- * @param integer $offset
70		- *
71		- * @return array\|false
72		- */
73		- public function getPosts($limit = null, $offset = 0)
74		- {
75		- $query = "
	56	+ $bindings = [
	57	+ 'type' => $type,
	58	+ 'type_id' => $type_id,
	59	+ ];
	60	+
	61	+ return $this
	62	+ ->connections
	63	+ ->getRead()
	64	+ ->fetchOne($query, $bindings);
	65	+ }
	66	+
	67	+ /**
	68	+ * @param integer $limit
	69	+ * @param integer $offset
	70	+ *
	71	+ * @return array\|false
	72	+ */
	73	+ public function getPosts($limit = null, $offset = 0)
	74	+ {
	75	+ $query = "
76	76	SELECT *
77	77	FROM `jpemeric_stream`.`post`
78	78	ORDER BY `date` DESC";
79		- if (!is_null($limit)) {
80		- $query .= "
	79	+ if (!is_null($limit)) {
	80	+ $query .= "
81	81	LIMIT {$offset}, {$limit}";
82		- }
	82	+ }
83	83
84		- return $this
85		- ->connections
86		- ->getRead()
87		- ->fetchAll($query);
88		- }
	84	+ return $this
	85	+ ->connections
	86	+ ->getRead()
	87	+ ->fetchAll($query);
	88	+ }
89	89
90		- public function getPostsCount()
91		- {
92		- $query = "
	90	+ public function getPostsCount()
	91	+ {
	92	+ $query = "
93	93	SELECT COUNT(1) AS `count`
94	94	FROM `jpemeric_stream`.`post`";
95	95
96		- return $this
97		- ->connections
98		- ->getRead()
99		- ->fetchValue($query);
100		- }
	96	+ return $this
	97	+ ->connections
	98	+ ->getRead()
	99	+ ->fetchValue($query);
	100	+ }
101	101
102		- public function getPostsByTag($tag, $limit = null, $offset = 0)
103		- {
104		- $query = "
	102	+ public function getPostsByTag($tag, $limit = null, $offset = 0)
	103	+ {
	104	+ $query = "
105	105	SELECT *
106	106	FROM `jpemeric_stream`.`post`
107	107	WHERE `tag` = :tag
108	108	ORDER BY `date` DESC";
109		- if (!is_null($limit)) {
110		- $query .= "
	109	+ if (!is_null($limit)) {
	110	+ $query .= "
111	111	LIMIT {$offset}, {$limit}";
112		- }
113		- $bindings = [
114		- 'tag' => $tag,
115		- ];
116		-
117		- return $this
118		- ->connections
119		- ->getRead()
120		- ->fetchAll($query, $bindings);
121		- }
122		-
123		- public function getPostsByTagCount($tag)
124		- {
125		- $query = "
	112	+ }
	113	+ $bindings = [
	114	+ 'tag' => $tag,
	115	+ ];
	116	+
	117	+ return $this
	118	+ ->connections
	119	+ ->getRead()
	120	+ ->fetchAll($query, $bindings);
	121	+ }
	122	+
	123	+ public function getPostsByTagCount($tag)
	124	+ {
	125	+ $query = "
126	126	SELECT COUNT(1) AS `count`
127	127	FROM `jpemeric_stream`.`post`
128	128	WHERE `tag` = :tag";
129		- $bindings = [
130		- 'tag' => $tag,
131		- ];
132		-
133		- return $this
134		- ->connections
135		- ->getRead()
136		- ->fetchAll($query, $bindings);
137		- }
	129	+ $bindings = [
	130	+ 'tag' => $tag,
	131	+ ];
	132	+
	133	+ return $this
	134	+ ->connections
	135	+ ->getRead()
	136	+ ->fetchAll($query, $bindings);
	137	+ }
138	138	}

		@@ -4,10 +4,10 @@
		block discarded – undo
4	4
5	5	interface PostRepositoryInterface
6	6	{
7		- public function getPostById($id);
8		- public function getPostByType($type, $type_id);
9		- public function getPosts($limit = null, $offset = 0);
10		- public function getPostsCount();
11		- public function getPostsByTag($tag, $limit = null, $offset = 0);
12		- public function getPostsByTagCount($tag);
	7	+ public function getPostById($id);
	8	+ public function getPostByType($type, $type_id);
	9	+ public function getPosts($limit = null, $offset = 0);
	10	+ public function getPostsCount();
	11	+ public function getPostsByTag($tag, $limit = null, $offset = 0);
	12	+ public function getPostsByTagCount($tag);
13	13	}

		@@ -60,9 +60,9 @@ discard block
		block discarded – undo
60	60
61	61	protected function get_recent_activity()
62	62	{
63		- global $container;
64		- $activityRepository = new Jacobemerick\Web\Domain\Stream\Post\MysqlPostRepository($container['db_connection_locator']);
65		- $post_result = $activityRepository->getPosts(5);
	63	+ global $container;
	64	+ $activityRepository = new Jacobemerick\Web\Domain\Stream\Post\MysqlPostRepository($container['db_connection_locator']);
	65	+ $post_result = $activityRepository->getPosts(5);
66	66
67	67	$post_array = array();
68	68	foreach($post_result as $row)
		@@ -125,9 +125,9 @@ discard block
		block discarded – undo
125	125	if(strlen($row->title) > 0)
126	126	$post->title .= " I was hiking up around the {$row->title} area.";
127	127	}
128		- else if ($row->type == 'walking') {
129		- $post->title = "Walked {$row->distance} miles and felt {$row->felt}.";
130		- }
	128	+ else if ($row->type == 'walking') {
	129	+ $post->title = "Walked {$row->distance} miles and felt {$row->felt}.";
	130	+ }
131	131	break;
132	132	case 'hulu' :
133	133	$row = HuluCollector::getRow($raw_post->type_id);
		@@ -194,11 +194,11 @@ discard block
		block discarded – undo
194	194	Loader::load('view', URLDecode::getSite() . '/' . $view, $this->data_array['body']);
195	195	}
196	196
197		- if (URLDecode::getSite() == 'waterfalls') {
198		- Loader::load('view', '/WaterfallFoot');
199		- } else {
200		- Loader::load('view', '/Foot', array('tracking_code' => self::$TRACKING_CODE));
201		- }
	197	+ if (URLDecode::getSite() == 'waterfalls') {
	198	+ Loader::load('view', '/WaterfallFoot');
	199	+ } else {
	200	+ Loader::load('view', '/Foot', array('tracking_code' => self::$TRACKING_CODE));
	201	+ }
202	202
203	203	if($view == '/404' \|\| $view == '/503')
204	204	exit;

jacobemerick / web

Push — master ( be7975...b1edf3 )

Status

Category

Indentation +102 added lines, -102 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch