Issues in ContactController.class.inc.php - New Issues - Inspection of "Merge pull request #3 from jacobemerick/feature/ad..." - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c8fbd...2c9aff )

by Jacob

created 2016-01-16 13:21 UTC

controller/site/ContactController.class.inc.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?

Loader::load('controller', 'site/DefaultPageController');
Loader::load('utility', array(
	'Mail',
	'Validate'));

final class ContactController extends DefaultPageController

{

	protected function set_head_data()
	{
		$this->set_title("Contact Form for Jacob Emerick's Sites");
		$this->set_description("Want to reach out to Jacob Emerick with questions or concerns? Well, then here's a handy contact form for you that will connect you with the man himself.");
		$this->set_keywords(array('contact', 'webmaster', 'support', 'help', 'Jacob Emerick'));
		
		parent::set_head_data();
	}

	protected function set_body_data()
	{
		parent::set_body_data();
		
		$this->set_body('top_data', array('title' => 'Contact Me'));
		
		$this->set_body('body_data', $this->get_form_results());
		$this->set_body('body_view', 'Contact');
	}

	private function get_form_results()
	{
		if(!Request::hasPost())
			return array();
		
		if(!Validate::checkRequest('post', 'name', 'string'))
			$error_message['name'] = 'Please enter a value for your name.';
		if(!Validate::checkRequest('post', 'email', 'string'))
			$error_message['email'] = 'Please enter a valid email address.';
		if(!Validate::checkRequest('post', 'message', 'string'))
			$error_message['message'] = 'Please enter a message.';
		
		if(!empty($error_message))
		{
			return array(
				'error_message' => $error_message,
				'value' => Request::getPost());
		}

    global $container;
    $sent = $container['mail']
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
      ->addTo($container['config']->admin_email)
      ->setSubject('Site Contact')
      ->setPlainMessage(
        'Name: ' . Request::getPost('name') . "\n" .
        'Email: ' . Request::getPost('email') . "\n" .
        'Message: ' . Request::getPost('message')
      )
      ->send();

		return array(
			'success_message' => "Thank you for your message, " . Request::getPost('name') . "! I'll get back to you as soon as possible.");
	}

}


1		<?
2
3		Loader::load('controller', 'site/DefaultPageController');
4		Loader::load('utility', array(
5		'Mail',
6		'Validate'));
7
8		final class ContactController extends DefaultPageController
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-01-16 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `ContactController` has been defined more than once; this definition is ignored, only the first definition in `controller/home/ContactController.class.inc.php` (L5-77) is considered. This check looks for classes that have been defined more than once. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. Loading history...
9		{
10
11		protected function set_head_data()
12		{
13		$this->set_title("Contact Form for Jacob Emerick's Sites");
14		$this->set_description("Want to reach out to Jacob Emerick with questions or concerns? Well, then here's a handy contact form for you that will connect you with the man himself.");
15		$this->set_keywords(array('contact', 'webmaster', 'support', 'help', 'Jacob Emerick'));
16
17		parent::set_head_data();
18		}
19
20		protected function set_body_data()
21		{
22		parent::set_body_data();
23
24		$this->set_body('top_data', array('title' => 'Contact Me'));
25
26		$this->set_body('body_data', $this->get_form_results());
27		$this->set_body('body_view', 'Contact');
28		}
29
30	View Code Duplication	private function get_form_results()
31		{
32		if(!Request::hasPost())
33		return array();
34
35		if(!Validate::checkRequest('post', 'name', 'string'))
36		$error_message['name'] = 'Please enter a value for your name.';
37		if(!Validate::checkRequest('post', 'email', 'string'))
38		$error_message['email'] = 'Please enter a valid email address.';
39		if(!Validate::checkRequest('post', 'message', 'string'))
40		$error_message['message'] = 'Please enter a message.';
41
42		if(!empty($error_message))
43		{
44		return array(
45		'error_message' => $error_message,
46		'value' => Request::getPost());
47		}
48
49		global $container;
50		$sent = $container['mail']
		0 ignored issues – show Unused Code introduced 2016-01-16 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$sent` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
51		->addTo($container['config']->admin_email)
52		->setSubject('Site Contact')
53		->setPlainMessage(
54		'Name: ' . Request::getPost('name') . "\n" .
55		'Email: ' . Request::getPost('email') . "\n" .
56		'Message: ' . Request::getPost('message')
57		)
58		->send();
59
60		return array(
61		'success_message' => "Thank you for your message, " . Request::getPost('name') . "! I'll get back to you as soon as possible.");
62		}
63
64		}
65

jacobemerick / web

Push — master ( 5c8fbd...2c9aff )

controller/site/ContactController.class.inc.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like