Header::sendRSS() - Code Metrics - Inspection of "Removes PHP handling of RSS feeds and blog sitemap" - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 99f0cc...43937d )

by Jacob

created 2016-01-01 18:45 UTC

Header::sendRSS() A

↳ Parent: Header

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	12
Ratio	100 %

Metric	Value
dl	12
loc	12
rs	9.4286
cc	1
eloc	10
nc	1
nop	0

<?


final class Header
{

	private static $CACHE_EXPIRATION = 315360000;

	private static $CACHE_MODIFICATION = 604800;

	private static $SITEMAP_EXPIRATION = 604800;
	private static $RSS_EXPIRATION = 604800;


	public static function sendJSON()

	{
		$array = array(
			'HTTP/1.1 200 OK',
			'Cache-Control: no-cache',
			'Content-Language: en',
			'Content-Type: application/json',
			'Expires: ' . self::get_date(time() - 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'Last-Modified: ' . self::get_date(),
			'X-Powered-By: jacobemerick.com');
		self::send($array);
	}

	public static function sendSitemap()
	{
		$array = array(
			'HTTP/1.1 200 OK',
			'Cache-Control: max-age=' . self::$SITEMAP_EXPIRATION . ', must-revalidate',
			'Content-Language: en',
			'Content-Type: text/xml',
			'Expires: ' . self::get_date(time() + self::$SITEMAP_EXPIRATION),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'Last-Modified: ' . self::get_date(),
			'X-Powered-By: jacobemerick.com');
		self::send($array);
	}

	public static function sendHTML()

	{
		$array = array(
			'HTTP/1.1 200 OK',
			'Cache-Control: no-cache',
			'Content-Language: en',
			'Content-Type: text/html',
			'Expires: ' . self::get_date(time() - 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'Last-Modified: ' . self::get_date(),
			'X-Powered-By: jacobemerick.com');
		self::send($array);
	}

	public static function redirect($location, $method = 301)
	{
		header("Location: {$location}", TRUE, $method);
		exit();

	}

	public static function send404()

	{
		$array = array(
			'HTTP/1.1 404 Not Found',
			'Cache-Control: no-cache',
			'Content-Language: en',
			'Content-Type: text/html',
			'Expires: ' . self::get_date(time() - 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'Last-Modified: ' . self::get_date(),
			'X-Powered-By: jacobemerick.com');
		self::send($array);
	}

	public static function send503()

	{
		$array = array(
			'HTTP/1.1 503 Service Unavailable',
			'Cache-Control: no-cache',
			'Content-Language: en',
			'Content-Type: text/html',
			'Expires: ' . self::get_date(time() - 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'Last-Modified: ' . self::get_date(),
			'X-Powered-By: jacobemerick.com');
		self::send($array);
	}

	private static function send($array, $gzip = true)
	{
		if($gzip)
			self::start_gzipping();
		
		foreach($array as $row)
		{
			header($row, TRUE);
		}
	}

	private static function get_date($timestamp = false)
	{
		if($timestamp == 0)
			$timestamp = time();
		return gmdate('D, d M Y H:i:s \G\M\T', $timestamp);
	}

	private static function start_gzipping()
	{
		if(!ob_start('ob_gzhandler'))
            ob_start();
	}

}


1		<?
		0 ignored issues – show Security Best Practice introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report It is not recommend to use PHP's short opening tag `<?`, better use `<?php`, or `<?=` in case of outputting. Short opening tags are disabled in PHP’s default configuration. In such a case, all content of this file is output verbatim to the browser without being parsed, or executed. As a precaution to avoid these problems better use the long opening tag `<?php`. Loading history...
2
3		final class Header
4		{
5
6		private static $CACHE_EXPIRATION = 315360000;
		0 ignored issues – show Unused Code introduced 2015-12-30 13:34 UTC by Report Bug Copy Issue Report The property `$CACHE_EXPIRATION` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7		private static $CACHE_MODIFICATION = 604800;
		0 ignored issues – show Unused Code introduced 2015-12-28 22:36 UTC by Report Bug Copy Issue Report The property `$CACHE_MODIFICATION` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
8		private static $SITEMAP_EXPIRATION = 604800;
9		private static $RSS_EXPIRATION = 604800;
		0 ignored issues – show Unused Code introduced 2016-01-01 18:48 UTC by Report Bug Copy Issue Report The property `$RSS_EXPIRATION` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10
11	View Code Duplication	public static function sendJSON()
		0 ignored issues – show Duplication introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		$array = array(
14		'HTTP/1.1 200 OK',
15		'Cache-Control: no-cache',
16		'Content-Language: en',
17		'Content-Type: application/json',
18		'Expires: ' . self::get_date(time() - 1),
		0 ignored issues – show Documentation introduced 2015-12-30 13:34 UTC by Report Bug Copy Issue Report `time() - 1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19		'Last-Modified: ' . self::get_date(),
20		'X-Powered-By: jacobemerick.com');
21		self::send($array);
22		}
23
24		public static function sendSitemap()
25		{
26		$array = array(
27		'HTTP/1.1 200 OK',
28		'Cache-Control: max-age=' . self::$SITEMAP_EXPIRATION . ', must-revalidate',
29		'Content-Language: en',
30		'Content-Type: text/xml',
31		'Expires: ' . self::get_date(time() + self::$SITEMAP_EXPIRATION),
		0 ignored issues – show Documentation introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `time() + self::$SITEMAP_EXPIRATION` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32		'Last-Modified: ' . self::get_date(),
33		'X-Powered-By: jacobemerick.com');
34		self::send($array);
35		}
36
37	View Code Duplication	public static function sendHTML()
		0 ignored issues – show Duplication introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$array = array(
40		'HTTP/1.1 200 OK',
41		'Cache-Control: no-cache',
42		'Content-Language: en',
43		'Content-Type: text/html',
44		'Expires: ' . self::get_date(time() - 1),
		0 ignored issues – show Documentation introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `time() - 1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45		'Last-Modified: ' . self::get_date(),
46		'X-Powered-By: jacobemerick.com');
47		self::send($array);
48		}
49
50		public static function redirect($location, $method = 301)
51		{
52		header("Location: {$location}", TRUE, $method);
53		exit();
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-28 18:20 UTC by Report Bug Copy Issue Report The method `redirect()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
54		}
55
56	View Code Duplication	public static function send404()
		0 ignored issues – show Duplication introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$array = array(
59		'HTTP/1.1 404 Not Found',
60		'Cache-Control: no-cache',
61		'Content-Language: en',
62		'Content-Type: text/html',
63		'Expires: ' . self::get_date(time() - 1),
		0 ignored issues – show Documentation introduced 2016-01-01 18:48 UTC by Report Bug Copy Issue Report `time() - 1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64		'Last-Modified: ' . self::get_date(),
65		'X-Powered-By: jacobemerick.com');
66		self::send($array);
67		}
68
69	View Code Duplication	public static function send503()
		0 ignored issues – show Duplication introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		$array = array(
72		'HTTP/1.1 503 Service Unavailable',
73		'Cache-Control: no-cache',
74		'Content-Language: en',
75		'Content-Type: text/html',
76		'Expires: ' . self::get_date(time() - 1),
		0 ignored issues – show Documentation introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `time() - 1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77		'Last-Modified: ' . self::get_date(),
78		'X-Powered-By: jacobemerick.com');
79		self::send($array);
80		}
81
82		private static function send($array, $gzip = true)
83		{
84		if($gzip)
85		self::start_gzipping();
86
87		foreach($array as $row)
88		{
89		header($row, TRUE);
90		}
91		}
92
93		private static function get_date($timestamp = false)
94		{
95		if($timestamp == 0)
96		$timestamp = time();
97		return gmdate('D, d M Y H:i:s \G\M\T', $timestamp);
98		}
99
100		private static function start_gzipping()
101		{
102		if(!ob_start('ob_gzhandler'))
103		ob_start();
104		}
105
106		}
107

jacobemerick / web

Push — master ( 99f0cc...43937d )

Header::sendRSS() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like