PostController::__construct() - Code Metrics - Inspection of "Updates comment submit process to pass reply_to, c..." - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf05f4...1e9202 )

by Jacob

created 2016-07-16 03:46 UTC

PostController::__construct() B

↳ Parent: PostController

Complexity

Conditions	5
Paths	8

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	8.7624
c	0
b	0
f	0
cc	5
eloc	11
nc	8
nop	0

<?


Loader::load('collector', 'waterfall/LogCollector');
Loader::load('controller', 'blog/DefaultPageController');

final class PostController extends DefaultPageController
{

	private static $PAGE_DESCRIPTION_LIMIT = 250;

	private static $TITLE = "%s | Jacob Emerick's Blog";
	private static $AUTHOR = 'Jacob Emerick';
	private static $AUTHOR_URL = 'https://home.jacobemerick.com/';

	private static $POST_LENGTH_SHORT = 100;
	private static $POST_LENGTH_LONG = 140;

	private $post;
	private $tags;
	private $comment_errors = array();


	public function __construct()
	{
		parent::__construct();
		
        global $container;
        $repository = new Jacobemerick\Web\Domain\Blog\Post\MysqlPostRepository($container['db_connection_locator']);
        $this->post = $repository->findPostByPath(URLDecode::getPiece(2));

		if($this->post == null)
			$this->eject();
		
		$this->handle_comment_submit(
			self::$BLOG_SITE_ID,
			$this->post['path'],
			Loader::getRootUrl('blog') . $this->post['category'] . '/' . $this->post['path'] . '/',
			$this->post['title']);

        global $container;
        $repository = new Jacobemerick\Web\Domain\Blog\Tag\MysqlTagRepository($container['db_connection_locator']);
        $this->tags = $repository->getTagsForPost($this->post['id']);
	}

	protected function set_head_data()
	{
		parent::set_head_data();
		
		$this->set_title(sprintf(self::$TITLE, $this->post['title']));
		$this->set_description($this->get_post_description());
		$this->set_keywords($this->get_post_keywords());
		$this->set_author(self::$AUTHOR);

    $photo = Content::instance('FetchFirstPhoto', $this->post['body'])->activate(true);
    $photo = preg_match('/^<img src="([a-z-:\.\/]+)" [^>]+>$/', $photo, $matches);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $this->set_head('thumbnail', $matches[1]);

		if (array_key_exists($this->post['id'], self::$DEPRECATED_BLOGS)) {
			$log_id = self::$DEPRECATED_BLOGS[$this->post['id']];
			$log = LogCollector::getById($log_id);
			if (!empty($log)) {
				$log_url = Loader::getRootUrl('waterfalls') . "journal/{$log->alias}/";
				$this->set_canonical($log_url);
			}
		}
	}

	protected function get_introduction() {}

	protected function set_body_data()
	{
		parent::set_body_data();
		
		$this->set_body('title', $this->post['title']);
		$this->set_body('view', 'Post');
		$this->set_body('data', array(
			'post' => $this->format_post($this->post, false),
			'series_posts' => $this->get_series_posts(),
			'related_posts' => $this->get_related_posts(),
			'author' => self::$AUTHOR,
			'author_url' => self::$AUTHOR_URL,
			'comment_array' => $this->get_comment_array("{$this->post['category']}/{$this->post['path']}"),
    ));
	}

	protected function get_post_description()
	{
		$description = $this->post['body'];
		$description = strip_tags($description);
		$description = Content::instance('SmartTrim', $description)->activate(self::$PAGE_DESCRIPTION_LIMIT);
		
		return $description;
	}

	protected function get_post_keywords()
	{
		$keyword_array = array();
		$keywords = $this->tags;
		
		foreach($keywords as $keyword)
		{
			$keyword_array[] = $keyword['tag'];
		}
		
		$keyword_array[] = 'blog';
		$keyword_array[] = 'Jacob Emerick';
		
		return $keyword_array;
	}

	private function get_series_posts()
	{
		$series_posts = $this->fetch_series_posts();
		if(count($series_posts) < 1)
			return array();
		
		$previous_post = new stdclass();
		$next_post = new stdclass();
		
		$found_current_post = false;
		foreach($series_posts as $post_row)
		{
			if($post_row['post'] == $this->post['id'])
			{
				$found_current_post = true;
				continue;
			}
			
			$post = new stdclass();

      if (
        strpos($post_row['title'], 'Rainy Supe Loop') === 0 ||
        strpos($post_row['title'], 'Malapais Loop') === 0 ||
        strpos($post_row['title'], 'Mazatzal Peak Loop') === 0 ||
        strpos($post_row['title'], 'Dripping Springs Loop') === 0
      ) {
        $title = $post_row['title'];
        $title = explode(':', $title);
        $title = array_pop($title);
        $title = trim($title);
        $post->title = $title;
      } else if (strpos($post_row['title'], 'Isle Royale') === 0) {
				$title = $post_row['title'];
				$title = explode(',', $title);
				$title = array_pop($title);
				$title = trim($title);
				$post->title = $title;
			} else {
				$post->title = $post_row['title'];
			}

			$post->url = Loader::getRootUrl('blog') . "{$post_row['category']}/{$post_row['path']}/";
			
			if(!$found_current_post)
				$previous_post = $post;
			else
			{
				$next_post = $post;
				break;
			}
		}
		
		return array(
			'title' => $post_row['series_title'],
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
			'description' => Content::instance('FixInternalLink', $post_row['series_description'])->activate(),
			'previous' => $previous_post,
			'next' => $next_post);
	}

	private $series_posts;
	private function fetch_series_posts()
	{
      if(!isset($this->series_posts)) {
          global $container;
          $repository = new Jacobemerick\Web\Domain\Blog\Series\MysqlSeriesRepository($container['db_connection_locator']);
          $this->series_posts = $repository->getSeriesForPost($this->post['id']);
      }
      return $this->series_posts;
	}

	private function get_related_posts()
	{
		$tag_array = array();
		foreach($this->tags as $tag)
		{
			$tag_array[] = $tag['id'];
		}
		
		$series_posts = $this->fetch_series_posts();
		$exclude_post_array = array();
		foreach($series_posts as $series_post)
		{
			$exclude_post_array[] = $series_post['post'];
		}

        global $container;
        $repository = new Jacobemerick\Web\Domain\Blog\Post\MysqlPostRepository($container['db_connection_locator']);
        $post_result = $repository->getActivePostsByRelatedTags($this->post['id']);

        $post_array = array();
		
		foreach($post_result as $post_row)

		{
			$post = new stdclass();
			$post->title = $post_row['title'];
			$post->url = Loader::getRootUrl('blog') . "{$post_row['category']}/{$post_row['path']}/";
			$post->category = ucwords(str_replace('-', ' ', $post_row['category']));
			$post->thumb = Content::instance('FetchFirstPhoto', $post_row['body'])->activate();
			$post->body = Content::instance('SmartTrim', $post_row['body'])->activate(($post->thumb !== '') ? self::$POST_LENGTH_SHORT : self::$POST_LENGTH_LONG);
			
			$post_array[] = $post;
		}
		
		return $post_array;
	}

    protected function get_comment_array($path)
    {
        global $config;
        $configuration = new Jacobemerick\CommentService\Configuration();
        $configuration->setUsername($config->comments->user);
        $configuration->setPassword($config->comments->password);
        $configuration->addDefaultHeader('Content-Type', 'application/json');
        $configuration->setHost($config->comments->host);
        $configuration->setCurlTimeout($config->comments->timeout);

        $client = new Jacobemerick\CommentService\ApiClient($configuration);
        $api = new Jacobemerick\CommentService\Api\DefaultApi($client);

        $start = microtime(true);
        try {
            $comment_response = $api->getComments(
                1,
                null,
                'date',
                'blog.jacobemerick.com',
                $path
            );
        } catch (Exception $e) {
            global $container;
            $container['logger']->warning("CommentService | Path | {$e->getMessage()}");
            return;
        }
 
        $elapsed = microtime(true) - $start;
        global $container;
        $container['logger']->info("CommentService | Path | {$elapsed}");

        $array = array();
        foreach((array) $comment_response as $comment)
        {
            $body = $comment->getBody();
            $body = Content::instance('CleanComment', $body)->activate();
            $body = strip_tags($body);

            $comment_obj = new stdclass();
            $comment_obj->id = $comment->getId();
            $comment_obj->name = $comment->getCommenter()->getName();
            $comment_obj->url = $comment->getCommenter()->getWebsite();
            $comment_obj->trusted = true;
            $comment_obj->date = $comment->getDate()->format('M j, \'y');
            $comment_obj->body = $body;

            // todo figure out if reply
            $array[] = $comment_obj;
        }

        // todo figure out commenter obj
        // todo figure out how to handle errors or whatever
        return [
            'comments' => $array,
            'commenter' => [],
            'errors' => [],
            'comment_count' => count($array),
        ];
    }
}


1		<?
		0 ignored issues – show Security Best Practice introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report It is not recommend to use PHP's short opening tag `<?`, better use `<?php`, or `<?=` in case of outputting. Short opening tags are disabled in PHP’s default configuration. In such a case, all content of this file is output verbatim to the browser without being parsed, or executed. As a precaution to avoid these problems better use the long opening tag `<?php`. Loading history...
2
3		Loader::load('collector', 'waterfall/LogCollector');
4		Loader::load('controller', 'blog/DefaultPageController');
5
6		final class PostController extends DefaultPageController
7		{
8
9		private static $PAGE_DESCRIPTION_LIMIT = 250;
10
11		private static $TITLE = "%s \| Jacob Emerick's Blog";
12		private static $AUTHOR = 'Jacob Emerick';
13		private static $AUTHOR_URL = 'https://home.jacobemerick.com/';
14
15		private static $POST_LENGTH_SHORT = 100;
16		private static $POST_LENGTH_LONG = 140;
17
18		private $post;
19		private $tags;
20		private $comment_errors = array();
		0 ignored issues – show Comprehensibility introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-28 18:20 UTC by Report Bug Copy Issue Report The property `$comment_errors` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21
22		public function __construct()
23		{
24		parent::__construct();
25
26		global $container;
27		$repository = new Jacobemerick\Web\Domain\Blog\Post\MysqlPostRepository($container['db_connection_locator']);
28		$this->post = $repository->findPostByPath(URLDecode::getPiece(2));
29
30		if($this->post == null)
31		$this->eject();
32
33		$this->handle_comment_submit(
34		self::$BLOG_SITE_ID,
35		$this->post['path'],
36		Loader::getRootUrl('blog') . $this->post['category'] . '/' . $this->post['path'] . '/',
37		$this->post['title']);
38
39		global $container;
40		$repository = new Jacobemerick\Web\Domain\Blog\Tag\MysqlTagRepository($container['db_connection_locator']);
41		$this->tags = $repository->getTagsForPost($this->post['id']);
42		}
43
44		protected function set_head_data()
45		{
46		parent::set_head_data();
47
48		$this->set_title(sprintf(self::$TITLE, $this->post['title']));
49		$this->set_description($this->get_post_description());
50		$this->set_keywords($this->get_post_keywords());
51		$this->set_author(self::$AUTHOR);
52
53		$photo = Content::instance('FetchFirstPhoto', $this->post['body'])->activate(true);
54		$photo = preg_match('/^<img src="([a-z-:\.\/]+)" [^>]+>$/', $photo, $matches);
		0 ignored issues – show Unused Code introduced 2016-02-05 18:25 UTC by Report Bug Copy Issue Report `$photo` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55		$this->set_head('thumbnail', $matches[1]);
56
57		if (array_key_exists($this->post['id'], self::$DEPRECATED_BLOGS)) {
58		$log_id = self::$DEPRECATED_BLOGS[$this->post['id']];
59		$log = LogCollector::getById($log_id);
60		if (!empty($log)) {
61		$log_url = Loader::getRootUrl('waterfalls') . "journal/{$log->alias}/";
62		$this->set_canonical($log_url);
63		}
64		}
65		}
66
67		protected function get_introduction() {}
68
69		protected function set_body_data()
70		{
71		parent::set_body_data();
72
73		$this->set_body('title', $this->post['title']);
74		$this->set_body('view', 'Post');
75		$this->set_body('data', array(
76		'post' => $this->format_post($this->post, false),
77		'series_posts' => $this->get_series_posts(),
78		'related_posts' => $this->get_related_posts(),
79		'author' => self::$AUTHOR,
80		'author_url' => self::$AUTHOR_URL,
81		'comment_array' => $this->get_comment_array("{$this->post['category']}/{$this->post['path']}"),
82		));
83		}
84
85		protected function get_post_description()
86		{
87		$description = $this->post['body'];
88		$description = strip_tags($description);
89		$description = Content::instance('SmartTrim', $description)->activate(self::$PAGE_DESCRIPTION_LIMIT);
90
91		return $description;
92		}
93
94		protected function get_post_keywords()
95		{
96		$keyword_array = array();
97		$keywords = $this->tags;
98
99		foreach($keywords as $keyword)
100		{
101		$keyword_array[] = $keyword['tag'];
102		}
103
104		$keyword_array[] = 'blog';
105		$keyword_array[] = 'Jacob Emerick';
106
107		return $keyword_array;
108		}
109
110		private function get_series_posts()
111		{
112		$series_posts = $this->fetch_series_posts();
113		if(count($series_posts) < 1)
114		return array();
115
116		$previous_post = new stdclass();
117		$next_post = new stdclass();
118
119		$found_current_post = false;
120		foreach($series_posts as $post_row)
121		{
122		if($post_row['post'] == $this->post['id'])
123		{
124		$found_current_post = true;
125		continue;
126		}
127
128		$post = new stdclass();
129
130		if (
131		strpos($post_row['title'], 'Rainy Supe Loop') === 0 \|\|
132		strpos($post_row['title'], 'Malapais Loop') === 0 \|\|
133		strpos($post_row['title'], 'Mazatzal Peak Loop') === 0 \|\|
134		strpos($post_row['title'], 'Dripping Springs Loop') === 0
135		) {
136		$title = $post_row['title'];
137		$title = explode(':', $title);
138		$title = array_pop($title);
139		$title = trim($title);
140		$post->title = $title;
141		} else if (strpos($post_row['title'], 'Isle Royale') === 0) {
142		$title = $post_row['title'];
143		$title = explode(',', $title);
144		$title = array_pop($title);
145		$title = trim($title);
146		$post->title = $title;
147		} else {
148		$post->title = $post_row['title'];
149		}
150
151		$post->url = Loader::getRootUrl('blog') . "{$post_row['category']}/{$post_row['path']}/";
152
153		if(!$found_current_post)
154		$previous_post = $post;
155		else
156		{
157		$next_post = $post;
158		break;
159		}
160		}
161
162		return array(
163		'title' => $post_row['series_title'],
		0 ignored issues – show Bug introduced 2016-02-05 18:25 UTC by Report Bug Copy Issue Report The variable `$post_row` seems to be defined by a `foreach` iteration on line `120`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
164		'description' => Content::instance('FixInternalLink', $post_row['series_description'])->activate(),
165		'previous' => $previous_post,
166		'next' => $next_post);
167		}
168
169		private $series_posts;
170		private function fetch_series_posts()
171		{
172		if(!isset($this->series_posts)) {
173		global $container;
174		$repository = new Jacobemerick\Web\Domain\Blog\Series\MysqlSeriesRepository($container['db_connection_locator']);
175		$this->series_posts = $repository->getSeriesForPost($this->post['id']);
176		}
177		return $this->series_posts;
178		}
179
180		private function get_related_posts()
181		{
182		$tag_array = array();
183		foreach($this->tags as $tag)
184		{
185		$tag_array[] = $tag['id'];
186		}
187
188		$series_posts = $this->fetch_series_posts();
189		$exclude_post_array = array();
190		foreach($series_posts as $series_post)
191		{
192		$exclude_post_array[] = $series_post['post'];
193		}
194
195		global $container;
196		$repository = new Jacobemerick\Web\Domain\Blog\Post\MysqlPostRepository($container['db_connection_locator']);
197		$post_result = $repository->getActivePostsByRelatedTags($this->post['id']);
198
199		$post_array = array();
200
201	View Code Duplication	foreach($post_result as $post_row)
		0 ignored issues – show Duplication introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
202		{
203		$post = new stdclass();
204		$post->title = $post_row['title'];
205		$post->url = Loader::getRootUrl('blog') . "{$post_row['category']}/{$post_row['path']}/";
206		$post->category = ucwords(str_replace('-', ' ', $post_row['category']));
207		$post->thumb = Content::instance('FetchFirstPhoto', $post_row['body'])->activate();
208		$post->body = Content::instance('SmartTrim', $post_row['body'])->activate(($post->thumb !== '') ? self::$POST_LENGTH_SHORT : self::$POST_LENGTH_LONG);
209
210		$post_array[] = $post;
211		}
212
213		return $post_array;
214		}
215
216		protected function get_comment_array($path)
217		{
218		global $config;
219		$configuration = new Jacobemerick\CommentService\Configuration();
220		$configuration->setUsername($config->comments->user);
221		$configuration->setPassword($config->comments->password);
222		$configuration->addDefaultHeader('Content-Type', 'application/json');
223		$configuration->setHost($config->comments->host);
224		$configuration->setCurlTimeout($config->comments->timeout);
225
226		$client = new Jacobemerick\CommentService\ApiClient($configuration);
227		$api = new Jacobemerick\CommentService\Api\DefaultApi($client);
228
229		$start = microtime(true);
230		try {
231		$comment_response = $api->getComments(
232		1,
233		null,
234		'date',
235		'blog.jacobemerick.com',
236		$path
237		);
238		} catch (Exception $e) {
239		global $container;
240		$container['logger']->warning("CommentService \| Path \| {$e->getMessage()}");
241		return;
242		}
243
244		$elapsed = microtime(true) - $start;
245		global $container;
246		$container['logger']->info("CommentService \| Path \| {$elapsed}");
247
248		$array = array();
249		foreach((array) $comment_response as $comment)
250		{
251		$body = $comment->getBody();
252		$body = Content::instance('CleanComment', $body)->activate();
253		$body = strip_tags($body);
254
255		$comment_obj = new stdclass();
256		$comment_obj->id = $comment->getId();
257		$comment_obj->name = $comment->getCommenter()->getName();
258		$comment_obj->url = $comment->getCommenter()->getWebsite();
259		$comment_obj->trusted = true;
260		$comment_obj->date = $comment->getDate()->format('M j, \'y');
261		$comment_obj->body = $body;
262
263		// todo figure out if reply
264		$array[] = $comment_obj;
265		}
266
267		// todo figure out commenter obj
268		// todo figure out how to handle errors or whatever
269		return [
270		'comments' => $array,
271		'commenter' => [],
272		'errors' => [],
273		'comment_count' => count($array),
274		];
275		}
276		}
277

jacobemerick / web

Push — master ( bf05f4...1e9202 )

PostController::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like