Issues in fetch-blog-activity.php - New Issues - Inspection of "Feature/fast route" - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Jacob

created 2016-01-18 12:15 UTC

script/cron/fetch-blog-activity.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

require_once __DIR__ . '/../index.php';

use Jacobemerick\Web\Domain\Stream\Blog\MysqlBlogRepository as BlogRepository;
use Jacobemerick\Web\Domain\Stream\BlogComment\MysqlBlogCommentRepository as BlogCommentRepository;

$blogRepository = new BlogRepository($container['db_connection_locator']);
$mostRecentBlog = $blogRepository->getBlogs(1);
$mostRecentBlog = current($mostRecentBlog);
$mostRecentBlogDateTime = $mostRecentBlog['datetime'];
$mostRecentBlogDateTime = new DateTime($mostRecentBlogDateTime);

$blogFeed = Feed::loadRss('http://blog.jacobemerick.com/rss.xml');
foreach ($blogFeed->item as $item) {
    $datetime = new DateTime($item->pubDate);
    if ($datetime <= $mostRecentBlogDateTime) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
        // break;
    }

    $uniqueBlogCheck = $blogRepository->getBlogByPermalink((string) $item->guid);
    if ($uniqueBlogCheck !== false) {
        continue;
    }

    $datetime->setTimezone($container['default_timezone']);
    $metadata = json_decode(json_encode($item), true);

    $blogRepository->insertBlog(
        (string) $item->guid,
        $datetime,
        $metadata
    );
}

$blogCommentRepository = new BlogCommentRepository($container['db_connection_locator']);
$mostRecentBlogComment = $blogCommentRepository->getBlogComments(1);
$mostRecentBlogComment = current($mostRecentBlogComment);
$mostRecentBlogCommentDateTime = $mostRecentBlogComment['datetime'];
$mostRecentBlogCommentDateTime = new DateTime($mostRecentBlogCommentDateTime);

$commentFeed = Feed::loadRss('http://blog.jacobemerick.com/rss-comments.xml');
foreach ($commentFeed->item as $item) {
    $datetime = new DateTime($item->pubDate);
    if ($datetime <= $mostRecentBlogCommentDateTime) {
        break;
    }

    $uniqueBlogCommentCheck = $blogCommentRepository->getBlogCommentByPermalink((string) $item->guid);
    if ($uniqueBlogCommentCheck !== false) {
        continue;
    }

    $datetime->setTimezone($container['default_timezone']);
    $metadata = json_decode(json_encode($item), true);

    $blogCommentRepository->insertBlogComment(
        (string) $item->guid,
        $datetime,
        $metadata
    );
}


1		<?php
2
3		require_once __DIR__ . '/../index.php';
4
5		use Jacobemerick\Web\Domain\Stream\Blog\MysqlBlogRepository as BlogRepository;
6		use Jacobemerick\Web\Domain\Stream\BlogComment\MysqlBlogCommentRepository as BlogCommentRepository;
7
8		$blogRepository = new BlogRepository($container['db_connection_locator']);
9		$mostRecentBlog = $blogRepository->getBlogs(1);
10		$mostRecentBlog = current($mostRecentBlog);
11		$mostRecentBlogDateTime = $mostRecentBlog['datetime'];
12		$mostRecentBlogDateTime = new DateTime($mostRecentBlogDateTime);
13
14		$blogFeed = Feed::loadRss('http://blog.jacobemerick.com/rss.xml');
15	View Code Duplication	foreach ($blogFeed->item as $item) {
16		$datetime = new DateTime($item->pubDate);
17		if ($datetime <= $mostRecentBlogDateTime) {
		0 ignored issues – show Unused Code introduced 2016-01-18 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
18		// break;
19		}
20
21		$uniqueBlogCheck = $blogRepository->getBlogByPermalink((string) $item->guid);
22		if ($uniqueBlogCheck !== false) {
23		continue;
24		}
25
26		$datetime->setTimezone($container['default_timezone']);
27		$metadata = json_decode(json_encode($item), true);
28
29		$blogRepository->insertBlog(
30		(string) $item->guid,
31		$datetime,
32		$metadata
33		);
34		}
35
36		$blogCommentRepository = new BlogCommentRepository($container['db_connection_locator']);
37		$mostRecentBlogComment = $blogCommentRepository->getBlogComments(1);
38		$mostRecentBlogComment = current($mostRecentBlogComment);
39		$mostRecentBlogCommentDateTime = $mostRecentBlogComment['datetime'];
40		$mostRecentBlogCommentDateTime = new DateTime($mostRecentBlogCommentDateTime);
41
42		$commentFeed = Feed::loadRss('http://blog.jacobemerick.com/rss-comments.xml');
43	View Code Duplication	foreach ($commentFeed->item as $item) {
44		$datetime = new DateTime($item->pubDate);
45		if ($datetime <= $mostRecentBlogCommentDateTime) {
46		break;
47		}
48
49		$uniqueBlogCommentCheck = $blogCommentRepository->getBlogCommentByPermalink((string) $item->guid);
50		if ($uniqueBlogCommentCheck !== false) {
51		continue;
52		}
53
54		$datetime->setTimezone($container['default_timezone']);
55		$metadata = json_decode(json_encode($item), true);
56
57		$blogCommentRepository->insertBlogComment(
58		(string) $item->guid,
59		$datetime,
60		$metadata
61		);
62		}
63

jacobemerick / web

Pull Request — master (#4)

script/cron/fetch-blog-activity.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like